Re: [PR] [FLINK-36192][autocaler] Autocaler supports adjusting the parallelism of source vertex based on the number of partitions in Kafka or pulsars [flink-kubernetes-operator]

2024-09-11 Thread via GitHub
huyuanfeng2018 commented on code in PR #879: URL: https://github.com/apache/flink-kubernetes-operator/pull/879#discussion_r1756220655 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobVertexScaler.java: ## @@ -378,28 +405,70 @@ protected static int scale(

Re: [PR] [FLINK-36192][autocaler] Autocaler supports adjusting the parallelism of source vertex based on the number of partitions in Kafka or pulsars [flink-kubernetes-operator]

2024-09-11 Thread via GitHub
huyuanfeng2018 commented on code in PR #879: URL: https://github.com/apache/flink-kubernetes-operator/pull/879#discussion_r1756214335 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobVertexScaler.java: ## @@ -378,28 +405,70 @@ protected static int scale(

Re: [PR] [WIP][FLINK-35780] Support state migration from disabling to enabling ttl for RocksDBState [flink]

2024-09-11 Thread via GitHub
xiangyuf commented on PR #25035: URL: https://github.com/apache/flink/pull/25035#issuecomment-2345379842 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-35027] Drain async state request before snapshot barrier [flink]

2024-09-11 Thread via GitHub
Zakelly commented on code in PR #25317: URL: https://github.com/apache/flink/pull/25317#discussion_r1756207229 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/AbstractAsyncStateStreamOperator.java: ## @@ -212,19 +209,10 @@ protected S getOrCrea

Re: [PR] [FLINK-36192][autocaler] Autocaler supports adjusting the parallelism of source vertex based on the number of partitions in Kafka or pulsars [flink-kubernetes-operator]

2024-09-11 Thread via GitHub
huyuanfeng2018 commented on code in PR #879: URL: https://github.com/apache/flink-kubernetes-operator/pull/879#discussion_r1756201413 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobVertexScaler.java: ## @@ -191,16 +200,29 @@ public ParallelismChange computeSca

[jira] [Assigned] (FLINK-36210) Optimize the logic for fetching topic metadata in the TopicPatternSubscriber mode

2024-09-11 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arvid Heise reassigned FLINK-36210: --- Assignee: xiaochen.zhou > Optimize the logic for fetching topic metadata in the TopicPatter

[jira] [Resolved] (FLINK-36210) Optimize the logic for fetching topic metadata in the TopicPatternSubscriber mode

2024-09-11 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arvid Heise resolved FLINK-36210. - Fix Version/s: kafka-3.3.0 Resolution: Fixed Merged into main as https://github.com/apac

Re: [PR] [FLINK-35027] Drain async state request before snapshot barrier [flink]

2024-09-11 Thread via GitHub
fredia commented on code in PR #25317: URL: https://github.com/apache/flink/pull/25317#discussion_r1756189685 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/AbstractAsyncStateStreamOperator.java: ## @@ -212,19 +209,10 @@ protected S getOrCreat

Re: [PR] [FLINK-36210] Optimize the logic for fetching topic metadata in the TopicPatternSubscriber mode [flink-connector-kafka]

2024-09-11 Thread via GitHub
AHeise commented on PR #117: URL: https://github.com/apache/flink-connector-kafka/pull/117#issuecomment-2345354188 Merged, thank you for your contribution :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] [FLINK-36210] Optimize the logic for fetching topic metadata in the TopicPatternSubscriber mode [flink-connector-kafka]

2024-09-11 Thread via GitHub
boring-cyborg[bot] commented on PR #117: URL: https://github.com/apache/flink-connector-kafka/pull/117#issuecomment-2345353448 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] [FLINK-36210] Optimize the logic for fetching topic metadata in the TopicPatternSubscriber mode [flink-connector-kafka]

2024-09-11 Thread via GitHub
AHeise merged PR #117: URL: https://github.com/apache/flink-connector-kafka/pull/117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] [FLINK-35027] Drain async state request before snapshot barrier [flink]

2024-09-11 Thread via GitHub
flinkbot commented on PR #25317: URL: https://github.com/apache/flink/pull/25317#issuecomment-2345293103 ## CI report: * 5552f72db70f08f57d1f6551554af8f332877c59 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-35027] Drain async state request before snapshot barrier [flink]

2024-09-11 Thread via GitHub
Zakelly opened a new pull request, #25317: URL: https://github.com/apache/flink/pull/25317 ## What is the purpose of the change Async state needs to be drained before the snapshot barrier being broadcast to downstream. However, there is an issue that we do drain during snapshot. This

Re: [PR] [FLINK-35927][state/forst] Make ForStFlinkFileSystem write misc file in local filesystem [flink]

2024-09-11 Thread via GitHub
fredia commented on PR #25310: URL: https://github.com/apache/flink/pull/25310#issuecomment-2345277226 @Zakelly Thanks for the detailed review, I have fixed the broken test `ForStStateBackendConfigTest#testRemoteDirectory` and updated PR. -- This is an automated message from the Apache Gi

Re: [PR] [FLINK-35927][state/forst] Make ForStFlinkFileSystem write misc file in local filesystem [flink]

2024-09-11 Thread via GitHub
fredia commented on code in PR #25310: URL: https://github.com/apache/flink/pull/25310#discussion_r1756117771 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/ForStFlinkFileSystem.java: ## @@ -101,6 +142,12 @@ public boolean rename(P

Re: [PR] [FLINK-35927][state/forst] Make ForStFlinkFileSystem write misc file in local filesystem [flink]

2024-09-11 Thread via GitHub
fredia commented on code in PR #25310: URL: https://github.com/apache/flink/pull/25310#discussion_r1756117243 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/ForStFlinkFileSystem.java: ## @@ -61,6 +70,16 @@ public static FileSystem

Re: [PR] [FLINK-36209] Remove redundant operations in the initialization of KafkaSourceEnumState [flink-connector-kafka]

2024-09-11 Thread via GitHub
xiaochen-zhou commented on code in PR #116: URL: https://github.com/apache/flink-connector-kafka/pull/116#discussion_r1756090564 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/enumerator/KafkaSourceEnumStateSerializer.java: ## @@ -113,23 +111,26

[jira] [Commented] (FLINK-34168) Refactor all callers that using the public Xxx getXxx(String key) and public void setXxx(String key, Xxx value)

2024-09-11 Thread Xuannan Su (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881164#comment-17881164 ] Xuannan Su commented on FLINK-34168: master(2.0): 740a5674fd92e4a7471432908071002316

[jira] [Resolved] (FLINK-34168) Refactor all callers that using the public Xxx getXxx(String key) and public void setXxx(String key, Xxx value)

2024-09-11 Thread Xuannan Su (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xuannan Su resolved FLINK-34168. Fix Version/s: 2.0-preview Resolution: Fixed > Refactor all callers that using the public X

Re: [PR] [FLINK-34168][config] Refactor callers that use deprecated get/setXXX [flink]

2024-09-11 Thread via GitHub
Sxnan merged PR #25301: URL: https://github.com/apache/flink/pull/25301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

[jira] [Created] (FLINK-36267) SPLIT doesn't support SMP characters if delimiter is empty

2024-09-11 Thread Dylan He (Jira)
Dylan He created FLINK-36267: Summary: SPLIT doesn't support SMP characters if delimiter is empty Key: FLINK-36267 URL: https://issues.apache.org/jira/browse/FLINK-36267 Project: Flink Issue Type

[jira] [Comment Edited] (FLINK-35523) When using the Hive connector to read a Hive table in Parquet format, a null pointer exception is thrown.

2024-09-11 Thread Jichao Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869578#comment-17869578 ] Jichao Wang edited comment on FLINK-35523 at 9/12/24 3:21 AM:

Re: [PR] [FLINK-36209] Remove redundant operations in the initialization of KafkaSourceEnumState [flink-connector-kafka]

2024-09-11 Thread via GitHub
xiaochen-zhou commented on code in PR #116: URL: https://github.com/apache/flink-connector-kafka/pull/116#discussion_r1756038253 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/enumerator/KafkaSourceEnumStateSerializer.java: ## @@ -113,23 +111,26

[jira] [Updated] (FLINK-34511) Flink 2.0: Remove legacy State&Checkpointing&Recovery options

2024-09-11 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan updated FLINK-34511: Summary: Flink 2.0: Remove legacy State&Checkpointing&Recovery options (was: Flink 2.0: Deprecate

[jira] [Updated] (FLINK-34255) FLIP-406: Reorganize State & Checkpointing & Recovery Configuration

2024-09-11 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan updated FLINK-34255: Fix Version/s: 2.0-preview (was: 2.0.0) > FLIP-406: Reorganize State & Chec

[jira] [Assigned] (FLINK-34511) Flink 2.0: Remove legacy State&Checkpointing&Recovery options

2024-09-11 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan reassigned FLINK-34511: --- Assignee: Zakelly Lan > Flink 2.0: Remove legacy State&Checkpointing&Recovery options > ---

Re: [PR] [FLINK-35927][state/forst] Make ForStFlinkFileSystem write misc file in local filesystem [flink]

2024-09-11 Thread via GitHub
Zakelly commented on code in PR #25310: URL: https://github.com/apache/flink/pull/25310#discussion_r1756001947 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/ForStFlinkFileSystem.java: ## @@ -101,6 +142,12 @@ public boolean rename(

Re: [PR] [FLINK-36160] Support hive advanced configuration [flink]

2024-09-11 Thread via GitHub
zhuanshenbsj1 commented on PR #25258: URL: https://github.com/apache/flink/pull/25258#issuecomment-2345139801 @luoyuxia cc~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-36013] [runtime] Introduce the transition from Restarting to CreatingExecutionGraph state [flink]

2024-09-11 Thread via GitHub
fredia commented on PR #25304: URL: https://github.com/apache/flink/pull/25304#issuecomment-2345122475 @XComp I didn't merge this PR, and I checked the master branch and it does not include the commits of this PR. 👀 Not sure if this is related https://github.com/orgs/community/discussion

Re: [PR] [FLINK-33750][config] Remove unused deprecated option [flink]

2024-09-11 Thread via GitHub
1996fanrui commented on code in PR #25314: URL: https://github.com/apache/flink/pull/25314#discussion_r1755981219 ## flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/NettyShuffleEnvironmentConfiguration.java: ## @@ -356,27 +354,9 @@ public static NettyShuffleEnvi

[jira] [Updated] (FLINK-35795) FLIP-466: Introduce ProcessFunction Attribute in DataStream API V2

2024-09-11 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-35795: --- Component/s: API / DataStream > FLIP-466: Introduce ProcessFunction Attribute in DataStream API V2 >

[jira] [Closed] (FLINK-35795) FLIP-466: Introduce ProcessFunction Attribute in DataStream API V2

2024-09-11 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-35795. -- Fix Version/s: 2.0.0 Resolution: Done master(2.0) via 4d131705b19d06f55f94cc6e19728488fa5448f1.

[jira] [Updated] (FLINK-35795) FLIP-466: Introduce ProcessFunction Attribute in DataStream API V2

2024-09-11 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-35795: --- Affects Version/s: 2.0.0 > FLIP-466: Introduce ProcessFunction Attribute in DataStream API V2 >

[jira] [Assigned] (FLINK-35795) FLIP-466: Introduce ProcessFunction Attribute in DataStream API V2

2024-09-11 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-35795: -- Assignee: xuhuang (was: Wencong Liu) > FLIP-466: Introduce ProcessFunction Attribute in Data

Re: [PR] [FLINK-35795][API] Introduce ProcessFunction Attribute in DataStream API V2 [flink]

2024-09-11 Thread via GitHub
reswqa merged PR #25276: URL: https://github.com/apache/flink/pull/25276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Assigned] (FLINK-36251) Remove StateBackend-related configuration getters/setters that return/set complex Java objects

2024-09-11 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu reassigned FLINK-36251: --- Assignee: Junrui Li > Remove StateBackend-related configuration getters/setters that return/set >

[jira] [Assigned] (FLINK-36249) Remove RestartStrategy-related configuration getters/setters that return/set complex Java objects

2024-09-11 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu reassigned FLINK-36249: --- Assignee: Junrui Li > Remove RestartStrategy-related configuration getters/setters that return/set

[jira] [Assigned] (FLINK-36250) Remove CheckpointStorage-related configuration getters/setters that return/set complex Java objects

2024-09-11 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu reassigned FLINK-36250: --- Assignee: Junrui Li > Remove CheckpointStorage-related configuration getters/setters that > return

[jira] [Commented] (FLINK-36185) Remove RuntimeContext#getExecutionConfig

2024-09-11 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881152#comment-17881152 ] Zhu Zhu commented on FLINK-36185: - 581a4f761d231166f1471fcd1f18ae55df680983 d564e8892645

[jira] [Closed] (FLINK-36185) Remove RuntimeContext#getExecutionConfig

2024-09-11 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-36185. --- Release Note: The public method `RuntimeContext#getExecutionConfig()`, which was deprecated in FLINK-33713/F

Re: [PR] [FLINK-36185][core] Remove RuntimeContext#getExecutionConfig [flink]

2024-09-11 Thread via GitHub
zhuzhurk closed pull request #25270: [FLINK-36185][core] Remove RuntimeContext#getExecutionConfig URL: https://github.com/apache/flink/pull/25270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-35510][statebackend] Implement basic incremental checkpoint fo… [flink]

2024-09-11 Thread via GitHub
zoltar9264 commented on code in PR #24879: URL: https://github.com/apache/flink/pull/24879#discussion_r1755949108 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/snapshot/ForStSnapshotStrategyBase.java: ## @@ -0,0 +1,344 @@ +/* + * Lic

Re: [PR] [FLINK-35510][statebackend] Implement basic incremental checkpoint fo… [flink]

2024-09-11 Thread via GitHub
zoltar9264 commented on PR #24879: URL: https://github.com/apache/flink/pull/24879#issuecomment-2345069557 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Closed] (FLINK-36230) REGEXP_EXTRACT Python Table API fails

2024-09-11 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-36230. --- Fix Version/s: 2.0-preview Assignee: Dylan He Resolution: Fixed fixed in master: 8c6

Re: [PR] [FLINK-35510][statebackend] Implement basic incremental checkpoint fo… [flink]

2024-09-11 Thread via GitHub
zoltar9264 commented on code in PR #24879: URL: https://github.com/apache/flink/pull/24879#discussion_r1755945171 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/v2/RegisteredKeyValueStateBackendMetaInfo.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Sof

[jira] [Closed] (FLINK-35827) Equality bewteen a row field and a row constant is wrong in SQL

2024-09-11 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-35827. --- Fix Version/s: 2.0-preview Assignee: xuyang Resolution: Fixed fixed in master: 54b0d

[jira] [Closed] (FLINK-36142) Remove TestTableSourceWithTime and its subclasses to prepare to remove TableEnvironmentInternal#registerTableSourceInternal

2024-09-11 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-36142. --- Resolution: Fixed fixed in master: 8b8e695188114c7087d3a9ed83fc9f2ee2776339 > Remove TestTableSourc

Re: [PR] [FLINK-36230][pyflink-table] Fix the incorrect calling of REGEXP_EXTRACT Python Table API [flink]

2024-09-11 Thread via GitHub
lincoln-lil merged PR #25309: URL: https://github.com/apache/flink/pull/25309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

Re: [PR] [FLINK-36142][table] Remove TestTableSourceWithTime and its subclasses to prepare removing TableEnvironmentInternal#registerTableSourceInternal [flink]

2024-09-11 Thread via GitHub
lincoln-lil merged PR #25243: URL: https://github.com/apache/flink/pull/25243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

Re: [PR] [FLINK-36266][table] Insert into as select * behaves incorrect [flink]

2024-09-11 Thread via GitHub
flinkbot commented on PR #25316: URL: https://github.com/apache/flink/pull/25316#issuecomment-2344986515 ## CI report: * bd1b0ce7b547c267e02c754607f663142dad4477 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-36266) Insert into as select * behaves incorrect

2024-09-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36266: --- Labels: pull-request-available (was: ) > Insert into as select * behaves incorrect > --

[PR] [FLINK-36266][table] Insert into as select * behaves incorrect [flink]

2024-09-11 Thread via GitHub
snuyanzin opened a new pull request, #25316: URL: https://github.com/apache/flink/pull/25316 ## What is the purpose of the change The PR fixes behavior for insert into queries with select * like ```sql INSERT INTO t(f0, f1 ,f2) SELECT * FROM t1; ``` ## Verifyin

[jira] [Updated] (FLINK-36266) Insert into as select * behaves incorrect

2024-09-11 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-36266: Description: For instance if there are 2 tables {code:sql} t(f0: INT, f1: INT, f2: INT) t3

[jira] [Updated] (FLINK-36266) Insert into as select * behaves incorrect

2024-09-11 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-36266: Description: For instance if there are 2 tables {code:sql} t(f0: INT, f1: INT) t1(f0: INT)

[jira] [Updated] (FLINK-36266) Insert into as select * behaves incorrect

2024-09-11 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-36266: Description: For instance if there are 2 tables {code:sql} t(f0: INT, f1: INT) t1(f0: INT)

[jira] [Created] (FLINK-36266) Insert into as select * behaves incorrect

2024-09-11 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-36266: --- Summary: Insert into as select * behaves incorrect Key: FLINK-36266 URL: https://issues.apache.org/jira/browse/FLINK-36266 Project: Flink Issue Type: B

Re: [PR] [FLINK-36192][autocaler] Autocaler supports adjusting the parallelism of source vertex based on the number of partitions in Kafka or pulsars [flink-kubernetes-operator]

2024-09-11 Thread via GitHub
mxm commented on code in PR #879: URL: https://github.com/apache/flink-kubernetes-operator/pull/879#discussion_r1754969067 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobVertexScaler.java: ## @@ -378,28 +405,70 @@ protected static int scale( // Cap

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-09-11 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1755375741 ## flink-connector-prometheus/README.md: ## @@ -0,0 +1,260 @@ +## Flink Prometheus connector (sink) + +Implementation of the Prometheus sink connector for

Re: [PR] FLINK-36197 bump curator-test, derby and postgres [flink-kubernetes-operator]

2024-09-11 Thread via GitHub
r-sidd commented on PR #878: URL: https://github.com/apache/flink-kubernetes-operator/pull/878#issuecomment-230495 > @r-sidd it would be great to bundle test-dependency upgrades together in 1-2 PRs if you are going to do any further @gyfora sorry couldn't find time to address the

[jira] [Updated] (FLINK-36197) bump curator-test, derby and postgres

2024-09-11 Thread Siddharth R (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siddharth R updated FLINK-36197: Summary: bump curator-test, derby and postgres (was: Bump curator-test version) > bump curator-t

[jira] [Updated] (FLINK-36197) Bump curator-test version

2024-09-11 Thread Siddharth R (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siddharth R updated FLINK-36197: Description: Bump curator-test version to latest (5.7.0) to remediate the vulnerabilities in the

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-09-11 Thread via GitHub
nicusX commented on PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#issuecomment-2344434793 @hlteoh37 I addressed all remaining comments above -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[jira] [Resolved] (FLINK-36262) Avoid unnecessary String concatenations in the RexFieldAccess constructor: port fix for CALCITE-5965

2024-09-11 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-36262. - Fix Version/s: 2.0-preview Resolution: Fixed > Avoid unnecessary String concatena

[jira] [Commented] (FLINK-36262) Avoid unnecessary String concatenations in the RexFieldAccess constructor: port fix for CALCITE-5965

2024-09-11 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881095#comment-17881095 ] Sergey Nuyanzin commented on FLINK-36262: - Merged as [ab230adeab1ca35af8deb2e73

Re: [PR] [FLINK-36262][table] Avoid unnecessary String concatenations in the RexFieldAccess constructor: port fix for CALCITE-5965 [flink]

2024-09-11 Thread via GitHub
snuyanzin merged PR #25312: URL: https://github.com/apache/flink/pull/25312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-36262][table] Avoid unnecessary String concatenations in the RexFieldAccess constructor: port fix for CALCITE-5965 [flink]

2024-09-11 Thread via GitHub
snuyanzin commented on PR #25312: URL: https://github.com/apache/flink/pull/25312#issuecomment-2344366745 for some reason flinkbot/github/azure integration was not able to detect that the ci passed https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=62002&view=results

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-09-11 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1755176342 ## flink-connector-prometheus/README.md: ## @@ -0,0 +1,260 @@ +## Flink Prometheus connector (sink) + +Implementation of the Prometheus sink connector for

Re: [PR] [FLINK-35401][Connectors/Sqs] Add Sqs Table API connector [flink-connector-aws]

2024-09-11 Thread via GitHub
hlteoh37 commented on code in PR #155: URL: https://github.com/apache/flink-connector-aws/pull/155#discussion_r1755166214 ## flink-connector-aws/flink-connector-sqs/src/main/java/org/apache/flink/connector/sqs/table/SqsDynamicSink.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-09-11 Thread via GitHub
hlteoh37 commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1754639229 ## flink-connector-prometheus/README.md: ## @@ -0,0 +1,260 @@ +## Flink Prometheus connector (sink) + +Implementation of the Prometheus sink connector fo

[jira] [Created] (FLINK-36265) List and track the deprecated APIs for the 2.0-preview release.

2024-09-11 Thread Jiangjie Qin (Jira)
Jiangjie Qin created FLINK-36265: Summary: List and track the deprecated APIs for the 2.0-preview release. Key: FLINK-36265 URL: https://issues.apache.org/jira/browse/FLINK-36265 Project: Flink

[jira] [Assigned] (FLINK-36265) List and track the deprecated APIs for the 2.0-preview release.

2024-09-11 Thread Jiangjie Qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin reassigned FLINK-36265: Assignee: Jiangjie Qin > List and track the deprecated APIs for the 2.0-preview release.

[jira] [Updated] (FLINK-36265) List and track the deprecated APIs for the 2.0-preview release.

2024-09-11 Thread Jiangjie Qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated FLINK-36265: - Fix Version/s: 2.0-preview > List and track the deprecated APIs for the 2.0-preview release. > -

Re: [PR] [FLINK-35510][statebackend] Implement basic incremental checkpoint fo… [flink]

2024-09-11 Thread via GitHub
zoltar9264 commented on PR #24879: URL: https://github.com/apache/flink/pull/24879#issuecomment-2344138463 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [FLINK-36262][table] Avoid unnecessary String concatenations in the RexFieldAccess constructor: port fix for CALCITE-5965 [flink]

2024-09-11 Thread via GitHub
snuyanzin commented on code in PR #25312: URL: https://github.com/apache/flink/pull/25312#discussion_r1754991610 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/rex/RexFieldAccess.java: ## @@ -49,6 +49,12 @@ * AND gender = 'F') * * + * + * FLINK mo

Re: [PR] Parameter spelling correction [flink]

2024-09-11 Thread via GitHub
bugbubug closed pull request #25282: Parameter spelling correction URL: https://github.com/apache/flink/pull/25282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] [FLINK-36262][table] Avoid unnecessary String concatenations in the RexFieldAccess constructor: port fix for CALCITE-5965 [flink]

2024-09-11 Thread via GitHub
snuyanzin commented on code in PR #25312: URL: https://github.com/apache/flink/pull/25312#discussion_r1754991610 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/rex/RexFieldAccess.java: ## @@ -49,6 +49,12 @@ * AND gender = 'F') * * + * + * FLINK mo

Re: [PR] [FLINK-36262][table] Avoid unnecessary String concatenations in the RexFieldAccess constructor: port fix for CALCITE-5965 [flink]

2024-09-11 Thread via GitHub
jnh5y commented on code in PR #25312: URL: https://github.com/apache/flink/pull/25312#discussion_r1754980629 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/rex/RexFieldAccess.java: ## @@ -49,6 +49,12 @@ * AND gender = 'F') * * + * + * FLINK modifi

Re: [PR] Release 1.20 The spelling correction of the ogg format parameter in the json format part of the Chinese document [flink]

2024-09-11 Thread via GitHub
bugbubug closed pull request #25281: Release 1.20 The spelling correction of the ogg format parameter in the json format part of the Chinese document URL: https://github.com/apache/flink/pull/25281 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Parameter spelling correction [flink]

2024-09-11 Thread via GitHub
bugbubug commented on PR #25282: URL: https://github.com/apache/flink/pull/25282#issuecomment-2343931205 @flinkbot run azure re-run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] fix download link to filesystem-test-utils jar [flink]

2024-09-11 Thread via GitHub
flinkbot commented on PR #25315: URL: https://github.com/apache/flink/pull/25315#issuecomment-2343890314 ## CI report: * 1fc1588ee9c1797cf6308ac081510ff4494cefc2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34467] bump flink version to 1.20.0 [flink-connector-kafka]

2024-09-11 Thread via GitHub
AHeise commented on PR #111: URL: https://github.com/apache/flink-connector-kafka/pull/111#issuecomment-2343807844 > @AHeise I am trying to work on that within this PR -> https://github.com/pawel-big-lebowski/flink-connector-kafka/pull/1/files. What would be the best way to show whether it

Re: [PR] [FLINK-34467] bump flink version to 1.20.0 [flink-connector-kafka]

2024-09-11 Thread via GitHub
AHeise commented on PR #111: URL: https://github.com/apache/flink-connector-kafka/pull/111#issuecomment-2343804616 > @AHeise I am trying to work on that within this PR -> https://github.com/pawel-big-lebowski/flink-connector-kafka/pull/1/files. What would be the best way to show whether it

Re: [PR] [FLINK-36209] Remove redundant operations in the initialization of KafkaSourceEnumState [flink-connector-kafka]

2024-09-11 Thread via GitHub
AHeise commented on code in PR #116: URL: https://github.com/apache/flink-connector-kafka/pull/116#discussion_r1754681870 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/enumerator/KafkaSourceEnumStateSerializer.java: ## @@ -113,23 +111,26 @@ publ

Re: [PR] [FLINK-36262][table] Avoid unnecessary String concatenations in the RexFieldAccess constructor: port fix for CALCITE-5965 [flink]

2024-09-11 Thread via GitHub
snuyanzin commented on PR #25312: URL: https://github.com/apache/flink/pull/25312#issuecomment-2343643014 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Comment Edited] (FLINK-36264) Unable to customize rest-service.exposed.type parameter

2024-09-11 Thread chenyuzhi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17880965#comment-17880965 ] chenyuzhi edited comment on FLINK-36264 at 9/11/24 12:54 PM: -

[jira] [Comment Edited] (FLINK-36264) Unable to customize rest-service.exposed.type parameter

2024-09-11 Thread chenyuzhi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17880965#comment-17880965 ] chenyuzhi edited comment on FLINK-36264 at 9/11/24 12:52 PM: -

Re: [PR] [FLINK-33750][config] Remove unused deprecated option [flink]

2024-09-11 Thread via GitHub
flinkbot commented on PR #25314: URL: https://github.com/apache/flink/pull/25314#issuecomment-2343587532 ## CI report: * 137f4f8db2a9c783885bb28c055f4978998da890 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Comment Edited] (FLINK-36264) Unable to customize rest-service.exposed.type parameter

2024-09-11 Thread chenyuzhi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17880965#comment-17880965 ] chenyuzhi edited comment on FLINK-36264 at 9/11/24 12:51 PM: -

[jira] [Commented] (FLINK-36264) Unable to customize rest-service.exposed.type parameter

2024-09-11 Thread chenyuzhi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17880965#comment-17880965 ] chenyuzhi commented on FLINK-36264: ---  I think it's the code [FlinkConfigBuilder.java#

[jira] [Closed] (FLINK-36254) ChangelogRecoverySwitchStateBackendITCase.testSwitchFromEnablingToDisablingWithRescalingOut failed on AZP

2024-09-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl closed FLINK-36254. - Resolution: Duplicate It's a duplicate of FLINK-35499 > ChangelogRecoverySwitchStateBackendITCa

[jira] [Commented] (FLINK-36254) ChangelogRecoverySwitchStateBackendITCase.testSwitchFromEnablingToDisablingWithRescalingOut failed on AZP

2024-09-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17880962#comment-17880962 ] Matthias Pohl commented on FLINK-36254: --- I checked the Maven logs. There's an {{Il

[jira] [Updated] (FLINK-36254) ChangelogRecoverySwitchStateBackendITCase.testSwitchFromEnablingToDisablingWithRescalingOut failed on AZP

2024-09-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-36254: -- Labels: test-stability (was: ) > ChangelogRecoverySwitchStateBackendITCase.testSwitchFromEnab

[jira] [Updated] (FLINK-36264) Unable to customize rest-service.exposed.type parameter

2024-09-11 Thread chenyuzhi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenyuzhi updated FLINK-36264: -- Description: When I  create flinkdeployment with flinkconfiguration : {code:java} apiVersion: flink.ap

[jira] [Updated] (FLINK-36264) Unable to customize rest-service.exposed.type parameter

2024-09-11 Thread chenyuzhi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenyuzhi updated FLINK-36264: -- Description: When I  create flinkdeployment with flinkconfiguration : {code:java} apiVersion: flink.ap

[jira] [Updated] (FLINK-36264) Unable to customize rest-service.exposed.type parameter

2024-09-11 Thread chenyuzhi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenyuzhi updated FLINK-36264: -- Environment: (was: When I  create flinkdeployment with flinkconfiguration : {code:java} apiVersion

[jira] [Updated] (FLINK-36264) Unable to customize rest-service.exposed.type parameter

2024-09-11 Thread chenyuzhi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenyuzhi updated FLINK-36264: -- Description: When I  create flinkdeployment with flinkconfiguration : {code:java} apiVersion: flink.ap

[jira] [Created] (FLINK-36264) Unable to customize rest-service.exposed.type parameter

2024-09-11 Thread chenyuzhi (Jira)
chenyuzhi created FLINK-36264: - Summary: Unable to customize rest-service.exposed.type parameter Key: FLINK-36264 URL: https://issues.apache.org/jira/browse/FLINK-36264 Project: Flink Issue Type:

Re: [PR] [FLINK-34168][config] Refactor callers that use deprecated get/setXXX [flink]

2024-09-11 Thread via GitHub
Sxnan commented on PR #25301: URL: https://github.com/apache/flink/pull/25301#issuecomment-2343557771 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [FLINK-35927][state/forst] Make ForStFlinkFileSystem write misc file in local filesystem [flink]

2024-09-11 Thread via GitHub
fredia commented on code in PR #25310: URL: https://github.com/apache/flink/pull/25310#discussion_r1754349257 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/ByteBufferWritableFSDataOutputStream.java: ## @@ -104,4 +109,8 @@ public v

[jira] [Updated] (FLINK-33750) Remove deprecated config options.

2024-09-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33750: --- Labels: 2.0-related pull-request-available (was: 2.0-related) > Remove deprecated config op

  1   2   >