[GitHub] flink pull request #6228: [FLINK-9491] Implement timer data structure based ...

2018-06-29 Thread StefanRRichter
GitHub user StefanRRichter opened a pull request: https://github.com/apache/flink/pull/6228 [FLINK-9491] Implement timer data structure based on RocksDB ## What is the purpose of the change This PR is another step towards integrating the timer state with the keyed state

[GitHub] flink pull request #6227: [FLINK-9491] Implement timer data structure based ...

2018-06-29 Thread StefanRRichter
Github user StefanRRichter closed the pull request at: https://github.com/apache/flink/pull/6227 ---

[GitHub] flink pull request #6227: Heap abstractions rocks

2018-06-29 Thread StefanRRichter
GitHub user StefanRRichter opened a pull request: https://github.com/apache/flink/pull/6227 Heap abstractions rocks ## What is the purpose of the change This PR is another step towards integrating the timer state with the keyed state backends. First, the PR

[GitHub] flink pull request #6208: [FLINK-9634] Disable local recovery scheduling if ...

2018-06-27 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6208#discussion_r198453459 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/LocationPreferenceSchedulingStrategy.java --- @@ -0,0 +1,119

[GitHub] flink issue #6208: [FLINK-9634] Disable local recovery scheduling if local r...

2018-06-26 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/6208 I think this is a good fix for the moment. Only had minor comments inline. LGTM 👍 ---

[GitHub] flink pull request #6208: [FLINK-9634] Disable local recovery scheduling if ...

2018-06-26 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6208#discussion_r198146744 --- Diff: flink-tests/src/test/resources/log4j-test.properties --- @@ -18,7 +18,7 @@ # Set root logger level to OFF to not flood build logs

[GitHub] flink pull request #6208: [FLINK-9634] Disable local recovery scheduling if ...

2018-06-26 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6208#discussion_r198146426 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SchedulingStrategy.java --- @@ -0,0 +1,60

[GitHub] flink pull request #6208: [FLINK-9634] Disable local recovery scheduling if ...

2018-06-26 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6208#discussion_r198142541 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/PreviousAllocationSchedulingStrategy.java --- @@ -0,0 +1,85

[GitHub] flink pull request #6208: [FLINK-9634] Disable local recovery scheduling if ...

2018-06-26 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6208#discussion_r198142470 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/LocationPreferenceSchedulingStrategy.java --- @@ -0,0 +1,119

[GitHub] flink pull request #6208: [FLINK-9634] Disable local recovery scheduling if ...

2018-06-26 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6208#discussion_r198122538 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java --- @@ -280,12 +281,7 @@ public JobMaster

[GitHub] flink pull request #6208: [FLINK-9634] Disable local recovery scheduling if ...

2018-06-26 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6208#discussion_r198121746 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java --- @@ -280,12 +281,7 @@ public JobMaster

[GitHub] flink issue #6196: [FLINK-9513] Implement TTL state wrappers factory and ser...

2018-06-26 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/6196 Thanks for the nice contribution. I had some comments inline. In particular three points about the serializer. I would suggest to avoid the use of raw types. I would also suggest to avoid

[GitHub] flink pull request #6196: [FLINK-9513] Implement TTL state wrappers factory ...

2018-06-26 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6196#discussion_r198115772 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeSerializer.java --- @@ -0,0 +1,204 @@ +package

[GitHub] flink pull request #6196: [FLINK-9513] Implement TTL state wrappers factory ...

2018-06-26 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6196#discussion_r198115714 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeSerializer.java --- @@ -0,0 +1,204 @@ +package

[GitHub] flink pull request #6196: [FLINK-9513] Implement TTL state wrappers factory ...

2018-06-26 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6196#discussion_r198115667 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeSerializer.java --- @@ -0,0 +1,204 @@ +package

[GitHub] flink pull request #6196: [FLINK-9513] Implement TTL state wrappers factory ...

2018-06-26 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6196#discussion_r198114853 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeSerializer.java --- @@ -0,0 +1,204 @@ +package

[GitHub] flink pull request #6196: [FLINK-9513] Implement TTL state wrappers factory ...

2018-06-26 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6196#discussion_r198113448 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeSerializer.java --- @@ -0,0 +1,204 @@ +package

[GitHub] flink pull request #6196: [FLINK-9513] Implement TTL state wrappers factory ...

2018-06-26 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6196#discussion_r198113175 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeSerializer.java --- @@ -0,0 +1,204 @@ +package

[GitHub] flink pull request #6196: [FLINK-9513] Implement TTL state wrappers factory ...

2018-06-26 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6196#discussion_r198062463 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlStateFactory.java --- @@ -0,0 +1,207 @@ +/* + * Licensed

[GitHub] flink pull request #6196: [FLINK-9513] Implement TTL state wrappers factory ...

2018-06-26 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6196#discussion_r198061894 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlStateFactory.java --- @@ -0,0 +1,207 @@ +/* + * Licensed

[GitHub] flink pull request #6196: [FLINK-9513] Implement TTL state wrappers factory ...

2018-06-26 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6196#discussion_r198060715 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlStateFactory.java --- @@ -0,0 +1,207 @@ +/* + * Licensed

[GitHub] flink pull request #6196: [FLINK-9513] Implement TTL state wrappers factory ...

2018-06-26 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6196#discussion_r198058861 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedStateFactory.java --- @@ -0,0 +1,41 @@ +/* + * Licensed

[GitHub] flink issue #5777: [FLINK-7897] Consider using nio.Files for file deletion i...

2018-06-26 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5777 LGTM 👍 Will merge. ---

[GitHub] flink issue #6186: [FLINK-9514,FLINK-9515,FLINK-9516] State ttl wrappers

2018-06-25 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/6186 @azagrebin I think the overall idea is well implemented. I just had a couple of comments inline. ---

[GitHub] flink issue #6186: [FLINK-9514,FLINK-9515,FLINK-9516] State ttl wrappers

2018-06-25 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/6186 @sihuazhou I think your concern and suggestion can clearly make sense for some cases. However I don't think it should be a general default as well because I can also find cases where

[GitHub] flink pull request #6186: [FLINK-9514,FLINK-9515,FLINK-9516] State ttl wrapp...

2018-06-25 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6186#discussion_r197719642 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/ttl/TtlListStateTest.java --- @@ -0,0 +1,91 @@ +/* + * Licensed

[GitHub] flink pull request #6186: [FLINK-9514,FLINK-9515,FLINK-9516] State ttl wrapp...

2018-06-25 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6186#discussion_r197719310 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/ttl/TtlStateTestBase.java --- @@ -0,0 +1,153 @@ +/* + * Licensed

[GitHub] flink pull request #6186: [FLINK-9514,FLINK-9515,FLINK-9516] State ttl wrapp...

2018-06-25 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6186#discussion_r197714098 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlListState.java --- @@ -0,0 +1,172 @@ +/* + * Licensed

[GitHub] flink pull request #6186: [FLINK-9514,FLINK-9515,FLINK-9516] State ttl wrapp...

2018-06-22 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6186#discussion_r197503773 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlAggregatingState.java --- @@ -0,0 +1,80 @@ +/* + * Licensed

[GitHub] flink pull request #6186: [FLINK-9514,FLINK-9515,FLINK-9516] State ttl wrapp...

2018-06-22 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6186#discussion_r197502165 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlFoldFunction.java --- @@ -0,0 +1,43 @@ +/* + * Licensed

[GitHub] flink pull request #6186: [FLINK-9514,FLINK-9515,FLINK-9516] State ttl wrapp...

2018-06-22 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6186#discussion_r197501902 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlFoldFunction.java --- @@ -0,0 +1,43 @@ +/* + * Licensed

[GitHub] flink pull request #6186: [FLINK-9514,FLINK-9515,FLINK-9516] State ttl wrapp...

2018-06-22 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6186#discussion_r197498126 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlMapState.java --- @@ -0,0 +1,132 @@ +/* + * Licensed

[GitHub] flink pull request #6186: [FLINK-9514,FLINK-9515,FLINK-9516] State ttl wrapp...

2018-06-22 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6186#discussion_r197494851 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlMapState.java --- @@ -0,0 +1,132 @@ +/* + * Licensed

[GitHub] flink pull request #6186: [FLINK-9514,FLINK-9515,FLINK-9516] State ttl wrapp...

2018-06-22 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6186#discussion_r197482482 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/AbstractTtlDecorator.java --- @@ -0,0 +1,99 @@ +/* + * Licensed

[GitHub] flink pull request #6186: [FLINK-9514,FLINK-9515,FLINK-9516] State ttl wrapp...

2018-06-22 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6186#discussion_r197480035 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/AbstractTtlDecorator.java --- @@ -0,0 +1,99 @@ +/* + * Licensed

[GitHub] flink pull request #6186: [FLINK-9514,FLINK-9515,FLINK-9516] State ttl wrapp...

2018-06-22 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6186#discussion_r197477831 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlStateVisibility.java --- @@ -0,0 +1,29 @@ +/* + * Licensed

[GitHub] flink pull request #6186: [FLINK-9514,FLINK-9515,FLINK-9516] State ttl wrapp...

2018-06-22 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6186#discussion_r197476858 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlStateVisibility.java --- @@ -0,0 +1,29 @@ +/* + * Licensed

[GitHub] flink pull request #6186: [FLINK-9514,FLINK-9515,FLINK-9516] State ttl wrapp...

2018-06-22 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6186#discussion_r197476710 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlStateVisibility.java --- @@ -0,0 +1,29 @@ +/* + * Licensed

[GitHub] flink pull request #6186: [FLINK-9514,FLINK-9515,FLINK-9516] State ttl wrapp...

2018-06-22 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6186#discussion_r197475873 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlUpdateType.java --- @@ -0,0 +1,31 @@ +/* + * Licensed

[GitHub] flink pull request #6186: [FLINK-9514,FLINK-9515,FLINK-9516] State ttl wrapp...

2018-06-22 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6186#discussion_r197475080 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlUpdateType.java --- @@ -0,0 +1,31 @@ +/* + * Licensed

[GitHub] flink pull request #6186: [FLINK-9514,FLINK-9515,FLINK-9516] State ttl wrapp...

2018-06-22 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6186#discussion_r197475154 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlStateVisibility.java --- @@ -0,0 +1,29 @@ +/* + * Licensed

[GitHub] flink pull request #6186: [FLINK-9514,FLINK-9515,FLINK-9516] State ttl wrapp...

2018-06-22 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6186#discussion_r197475245 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlTimeCharacteristic.java --- @@ -0,0 +1,27 @@ +/* + * Licensed

[GitHub] flink pull request #6186: [FLINK-9514,FLINK-9515,FLINK-9516] State ttl wrapp...

2018-06-22 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6186#discussion_r197474567 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlConfig.java --- @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #6186: [FLINK-9514,FLINK-9515,FLINK-9516] State ttl wrapp...

2018-06-22 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6186#discussion_r197460522 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/AbstractTtlDecorator.java --- @@ -0,0 +1,99 @@ +/* + * Licensed

[GitHub] flink pull request #6186: [FLINK-9514,FLINK-9515,FLINK-9516] State ttl wrapp...

2018-06-22 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6186#discussion_r197459764 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/AbstractTtlDecorator.java --- @@ -0,0 +1,99 @@ +/* + * Licensed

[GitHub] flink pull request #6186: [FLINK-9514,FLINK-9515,FLINK-9516] State ttl wrapp...

2018-06-22 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6186#discussion_r197458219 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/AbstractTtlDecorator.java --- @@ -0,0 +1,99 @@ +/* + * Licensed

[GitHub] flink pull request #6186: [FLINK-9514,FLINK-9515,FLINK-9516] State ttl wrapp...

2018-06-22 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6186#discussion_r197457017 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/AbstractTtlDecorator.java --- @@ -0,0 +1,99 @@ +/* + * Licensed

[GitHub] flink issue #6173: [FLINK-9571] Refactor StateBinder to internal backend spe...

2018-06-18 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/6173 LGTM 👍 Will merge. ---

[GitHub] flink issue #6173: [FLINK-9571] Refactor StateBinder to internal backend spe...

2018-06-18 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/6173 I had a few comments inline. After they are addressed, I think this is good to merge. ---

[GitHub] flink pull request #6173: [FLINK-9571] Refactor StateBinder to internal back...

2018-06-18 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6173#discussion_r196046444 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/AbstractKeyedStateBackend.java --- @@ -392,14 +268,14 @@ public KeyGroupRange

[GitHub] flink pull request #6173: [FLINK-9571] Refactor StateBinder to internal back...

2018-06-18 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6173#discussion_r196043061 --- Diff: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/client/QueryableStateClient.java

[GitHub] flink pull request #6173: [FLINK-9571] Refactor StateBinder to internal back...

2018-06-18 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6173#discussion_r196042694 --- Diff: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/client/QueryableStateClient.java

[GitHub] flink issue #6174: [FLINK-9601][state]Try to reuse the snapshotData array as...

2018-06-18 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/6174 LGTM now 👍 Will merge. ---

[GitHub] flink issue #6174: [FLINK-9601][state]Try to reuse the snapshotData array as...

2018-06-16 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/6174 Thanks for the contribution. I think the general idea is good, but I think the implementation can be improved. How about changing `CopyOnWriteStateTable::snapshotTableArrays()` in such ways

[GitHub] flink issue #6159: [FLINK-9487] Prepare InternalTimerHeap for asynchronous s...

2018-06-15 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/6159 @azagrebin @sihuazhou I have addressed the comments and also slightly refactored the PR. Please take another look if you want. ---

[GitHub] flink pull request #6159: [FLINK-9487] Prepare InternalTimerHeap for asynchr...

2018-06-14 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6159#discussion_r195376108 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerHeap.java --- @@ -224,6 +227,15 @@ void

[GitHub] flink issue #6159: [FLINK-9487] Prepare InternalTimerHeap for asynchronous s...

2018-06-14 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/6159 Thanks for the review @sihuazhou! ---

[GitHub] flink pull request #6159: [FLINK-9487] Prepare InternalTimerHeap for asynchr...

2018-06-14 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6159#discussion_r195376144 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/AbstractKeyGroupPartitioner.java --- @@ -0,0 +1,227 @@ +/* + * Licensed

[GitHub] flink pull request #6159: [FLINK-9487] Prepare InternalTimerHeap for asynchr...

2018-06-14 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6159#discussion_r195375851 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/AbstractKeyGroupPartitioner.java --- @@ -0,0 +1,227 @@ +/* + * Licensed

[GitHub] flink pull request #5777: [FLINK-7897] Consider using nio.Files for file del...

2018-06-14 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5777#discussion_r195370225 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/TransientBlobCleanupTask.java --- @@ -100,9 +102,15 @@ public void run

[GitHub] flink pull request #5777: [FLINK-7897] Consider using nio.Files for file del...

2018-06-14 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5777#discussion_r195369853 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/TransientBlobCleanupTask.java --- @@ -100,9 +102,15 @@ public void run

[GitHub] flink pull request #5777: [FLINK-7897] Consider using nio.Files for file del...

2018-06-14 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5777#discussion_r195369715 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/TransientBlobCleanupTask.java --- @@ -100,9 +102,15 @@ public void run

[GitHub] flink issue #5843: [FLINK-8744][docs] Generate "Common Option" section

2018-06-14 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5843 LGTM 👍 ---

[GitHub] flink issue #6155: [FLINK-9494] Fix race condition in Dispatcher with granti...

2018-06-14 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/6155 LGTM 👍 ---

[GitHub] flink pull request #6155: [FLINK-9494] Fix race condition in Dispatcher with...

2018-06-14 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6155#discussion_r195337102 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherHATest.java --- @@ -0,0 +1,253 @@ +/* + * Licensed

[GitHub] flink issue #6156: [FLINK-9572] Extend InternalAppendingState with internal ...

2018-06-13 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/6156 I think when all comments are addressed this is good to merge 👍 . Will merge it tomorrow once we have a green build. ---

[GitHub] flink pull request #6156: [FLINK-9572] Extend InternalAppendingState with in...

2018-06-13 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6156#discussion_r195136079 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/internal/InternalAppendingState.java --- @@ -31,4 +31,22 @@ * @param

[GitHub] flink pull request #6156: [FLINK-9572] Extend InternalAppendingState with in...

2018-06-13 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6156#discussion_r195120961 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/internal/InternalAppendingState.java --- @@ -22,7 +22,7

[GitHub] flink pull request #6156: [FLINK-9572] Extend InternalAppendingState with in...

2018-06-13 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6156#discussion_r195118823 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapValueState.java --- @@ -30,7 +30,7 @@ * @param The type

[GitHub] flink pull request #6156: [FLINK-9572] Extend InternalAppendingState with in...

2018-06-13 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6156#discussion_r195118305 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapValueState.java --- @@ -30,7 +30,7 @@ * @param The type

[GitHub] flink pull request #6156: [FLINK-9572] Extend InternalAppendingState with in...

2018-06-13 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6156#discussion_r195116930 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/AbstractStateTableSnapshot.java --- @@ -48,4 +48,4 @@ @Override

[GitHub] flink pull request #6156: [FLINK-9572] Extend InternalAppendingState with in...

2018-06-13 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6156#discussion_r195116411 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/AbstractHeapMergingState.java --- @@ -34,12 +33,10 @@ * @param

[GitHub] flink pull request #6156: [FLINK-9572] Extend InternalAppendingState with in...

2018-06-13 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6156#discussion_r195114015 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBListState.java --- @@ -94,6

[GitHub] flink pull request #6156: [FLINK-9572] Extend InternalAppendingState with in...

2018-06-13 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6156#discussion_r195111820 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBListState.java --- @@ -237,4

[GitHub] flink pull request #6156: [FLINK-9572] Extend InternalAppendingState with in...

2018-06-13 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6156#discussion_r195089054 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/internal/InternalAppendingState.java --- @@ -31,4 +31,22 @@ * @param

[GitHub] flink issue #6159: [FLINK-9487] Prepare InternalTimerHeap for asynchronous s...

2018-06-13 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/6159 CC @azagrebin ---

[GitHub] flink pull request #6159: [FLINK-9487] Prepare InternalTimerHeap for asynchr...

2018-06-13 Thread StefanRRichter
GitHub user StefanRRichter opened a pull request: https://github.com/apache/flink/pull/6159 [FLINK-9487] Prepare InternalTimerHeap for asynchronous snapshots ## What is the purpose of the change This PR is the first step in the context of FLINK-9485. Purpose of this PR

[GitHub] flink issue #6119: [FLINK-9458] Ignore SharedSlot in CoLocationConstraint wh...

2018-06-11 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/6119 LGTM 👍 ---

[GitHub] flink issue #6096: [FLINK-9440][streaming] Expose cancelation of timers thro...

2018-06-05 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/6096 @tillrohrmann thanks for the fast review! Will merge. ---

[GitHub] flink issue #5582: [FLINK-8790][State] Improve performance for recovery from...

2018-06-05 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5582 LGTM 👍 Very nice work. I will merge it with some very minor touchups. ---

[GitHub] flink issue #4949: [FLINK-7866] [runtime] Weigh list of preferred locations ...

2018-06-04 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4949 LTGM 👍 Will merge this. ---

[GitHub] flink pull request #4949: [FLINK-7866] [runtime] Weigh list of preferred loc...

2018-06-01 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4949#discussion_r192378853 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/SlotProfile.java --- @@ -203,68 +206,104 @@ public

[GitHub] flink pull request #4949: [FLINK-7866] [runtime] Weigh list of preferred loc...

2018-06-01 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4949#discussion_r192378473 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/SlotProfile.java --- @@ -203,68 +206,104 @@ public

[GitHub] flink pull request #4949: [FLINK-7866] [runtime] Weigh list of preferred loc...

2018-06-01 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4949#discussion_r192376303 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/SlotProfile.java --- @@ -203,68 +206,104 @@ public

[GitHub] flink pull request #5982: [FLINK-9325][checkpoint]generate the meta file for...

2018-06-01 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5982#discussion_r192371034 --- Diff: flink-core/src/main/java/org/apache/flink/core/fs/TwoPhaseFSDataOutputStream.java --- @@ -0,0 +1,163 @@ +/* + * Licensed

[GitHub] flink pull request #5982: [FLINK-9325][checkpoint]generate the meta file for...

2018-06-01 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5982#discussion_r192370481 --- Diff: flink-core/src/main/java/org/apache/flink/core/fs/ClosingAtomicCreatingFSDataOutputStream.java --- @@ -0,0 +1,129

[GitHub] flink pull request #5582: [FLINK-8790][State] Improve performance for recove...

2018-06-01 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5582#discussion_r192350881 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendTest.java

[GitHub] flink pull request #5582: [FLINK-8790][State] Improve performance for recove...

2018-06-01 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5582#discussion_r192350121 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendTest.java

[GitHub] flink pull request #5582: [FLINK-8790][State] Improve performance for recove...

2018-06-01 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5582#discussion_r192347037 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendTest.java

[GitHub] flink pull request #5582: [FLINK-8790][State] Improve performance for recove...

2018-06-01 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5582#discussion_r192337341 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendTest.java

[GitHub] flink pull request #5582: [FLINK-8790][State] Improve performance for recove...

2018-06-01 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5582#discussion_r19278 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java

[GitHub] flink pull request #5582: [FLINK-8790][State] Improve performance for recove...

2018-06-01 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5582#discussion_r192332742 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendTest.java

[GitHub] flink pull request #5582: [FLINK-8790][State] Improve performance for recove...

2018-06-01 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5582#discussion_r192332179 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java

[GitHub] flink pull request #5582: [FLINK-8790][State] Improve performance for recove...

2018-06-01 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5582#discussion_r192331370 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java

[GitHub] flink pull request #5582: [FLINK-8790][State] Improve performance for recove...

2018-06-01 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5582#discussion_r192330418 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java

[GitHub] flink pull request #5582: [FLINK-8790][State] Improve performance for recove...

2018-06-01 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5582#discussion_r192329562 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java

[GitHub] flink pull request #5582: [FLINK-8790][State] Improve performance for recove...

2018-05-31 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5582#discussion_r192081960 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBIncrementalCheckpointUtils.java

[GitHub] flink pull request #5582: [FLINK-8790][State] Improve performance for recove...

2018-05-31 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5582#discussion_r192079420 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBIncrementalCheckpointUtils.java

[GitHub] flink pull request #5582: [FLINK-8790][State] Improve performance for recove...

2018-05-31 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5582#discussion_r192078327 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state

[GitHub] flink pull request #5582: [FLINK-8790][State] Improve performance for recove...

2018-05-31 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5582#discussion_r192077816 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBIncrementalCheckpointUtils.java

<    1   2   3   4   5   6   7   8   9   10   >