Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1188#issuecomment-143909415
+1
Looks good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1141#issuecomment-143192190
Looks good to merge and +1 for FLINK-2692
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1177#issuecomment-143155274
Looks good to merge except one minor issue. Very nice start! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1177#discussion_r40407595
--- Diff: flink-benchmark/pom.xml ---
@@ -0,0 +1,101 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLS
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1180#issuecomment-143197780
Could you add creating new environment in Scala shell?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1176#issuecomment-142863133
Hi @rerngvit, Thanks for sending pull request. But your pull request has
some problems.
First, `{{ quickstart }}` is not defined in your changes. As you can
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1176#issuecomment-142910324
Looks good to merge. I'll merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1176#issuecomment-142895387
Hi @rerngvit, I have tested your pull request.
Because `setup_quickstart.html` contains "setup" keyword in url, there are
two active menus (Quickst
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1097#discussion_r40297666
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/RequiredParameterTest.java
---
@@ -0,0 +1,137 @@
+/*
+ * Licensed
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-142344379
The version of `maven-shade-plugin` is reverted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1168#issuecomment-142482756
Looks good to merge. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/885#discussion_r40078159
--- Diff: flink-dist/pom.xml ---
@@ -305,6 +305,7 @@ under the License
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1146#issuecomment-141903815
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-141810617
I updated this PR. The changes are following:
* Add a bash script named `change-scala-version.sh` to change artifact id
* Add a missing flag `-Dscala-2.11
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1098#issuecomment-141629844
There is a checkstyle error:
```
[INFO] There is 1 error reported by Checkstyle 6.2 with
/tools/maven/checkstyle.xml ruleset.
[ERROR]
src/main/java
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-141416793
I hope to create a shell script and make setting for deploying `_2.11_
artifact. Could you wait a while to update this? Maybe I can update this PR
until this weekend
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1140#issuecomment-140979385
Nice catch! Looks good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1131#issuecomment-140658458
Looks good to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1134#discussion_r39650722
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/IntegerTypeInfo.java
---
@@ -18,15 +18,33 @@
package
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1127#issuecomment-140327645
Hi @twalthr, thanks for your contribution. But this PR contains many
changes unrelated to HCatalog format. Maybe we should split this PR into
HCatalog and other
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1098#issuecomment-139507621
Basically, we should prevent modifying the current Table API tests. This PR
covers about streaming API only.
---
If your project is set up for it, you can reply
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1098#issuecomment-139507227
I still cannot understand what is the purpose of adding `javaSet` to the
Table API. We can get the `DataSet` by using `toDataSet` method.
---
If your project is set
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1098#issuecomment-139513146
As you know, It seems because of ambiguousness between `Table` from
`DataSet` and that from `DataStream`. We need refactor for Table API.
---
If your project is set
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1112#issuecomment-139127959
Looks good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1079#issuecomment-139129112
@jamescao Yes, I think the part (including tests) related with
`HCatInputFormat` should be removed.
---
If your project is set up for it, you can reply
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39030573
--- Diff:
flink-staging/flink-hcatalog/src/test/java/org/apache/flink/hcatalog/java/test/HcatInputOutputFormatITest.java
---
@@ -0,0 +1,383
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39030601
--- Diff:
flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala
---
@@ -0,0 +1,216
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39033258
--- Diff:
flink-staging/flink-hcatalog/src/main/scala/org/apache/flink/hcatalog/scala/HCatOutputFormat.scala
---
@@ -0,0 +1,449
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39033252
--- Diff:
flink-staging/flink-hcatalog/src/main/scala/org/apache/flink/hcatalog/scala/HCatOutputFormat.scala
---
@@ -0,0 +1,449
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39034189
--- Diff:
flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala
---
@@ -0,0 +1,216
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39034170
--- Diff:
flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala
---
@@ -0,0 +1,216
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39031803
--- Diff:
flink-staging/flink-hcatalog/src/main/scala/org/apache/flink/hcatalog/scala/HCatOutputFormat.scala
---
@@ -0,0 +1,449
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39032671
--- Diff:
flink-staging/flink-hcatalog/src/test/java/org/apache/flink/hcatalog/java/test/HcatInputOutputFormatITest.java
---
@@ -0,0 +1,383
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39030988
--- Diff:
flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/java/HCatOutputFormat.java
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39030971
--- Diff:
flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/java/HCatOutputFormat.java
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39030949
--- Diff:
flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/HCatOutputFormatBase.java
---
@@ -0,0 +1,301 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39030957
--- Diff:
flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/HCatOutputFormatBase.java
---
@@ -0,0 +1,301 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39030888
--- Diff:
flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/HCatOutputFormatBase.java
---
@@ -0,0 +1,301 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39030975
--- Diff:
flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/java/HCatOutputFormat.java
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39030982
--- Diff:
flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/java/HCatOutputFormat.java
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39032520
--- Diff:
flink-staging/flink-hcatalog/src/main/scala/org/apache/flink/hcatalog/scala/HCatOutputFormat.scala
---
@@ -0,0 +1,449
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39032562
--- Diff:
flink-staging/flink-hcatalog/src/test/java/org/apache/flink/hcatalog/java/test/HcatInputOutputFormatITest.java
---
@@ -0,0 +1,383
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39032533
--- Diff:
flink-staging/flink-hcatalog/src/test/java/org/apache/flink/hcatalog/java/test/HcatInputOutputFormatITest.java
---
@@ -0,0 +1,383
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39032608
--- Diff:
flink-staging/flink-hcatalog/src/test/java/org/apache/flink/hcatalog/java/test/HcatInputOutputFormatITest.java
---
@@ -0,0 +1,383
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39033094
--- Diff:
flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala
---
@@ -0,0 +1,216
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39033950
--- Diff:
flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/HCatOutputFormatBase.java
---
@@ -0,0 +1,301 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39033997
--- Diff:
flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/java/HCatOutputFormat.java
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39030898
--- Diff:
flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/HCatOutputFormatBase.java
---
@@ -0,0 +1,301 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39032912
--- Diff:
flink-staging/flink-hcatalog/src/test/java/org/apache/flink/hcatalog/java/test/HcatInputOutputFormatITest.java
---
@@ -0,0 +1,383
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39033766
--- Diff:
flink-staging/flink-hcatalog/src/main/scala/org/apache/flink/hcatalog/scala/HCatOutputFormat.scala
---
@@ -0,0 +1,449
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1079#issuecomment-138890354
Hi @jamescao, I just reviewed your PR. There are some issues to merge.
* `HcatInputOutputFormatITest.java` must use tab characters for indentation
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39033023
--- Diff:
flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala
---
@@ -0,0 +1,216
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39033011
--- Diff:
flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala
---
@@ -0,0 +1,216
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39034039
--- Diff:
flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/java/HCatOutputFormat.java
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39034096
--- Diff:
flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/java/HCatOutputFormat.java
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39034081
--- Diff:
flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/java/HCatOutputFormat.java
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39034063
--- Diff:
flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/java/HCatOutputFormat.java
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1079#issuecomment-138869203
Oh, sorry for late. I'm reviewing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39030716
--- Diff:
flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala
---
@@ -0,0 +1,216
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39030649
--- Diff:
flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala
---
@@ -0,0 +1,216
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39031065
--- Diff:
flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/java/HCatOutputFormat.java
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39032770
--- Diff:
flink-staging/flink-hcatalog/src/test/java/org/apache/flink/hcatalog/java/test/HcatInputOutputFormatITest.java
---
@@ -0,0 +1,383
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39032747
--- Diff:
flink-staging/flink-hcatalog/src/test/java/org/apache/flink/hcatalog/java/test/HcatInputOutputFormatITest.java
---
@@ -0,0 +1,383
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39032738
--- Diff:
flink-staging/flink-hcatalog/src/test/java/org/apache/flink/hcatalog/java/test/HcatInputOutputFormatITest.java
---
@@ -0,0 +1,383
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39032801
--- Diff:
flink-staging/flink-hcatalog/src/test/java/org/apache/flink/hcatalog/java/test/HcatInputOutputFormatITest.java
---
@@ -0,0 +1,383
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-138894613
I think that using property in artifact id causes many problems. Maybe
Spark faces the same problems, and uses shell script.
How about using the shell script
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1103#issuecomment-138868908
Thanks for clarifying. I added a commit for the manual test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39031945
--- Diff:
flink-staging/flink-hcatalog/src/main/scala/org/apache/flink/hcatalog/scala/HCatOutputFormat.scala
---
@@ -0,0 +1,449
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39031960
--- Diff:
flink-staging/flink-hcatalog/src/main/scala/org/apache/flink/hcatalog/scala/HCatOutputFormat.scala
---
@@ -0,0 +1,449
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39031981
--- Diff:
flink-staging/flink-hcatalog/src/main/scala/org/apache/flink/hcatalog/scala/HCatOutputFormat.scala
---
@@ -0,0 +1,449
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39032786
--- Diff:
flink-staging/flink-hcatalog/src/test/java/org/apache/flink/hcatalog/java/test/HcatInputOutputFormatITest.java
---
@@ -0,0 +1,383
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39032807
--- Diff:
flink-staging/flink-hcatalog/src/test/java/org/apache/flink/hcatalog/java/test/HcatInputOutputFormatITest.java
---
@@ -0,0 +1,383
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39032886
--- Diff:
flink-staging/flink-hcatalog/src/test/java/org/apache/flink/hcatalog/java/test/HcatInputOutputFormatITest.java
---
@@ -0,0 +1,383
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39033820
--- Diff:
flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/HCatOutputFormatBase.java
---
@@ -0,0 +1,301 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39033845
--- Diff:
flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/HCatOutputFormatBase.java
---
@@ -0,0 +1,301 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39030785
--- Diff:
flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/HCatOutputFormatBase.java
---
@@ -0,0 +1,301 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39030797
--- Diff:
flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/HCatOutputFormatBase.java
---
@@ -0,0 +1,301 @@
+/*
+ * Licensed
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/696#issuecomment-138912233
Update the implementation to use priority queue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1078#issuecomment-138954598
Looks good to me except some minor issues (including things @rmetzger
said). But there is no JIRA issue covered this PR. We should create JIRA issue
first
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1078#discussion_r39059950
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/math/DenseVector.scala
---
@@ -102,6 +102,38 @@ case class DenseVector
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/941#issuecomment-138956199
Do this PR need modification? It seems good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1104#issuecomment-138449459
+1 for merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1104#issuecomment-138483880
+1 for making `hashCode()`, `equals()`, and `toString()` abstract.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1103#issuecomment-138497195
@StephanEwen Do you mean `ExecutionGraphRestartTest`? When I increased
slots in test instance, I got another exception. Exception log is following
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1059#issuecomment-138483365
Is this merged? I cannot find this commit in ASF Git repository.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user chiwanpark opened a pull request:
https://github.com/apache/flink/pull/1103
[FLINK-2619] [tests] Fix for some unexecuted Scala tests
This PR includes to resolve FLINK-2619. The changes are following:
* Add JUnitRunner(`@RunWith(classOf[JUnitRunner
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1089#issuecomment-137923702
+1
Merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/943#issuecomment-137922910
After merging this, we should update `CsvInputFormat`. Currently, we create
`Field` objects in `open` method of `CsvInputFormat`. With this PR, we don't
need
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1052#issuecomment-137691399
Looks good to merge. :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r38735587
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/accumulators/ContinuousHistogram.java
---
@@ -0,0 +1,534 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r38735464
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/accumulators/ContinuousHistogram.java
---
@@ -0,0 +1,534 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r38735611
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/accumulators/ContinuousHistogram.java
---
@@ -0,0 +1,534 @@
+/*
+ * Licensed
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/861#issuecomment-137690196
Looks good to merge except some minor issues. If there is no objection for
this PR, I'll merge this in tomorrow.
---
If your project is set up for it, you can reply
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/861#issuecomment-137912454
I object to break API in this PR. I think that this PR should cover
histogram for `DataSet` only. That's why we split this PR from #1032.
About documentation, adding
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r38616759
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/accumulators/ContinuousHistogram.java
---
@@ -0,0 +1,490 @@
+/*
+ * Licensed
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r38619843
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/DataSetUtils.java ---
@@ -248,6 +251,58 @@ public void mapPartition(Iterable values
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r38619828
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/DataSetUtils.java ---
@@ -248,6 +251,58 @@ public void mapPartition(Iterable values
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/861#issuecomment-137381508
I'm inclined to preventing base class for the histogram. Decision Tree will
be implemented in Scala and we can use pattern matching (case-match statement)
for solving
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/861#issuecomment-137376194
Hi, I just reviewed the updated PR. Sorry for late.
Your implementation is nice. It seems acting like I expected. But I have to
check the following
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1074#issuecomment-137396215
Looks good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
301 - 400 of 583 matches
Mail list logo
