Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77987079
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -70,10 +77,41 @@
private static final Pattern
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77986671
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -70,10 +77,41 @@
private static final Pattern
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77986502
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -70,10 +77,41 @@
private static final Pattern
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77984130
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java ---
@@ -455,6 +459,33 @@ public boolean isForceAvroEnabled
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77983346
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java ---
@@ -455,6 +459,33 @@ public boolean isForceAvroEnabled
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/2094
https://issues.apache.org/jira/browse/FLINK-4575
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/2094
@rmetzger Thanks for looking at it.
> Is there a reason why the DataSet methods for "sum()" for example do not
allow to aggregate on POJOs with this change?
The reason i
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76576801
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/FieldAccessorTest.java
---
@@ -0,0 +1,336 @@
+/*
+ * Licensed to the Apache
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76576754
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/FieldAccessorTest.java
---
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/2094
@twalthr I think I have addressed all your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040664
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java
---
@@ -301,12 +301,12 @@ public KeyedStream
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040669
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/DataStreamPojoITCase.java
---
@@ -139,17 +139,6 @@ public void flatMap(Data value
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040657
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/typeutils/CaseClassTypeInfo.scala
---
@@ -236,6 +237,31 @@ abstract class CaseClassTypeInfo[T
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040641
--- Diff:
flink-scala/src/main/java/org/apache/flink/api/scala/typeutils/ProductFieldAccessor.java
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040621
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/FieldAccessorTest.java
---
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040630
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the Apache
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040529
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the Apache
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040566
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -317,7 +308,39 @@ public int getFieldIndex(String fieldName
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040578
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/TupleTypeInfoBase.java
---
@@ -203,7 +205,26 @@ public void getFlatFields(String
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040541
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the Apache
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040571
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/TupleTypeInfoBase.java
---
@@ -203,7 +205,26 @@ public void getFlatFields(String
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040561
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -317,7 +308,39 @@ public int getFieldIndex(String fieldName
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040520
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/TypeInformation.java
---
@@ -160,6 +161,53 @@ public boolean isSortKeyType
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040551
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the Apache
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040502
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/TypeInformation.java
---
@@ -160,6 +161,53 @@ public boolean isSortKeyType
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040516
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/TypeInformation.java
---
@@ -160,6 +161,53 @@ public boolean isSortKeyType
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040532
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the Apache
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040498
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/BasicTypeInfo.java
---
@@ -171,6 +172,23 @@ public boolean isKeyType
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040491
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/BasicArrayTypeInfo.java
---
@@ -121,6 +122,18 @@ public boolean isKeyType
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76024415
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the Apache
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75908195
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/FieldAccessorTest.java
---
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75907421
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/FieldAccessorTest.java
---
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/2094
@twalthr, thank you for the comments, I'll try to address them soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/2094
> I am a bit out of the loop here. Why do we need a field accessor in the
TypeInformation?
We need this for situations when the user specifies a nested field
expression, which goes thro
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/2094
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/1517
> Reading back through the discussion I see that there are many ideas for
future performance enhancements. If not already suggested I'd like to consider
skipping staging for fixed length
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r70182809
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/manual/ReducePerformance.java
---
@@ -0,0 +1,237 @@
+/*
+ * Licensed to the Apache Software
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r70182796
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/SameTypePairComparator.java
---
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r70182801
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -1480,28 +1480,17 @@ public static int
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r70182792
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/dag/ReduceNode.java ---
@@ -45,10 +46,28 @@ public ReduceNode(ReduceOperatorBase operator
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r70182744
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/GroupedDataSet.scala ---
@@ -282,27 +283,57 @@ class GroupedDataSet[T: ClassTag
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r67615885
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/GroupedDataSet.scala ---
@@ -282,27 +283,57 @@ class GroupedDataSet[T: ClassTag
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/1517
I have rebased to the current master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user ggevay opened a pull request:
https://github.com/apache/flink/pull/2094
[FLINK-3702] Make FieldAccessors support nested field expressions.
I finally had some time to complete this, sorry it took so long.
I have added `getFieldAccessor` to `TypeInformation
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r65667687
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/ReduceCombineDriver.java
---
@@ -42,34 +44,38 @@
* Combine operator for Reduce
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/1517
Hi @fhueske,
Thanks for the comments, I think I have addressed all of them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r65383363
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/RandomAccessInputView.java
---
@@ -45,7 +45,12 @@ public RandomAccessInputView
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r65376284
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java
---
@@ -0,0 +1,1048 @@
+/*
+ * Licensed to the
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r65371629
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/CompactingHashTableTest.java
---
@@ -252,4 +262,81 @@ private static String
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r65371616
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/MemoryHashTableTestCommon.java
---
@@ -0,0 +1,666 @@
+/*
+ * Licensed
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r65371572
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/chaining/ChainedReduceCombineDriver.java
---
@@ -0,0 +1,305
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r65356958
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java
---
@@ -0,0 +1,1048 @@
+/*
+ * Licensed to the
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r65356908
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java
---
@@ -0,0 +1,1048 @@
+/*
+ * Licensed to the
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r65356863
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java
---
@@ -0,0 +1,1048 @@
+/*
+ * Licensed to the
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r65331149
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java
---
@@ -0,0 +1,1048 @@
+/*
+ * Licensed to the
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r65233230
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java
---
@@ -0,0 +1,1048 @@
+/*
+ * Licensed to the
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r65231707
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java
---
@@ -0,0 +1,1048 @@
+/*
+ * Licensed to the
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r65231642
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java
---
@@ -0,0 +1,1048 @@
+/*
+ * Licensed to the
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r65231516
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/ReduceCombineDriver.java
---
@@ -114,85 +118,133 @@ public void prepare() throws
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r65231501
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/chaining/ChainedReduceCombineDriver.java
---
@@ -0,0 +1,305
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r65231386
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/ReduceCombineDriver.java
---
@@ -42,34 +44,38 @@
* Combine operator for Reduce
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r65229499
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/ReduceCombineDriver.java
---
@@ -42,34 +44,38 @@
* Combine operator for Reduce
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r65228287
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/GroupedDataSet.scala ---
@@ -282,27 +283,57 @@ class GroupedDataSet[T: ClassTag
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r65228213
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/UnsortedGrouping.java
---
@@ -135,10 +136,37 @@ public UnsortedGrouping(DataSet set
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r65219886
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/GroupedDataSet.scala ---
@@ -282,27 +283,57 @@ class GroupedDataSet[T: ClassTag
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r65216454
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/ReduceCombineDriver.java
---
@@ -42,34 +44,38 @@
* Combine operator for Reduce
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r65090655
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/ReduceHashTable.java
---
@@ -0,0 +1,1048 @@
+/*
+ * Licensed to the
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1517#issuecomment-222520511
> This PR does also fix issue FLINK-2246 (add ChainedReduceCombineDriver).
Would be nice to have that change in a separate commit before we merge.
It is
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r65027607
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/chaining/ChainedReduceCombineDriver.java
---
@@ -0,0 +1,305
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r65027557
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/ReduceCombineDriver.java
---
@@ -42,34 +44,38 @@
* Combine operator for Reduce
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r65026385
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/ReduceCombineDriver.java
---
@@ -42,34 +44,38 @@
* Combine operator for Reduce
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r65024796
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/GroupedDataSet.scala ---
@@ -282,27 +283,57 @@ class GroupedDataSet[T: ClassTag
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1517#issuecomment-221670393
And @th0br0 is working on CombineHint.NONE.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1517#issuecomment-221644628
We talked about this yesterday with @fhueske at the Flink meetup, and the
conclusion was that we will get it into 1.1. @fhueske has several comments that
he will write
Github user ggevay closed the pull request at:
https://github.com/apache/flink/pull/910
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/910#issuecomment-219407507
I'm closing this. It doesn't really make much sense to do this on an entire
stream; users would probably want to do this on large windows instead, so this
shoul
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r60105060
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/operators/base/ReduceOperatorBase.java
---
@@ -54,6 +54,32 @@
@Internal
public class
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/856#issuecomment-205884988
I think that this unfortunately can't be adapted to the new windowing
system, so it can be closed.
---
If your project is set up for it, you can reply to this emai
Github user ggevay closed the pull request at:
https://github.com/apache/flink/pull/856
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1724#issuecomment-204682353
OK, no problem, I've updated the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1517#issuecomment-198407391
Hi @fhueske,
I'm planning to do the benchmarks next week Monday-Wednesday.
---
If your project is set up for it, you can reply to this email and have your
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1724#issuecomment-195743886
> What kind of exception do you get?
This is the code near TypeExtractor.java:1379, from where the exception is
thrown:
```
// check
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/684#issuecomment-195402038
This is dead. Everything has totally changed that this was based on. The
fundamental problem is that this is based on the assumption of the old 0.9
windowing code that
Github user ggevay closed the pull request at:
https://github.com/apache/flink/pull/684
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1769#issuecomment-193635557
The Memory tab in Java Mission Control can probably help with investigating
this.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1769#issuecomment-192962635
> I would be curious about the soft reference implementation as in
DetaIteration cases I think it is a valid situation that the job needs less and
less mem
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1517#issuecomment-190171821
I'll do the Peel thing after March 15, because I have to work on my PhD
thesis proposal until then.
---
If your project is set up for it, you can reply to this
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1721#issuecomment-190159900
By the way, I think that the change of the input rules about the
non-iterator UDFs will actually allow us to simplify some code: all those
drivers that work with such
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1724#issuecomment-190143075
> I am not quite sure even, if Tuple subclasses have to be POJOs.
I wrote that based on the comment at TypeExtractor.java:1687. (I also tried
adding a ch
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1721#issuecomment-189372008
Oops, you are right!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1724#issuecomment-189326695
I have also added that a subclass of TupleN can only be a POJO. (see
TypeExtractor.java:1686)
---
If your project is set up for it, you can reply to this email and have
GitHub user ggevay opened a pull request:
https://github.com/apache/flink/pull/1724
[FLINK-3519] [core] Add warning about subclasses to Tuple javadocs.
I went with option (2), that is, adding a warning to the javadocs.
The generated classes were out of sync with the
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1721#issuecomment-189313026
Why was the "Emitting input objects" field changed? For example, is there a
problem with emitting input objects from a JoinFunction? (Like here:
http://apache-
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1517#issuecomment-187697588
Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1517#issuecomment-186244959
@fhueske:
So far, I have only run benchmarks on my work laptop and home laptop.
I have used the newly created `ReducePerformance`, with varying the
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1517#issuecomment-186226971
OK, thanks @aalexandrov ! I wanted to try Peel anyway, this is a good
opportunity.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1517#issuecomment-184696741
Hello Fabian,
I did 3.
(https://github.com/apache/flink/commit/ef644821d5417b992cfda366225bd5622faa9b2b),
because the machinery for that was already in place
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1517#issuecomment-183896027
I've added some more documentation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1626#issuecomment-183390101
OK, after Stephan's comment on FLINK-3291, I agree.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1626#issuecomment-183375884
Sorry, but I don't think it is independent, because the bug in the reduce
drivers could alternatively be fixed by saying that the bug is actually not in
the r
101 - 200 of 300 matches
Mail list logo
