[GitHub] flink issue #2248: [FLINK-4213] [gelly] Provide CombineHint in Gelly algorit...

2016-07-15 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2248 Depends how much faster we can make sorting in the `NormalizedKeySorter` :) I'll keep working on a comparison, I've been running into the deadlock in FLINK-4163. --- If your project

[GitHub] flink pull request #2254: [FLINK-3630] [docs] Little mistake in documentatio...

2016-07-14 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/2254 [FLINK-3630] [docs] Little mistake in documentation You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink

[GitHub] flink pull request #2253: [FLINK-4219] [scripts] Quote PDSH opts in start-cl...

2016-07-14 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/2253 [FLINK-4219] [scripts] Quote PDSH opts in start-cluster.sh This prevents word splitting if the user configures multiple SSH options. You can merge this pull request into a Git repository

[GitHub] flink issue #2239: [FLINK-4208] Support Running Flink processes in foregroun...

2016-07-14 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2239 Using `wait $mypid` or just `wait` works for me if I `./bin/jobmanager.sh start cluster` (jobmanager starts in foreground), then in another terminal `./bin/jobmanager.sh stop` and both terminals

[GitHub] flink pull request #2239: [FLINK-4208] Support Running Flink processes in fo...

2016-07-14 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2239#discussion_r70877433 --- Diff: flink-dist/src/main/flink-bin/bin/flink-daemon.sh --- @@ -77,31 +77,36 @@ if [[ ${JAVA_VERSION} =~ ${IS_NUMBER} ]]; then fi case

[GitHub] flink pull request #2251: [FLINK-4212] [scripts] Lock PID file when starting...

2016-07-14 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/2251 [FLINK-4212] [scripts] Lock PID file when starting daemons You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink

[GitHub] flink pull request #2250: [FLINK-4217] [gelly] Gelly drivers should read CSV...

2016-07-14 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/2250 [FLINK-4217] [gelly] Gelly drivers should read CSV values as strings You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink

[GitHub] flink issue #2239: [FLINK-4208] Support Running Flink processes in foregroun...

2016-07-14 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2239 What if instead of changing how we start the daemon (so continue to always start as a background process), we instead add a `wait` after the PID file has been updated when starting a foreground

[GitHub] flink pull request #2239: [FLINK-4208] Support Running Flink processes in fo...

2016-07-14 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2239#discussion_r70844709 --- Diff: flink-dist/src/main/flink-bin/bin/flink-daemon.sh --- @@ -77,31 +77,36 @@ if [[ ${JAVA_VERSION} =~ ${IS_NUMBER} ]]; then fi case

[GitHub] flink pull request #2248: [FLINK-4213] [gelly] Provide CombineHint in Gelly ...

2016-07-14 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/2248 [FLINK-4213] [gelly] Provide CombineHint in Gelly algorithms `VertexDegrees` has changed from using a `ReduceFunction` to using a `GroupReduceFunction` as in directed `TriangleListing`. You can

[GitHub] flink issue #1517: [FLINK-3477] [runtime] Add hash-based combine strategy fo...

2016-07-13 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/1517 CI tests are passing. I've been testing Gelly algorithms with this without error. I will merge this ... --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink issue #2239: [FLINK-4208] Support Running Flink processes in foregroun...

2016-07-13 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2239 Hi @iemejia, is the situation with Docker that if the Flink processes are started as daemons and the script returns that Docker assumes the process has terminated? Skipping the pid file

[GitHub] flink issue #2217: [FLINK-4159] Remove Quickstart exclusions for unused depe...

2016-07-11 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2217 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #1517: [FLINK-3477] [runtime] Add hash-based combine stra...

2016-07-08 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r70139954 --- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/GroupedDataSet.scala --- @@ -282,27 +283,57 @@ class GroupedDataSet[T: ClassTag

[GitHub] flink pull request #2223: [FLINK-4154] [core] Correction of murmur hash brea...

2016-07-08 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/2223 [FLINK-4154] [core] Correction of murmur hash breaks backwards compatibility Revert "[FLINK-3623] [runtime] Adjust MurmurHash Algorithm" This reve

[GitHub] flink pull request #2217: [FLINK-4159] Remove Quickstart exclusions for unus...

2016-07-08 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2217#discussion_r70085553 --- Diff: flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml --- @@ -207,15 +206,9 @@ under the License

[GitHub] flink pull request #2217: [FLINK-4159] Remove Quickstart exclusions for unus...

2016-07-08 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2217#discussion_r70083585 --- Diff: flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml --- @@ -207,15 +206,9 @@ under the License

[GitHub] flink pull request #2217: [FLINK-4159] Remove Quickstart exclusions for unus...

2016-07-08 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2217#discussion_r70083520 --- Diff: flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml --- @@ -207,15 +206,9 @@ under the License

[GitHub] flink issue #2213: [FLINK-4172] [gelly] Don't proxy a ProxiedObject

2016-07-08 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2213 @vasia or @StephanEwen would you have a minute to look this over? I'll look to merge this for RC1. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request #2211: [WIP][FLINK-3599] Code generation for PojoSerializ...

2016-07-07 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2211#discussion_r69953281 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java --- @@ -419,4 +470,47 @@ public String toString

[GitHub] flink pull request #2211: [WIP][FLINK-3599] Code generation for PojoSerializ...

2016-07-07 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2211#discussion_r69952548 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java --- @@ -70,10 +75,21 @@ private static final Pattern

[GitHub] flink pull request #2211: [WIP][FLINK-3599] Code generation for PojoSerializ...

2016-07-07 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2211#discussion_r69951927 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java --- @@ -70,10 +75,21 @@ private static final Pattern

[GitHub] flink pull request #2211: [WIP][FLINK-3599] Code generation for PojoSerializ...

2016-07-07 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2211#discussion_r69951075 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java --- @@ -315,6 +331,23 @@ public int getFieldIndex(String

[GitHub] flink pull request #2211: [WIP][FLINK-3599] Code generation for PojoSerializ...

2016-07-07 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2211#discussion_r69949156 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java --- @@ -99,6 +99,8 @@ private boolean forceAvro = false

[GitHub] flink pull request #2213: [FLINK-4172] [gelly] Don't proxy a ProxiedObject

2016-07-07 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/2213 [FLINK-4172] [gelly] Don't proxy a ProxiedObject Retrieve the proxied object and wrap in a new proxy. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] flink issue #2179: [FLINK-4128] compile error about git-commit-id-plugin

2016-06-30 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2179 No problem at all, just wanted to make sure we had the proper attribution. Thanks for finding, reporting, and fixing this issue. --- If your project is set up for it, you can reply to this email

[GitHub] flink issue #2179: [FLINK-4128] compile error about git-commit-id-plugin

2016-06-30 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2179 I think you could have done a `git commit --amend` and simply saved the commit message unedited and git would hopefully have updated the author info. I couldn't get the reversions to work

[GitHub] flink issue #2179: [FLINK-4128] compile error about git-commit-id-plugin

2016-06-30 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2179 As I verify the merge can we check the author string ... currently showing "unknown <mao...@maowei-mobl.ccr.corp.intel.com>". --- If your project is set up for it, you can rep

[GitHub] flink issue #2179: [FLINK-4128] compile error about git-commit-id-plugin

2016-06-30 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2179 Will merge this ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #2179: [FLINK-4128] compile error about git-commit-id-plugin

2016-06-30 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2179 Also works when `dotGitDirectory` is removed from the pom.xml. The plugin searches up the directory hierarchy if the given directory is not valid. Looks to be a valid change but I wouldn't expect

[GitHub] flink pull request #2188: [FLINK-4135] [gelly] Replace ChecksumHashCode as G...

2016-06-30 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/2188 [FLINK-4135] [gelly] Replace ChecksumHashCode as GraphAnalytic Adds a GraphAnalytic to replace the checksumHashCode Java and Scala utility functions. You can merge this pull request into a Git

[GitHub] flink pull request #2053: [FLINK-1707] Affinity Propagation

2016-06-30 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2053#discussion_r69121905 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/AffinityPropagation.java --- @@ -0,0 +1,535 @@ +/* + * Licensed

[GitHub] flink pull request #2053: [FLINK-1707] Affinity Propagation

2016-06-30 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2053#discussion_r69121871 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/AffinityPropagation.java --- @@ -0,0 +1,535 @@ +/* + * Licensed

[GitHub] flink issue #2186: [licenses] Remove not included dependency from LICENSE

2016-06-30 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2186 Is the documentation still usable offline? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request #2053: [FLINK-1707] Affinity Propagation

2016-06-29 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2053#discussion_r69015248 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/AffinityPropagation.java --- @@ -0,0 +1,535 @@ +/* + * Licensed

[GitHub] flink pull request #2185: [FLINK-4132] [gelly] Fix boxed comparison in Commu...

2016-06-29 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/2185 [FLINK-4132] [gelly] Fix boxed comparison in CommunityDetection algorithm You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink

[GitHub] flink pull request #2184: [FLINK-3618] [gelly] Rename abstract UDF classes i...

2016-06-29 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/2184 [FLINK-3618] [gelly] Rename abstract UDF classes in Scatter-Gather implementation Rename MessageFunction to ScatterFunction and VertexUpdateFunction to GatherFunction. Change

[GitHub] flink pull request #2178: [Flink-1815] Add methods to read and write a Graph...

2016-06-28 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2178#discussion_r68832940 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java --- @@ -408,6 +408,79 @@ public static GraphCsvReader fromCsvReader

[GitHub] flink pull request #2178: [Flink-1815] Add methods to read and write a Graph...

2016-06-28 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2178#discussion_r68832549 --- Diff: flink-libraries/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/Graph.scala --- @@ -1127,8 +1194,7 @@ TypeInformation : ClassTag

[GitHub] flink pull request #2178: [Flink-1815] Add methods to read and write a Graph...

2016-06-28 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2178#discussion_r68832491 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java --- @@ -408,6 +408,79 @@ public static GraphCsvReader fromCsvReader

[GitHub] flink pull request #2177: [FLINK-4127] Check API compatbility for 1.1 in fli...

2016-06-28 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2177#discussion_r68819516 --- Diff: docs/setup/config.md --- @@ -85,6 +85,8 @@ The default fraction for managed memory can be adjusted using the `taskmanager.m

[GitHub] flink issue #2179: [Flink-4128] fix flink-runtime compile error about git-co...

2016-06-28 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2179 The modified line is ancient code. It's not clear why this is necessary. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink issue #1517: [FLINK-3477] [runtime] Add hash-based combine strategy fo...

2016-06-28 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/1517 +1 with just a few superficial comments. Reading back through the discussion I see that there are many ideas for future performance enhancements. If not already suggested I'd like

[GitHub] flink pull request #1517: [FLINK-3477] [runtime] Add hash-based combine stra...

2016-06-27 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r68651782 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/InPlaceMutableHashTable.java --- @@ -0,0 +1,1079 @@ +/* + * Licensed

[GitHub] flink pull request #1517: [FLINK-3477] [runtime] Add hash-based combine stra...

2016-06-27 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r68649923 --- Diff: flink-tests/src/test/java/org/apache/flink/test/manual/ReducePerformance.java --- @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #1517: [FLINK-3477] [runtime] Add hash-based combine stra...

2016-06-27 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r68646048 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java --- @@ -1480,28 +1480,17 @@ public static int

[GitHub] flink pull request #1517: [FLINK-3477] [runtime] Add hash-based combine stra...

2016-06-27 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r68641370 --- Diff: flink-optimizer/src/main/java/org/apache/flink/optimizer/dag/ReduceNode.java --- @@ -45,10 +46,28 @@ public ReduceNode(ReduceOperatorBase

[GitHub] flink pull request #1517: [FLINK-3477] [runtime] Add hash-based combine stra...

2016-06-27 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r68640552 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeutils/SameTypePairComparator.java --- @@ -0,0 +1,44 @@ +/* + * Licensed

[GitHub] flink issue #2156: [FLINK-4113] [runtime] Always copy first value in Chained...

2016-06-27 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2156 @tillrohrmann just added a test for `ChainedAllReduceDriver`. I didn't see a way to build a lightweight test for chained drivers as we do with the unchained drivers. --- If your project is set

[GitHub] flink pull request #2156: [FLINK-4113] [runtime] Always copy first value in ...

2016-06-27 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2156#discussion_r68566231 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/chaining/ChainedAllReduceDriver.java --- @@ -89,7 +89,7 @@ public void collect

[GitHub] flink pull request #2160: [FLINK-3898] [gelly] Adamic-Adar Similarity

2016-06-24 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/2160 [FLINK-3898] [gelly] Adamic-Adar Similarity You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink 3898_adamic_adar_similarity

[GitHub] flink pull request #2156: [FLINK-4113] [runtime] Always copy first value in ...

2016-06-23 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/2156 [FLINK-4113] [runtime] Always copy first value in ChainedAllReduceDriver You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink

[GitHub] flink issue #1983: [FLINK-3868] [core] Specialized CopyableValue serializers...

2016-06-22 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/1983 Will verify and merge ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink issue #2032: [FLINK-3965] [gelly] Delegating GraphAlgorithm

2016-06-22 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2032 Hi @vasia, Configurations can be merged if there exists a configuration which satisfies all configuration constraints. It is left to the algorithm to decide whether and how to merged

[GitHub] flink issue #1626: [FLINK-3340] [runtime] Fix object juggling in drivers

2016-06-13 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/1626 Thank you @xhumanoid for reporting this! I will make the fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request #2079: [FLINK-3907] [gelly] Directed Clustering Coefficie...

2016-06-07 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/2079 [FLINK-3907] [gelly] Directed Clustering Coefficient You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink

[GitHub] flink issue #1983: [FLINK-3868] [core] Specialized CopyableValue serializers...

2016-06-07 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/1983 @StephanEwen updated per your suggestions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #2032: [FLINK-3965] [gelly] Delegating GraphAlgorithm

2016-06-07 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2032 @StephanEwen do you think this is a good and proper strategy? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink issue #2039: [FLINK-3978] [core] Add hasBroadcastVariable method to Ru...

2016-06-07 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2039 This was closed in 5b0287971fa2beda360105d96e7bfbc7a110fae7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request #2039: [FLINK-3978] [core] Add hasBroadcastVariable metho...

2016-06-07 Thread greghogan
Github user greghogan closed the pull request at: https://github.com/apache/flink/pull/2039 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #2064: [FLINK-3980] [core] Remove ExecutionConfig.PARALLELISM_UN...

2016-06-07 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2064 Will rebase and merge ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink issue #2002: Support for bz2 compression in flink-core

2016-06-03 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2002 This looks very handy. We should also update the formats table in the documentation. https://ci.apache.org/projects/flink/flink-docs-master/apis/batch/index.html#read-compressed-files

[GitHub] flink pull request #2066: Updated ssh configuration in base Dockerfile

2016-06-03 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2066#discussion_r65717466 --- Diff: flink-contrib/docker-flink/base/Dockerfile --- @@ -38,12 +38,12 @@ ENV JAVA_HOME /usr/java/default/ RUN echo 'root:secret' | chpasswd

[GitHub] flink issue #2060: [FLINK-3921] StringParser encoding

2016-06-03 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2060 The only internal usage of `StringParser` is from `GenericCsvInputFormat`. Should we make the encoding configurable in `GenericCsvInputFormat` with a default of US-ASCII? This could

[GitHub] flink pull request #2067: [FLINK-4013] [gelly] GraphAlgorithms to simplify d...

2016-06-03 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/2067 [FLINK-4013] [gelly] GraphAlgorithms to simplify directed and undirected graphs You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan

[GitHub] flink issue #2036: [FLINK-3806] [gelly] Revert use of DataSet.count()

2016-06-02 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2036 Will merge this ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #2064: [FLINK-3980] [core] Remove ExecutionConfig.PARALLE...

2016-06-02 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/2064 [FLINK-3980] [core] Remove ExecutionConfig.PARALLELISM_UNKNOWN You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink

[GitHub] flink pull request #2059: [FLINK-4003] Use intrinsics for MathUtils logarith...

2016-06-01 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/2059 [FLINK-4003] Use intrinsics for MathUtils logarithms You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink

[GitHub] flink pull request: [FLINK-3806] [gelly] Revert use of DataSet.count()

2016-06-01 Thread greghogan
Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/2036 Travis CI is now green. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink pull request: [FLINK-3945] [gelly] Degree annotation for directed grap...

2016-06-01 Thread greghogan
Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/2021 I'll merge this if there are no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-3806] [gelly] Revert use of DataSet.count()

2016-06-01 Thread greghogan
Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/2036 Yes. If I allow IntelliJ to handle automatically organize imports then they can be reordered due to a lack of consistency and project-wide guidelines. --- If your project is set up

[GitHub] flink pull request: [FLINK-3806] [gelly] Revert use of DataSet.count()

2016-05-31 Thread greghogan
Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/2036 All comments should now be addressed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-3836] Add LongHistogram accumulator

2016-05-27 Thread greghogan
Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1966#issuecomment-222161038 I was interested to see what happened here and a simple rebase and force push corrects the problem. Make sure local master is up-to-date $ git checkout

[GitHub] flink pull request: [FLINK-3965] [gelly] Delegating GraphAlgorithm

2016-05-26 Thread greghogan
Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/2032#issuecomment-221993882 There is more discussion in the ticket description, but for Gelly the idea is to keep algorithms small and discrete yet not duplicate computation. My first

[GitHub] flink pull request: [FLINK-3978] [core] Add hasBroadcastVariable m...

2016-05-26 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/2039 [FLINK-3978] [core] Add hasBroadcastVariable method to RuntimeContext New method RuntimeContext.hasBroadcastVariable(String). You can merge this pull request into a Git repository by running

[GitHub] flink pull request: [FLINK-3589] Allow setting Operator parallelis...

2016-05-26 Thread greghogan
Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1778#issuecomment-221965805 It's good to have you back :) I think we can get by with only `PARALLELISM_DEFAULT` since `java.operators.Operator.setParallelism(int)` is only called

[GitHub] flink pull request: [FLINK-3806] [gelly] Revert use of DataSet.cou...

2016-05-26 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2036#discussion_r64723638 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/gsa/GatherSumApplyIteration.java --- @@ -289,6 +300,11 @@ private GatherUdf

[GitHub] flink pull request: [FLINK-3806] [gelly] Revert use of DataSet.cou...

2016-05-26 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2036#discussion_r64718337 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/gsa/GatherSumApplyIteration.java --- @@ -289,6 +300,11 @@ private GatherUdf

[GitHub] flink pull request: [FLINK-3806] [gelly] Revert use of DataSet.cou...

2016-05-25 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/2036 [FLINK-3806] [gelly] Revert use of DataSet.count() This leaves the Graph API unchanged but GatherSumApplyIteration and ScatterGatherIteration now use broadcast variables to share

[GitHub] flink pull request: [FLINK-3477] [runtime] Add hash-based combine ...

2016-05-25 Thread greghogan
Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1517#issuecomment-221643813 What is the status of this PR? Can we get this in and tested for the 1.1 release? --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-3945] [gelly] Degree annotation for dir...

2016-05-25 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2021#discussion_r64594890 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/asm/degree/annotate/directed/EdgeDegreesPair.java --- @@ -0,0 +1,81

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-25 Thread greghogan
Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1956#issuecomment-221603165 @vasia in which module were the failures? master has been quite unstable recently now that tests are properly failing. --- If your project is set up for it, you can

[GitHub] flink pull request: [FLINK-3945] [gelly] Degree annotation for dir...

2016-05-25 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2021#discussion_r64587577 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/asm/degree/annotate/directed/EdgeDegreesPair.java --- @@ -0,0 +1,81

[GitHub] flink pull request: [FLINK-3589] Allow setting Operator parallelis...

2016-05-25 Thread greghogan
Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1778#issuecomment-221597445 `PARALLELISM_UNKNOWN` is a no-op which leaves the parallelism unchanged. This is a useful default for batch algorithms such as `JaccardIndex` for which parallelism

[GitHub] flink pull request: [FLINK-3965] [gelly] Delegating GraphAlgorithm

2016-05-25 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/2032 [FLINK-3965] [gelly] Delegating GraphAlgorithm A DelegatingGraphAlgorithm wraps a GraphAlgorithm result with a delegating proxy object. The delegated object can be replaced when the same

[GitHub] flink pull request: [FLINK-3945] [gelly] Degree annotation for dir...

2016-05-23 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/2021 [FLINK-3945] [gelly] Degree annotation for directed graphs You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink

[GitHub] flink pull request: [FLINK-3928] [gelly] Potential overflow due to...

2016-05-20 Thread greghogan
Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/2006#issuecomment-220658635 Merging ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-20 Thread greghogan
Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1956#issuecomment-220656004 Stanford provides several old graph datasets at https://snap.stanford.edu/data/index.html which might prove a better standard for benchmarking. --- If your project

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-20 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/1956#discussion_r64070513 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/HITSAlgorithm.java --- @@ -273,4 +289,23 @@ public void sendMessages

[GitHub] flink pull request: [FLINK-3780] [gelly] Jaccard Similarity

2016-05-20 Thread greghogan
Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1980#issuecomment-220600881 @vasia all updates should be in place. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request: [FLINK-3780] [gelly] Jaccard Similarity

2016-05-20 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/1980#discussion_r64037567 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/asm/degree/annotate/TranslateEdgeDegreeToIntValue.java --- @@ -0,0 +1,51

[GitHub] flink pull request: [FLINK-3780] [gelly] Jaccard Similarity

2016-05-19 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/1980#discussion_r63956013 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/similarity/JaccardIndex.java --- @@ -0,0 +1,462

[GitHub] flink pull request: [FLINK-3780] [gelly] Jaccard Similarity

2016-05-19 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/1980#discussion_r63951105 --- Diff: flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/examples/JaccardIndex.java --- @@ -0,0 +1,132

[GitHub] flink pull request: [FLINK-3780] [gelly] Jaccard Similarity

2016-05-19 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/1980#discussion_r63901325 --- Diff: flink-libraries/flink-gelly/src/test/java/org/apache/flink/graph/library/similarity/JaccardIndexTest.java --- @@ -0,0 +1,136

[GitHub] flink pull request: [FLINK-3780] [gelly] Jaccard Similarity

2016-05-19 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/1980#discussion_r63898835 --- Diff: flink-libraries/flink-gelly/src/test/java/org/apache/flink/graph/library/similarity/JaccardIndexTest.java --- @@ -0,0 +1,136

[GitHub] flink pull request: [FLINK-3780] [gelly] Jaccard Similarity

2016-05-19 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/1980#discussion_r63893365 --- Diff: docs/apis/batch/libs/gelly.md --- @@ -2051,6 +2052,26 @@ The algorithm takes a directed, vertex (and possibly edge) attributed graph as i

[GitHub] flink pull request: [FLINK-3780] [gelly] Jaccard Similarity

2016-05-19 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/1980#discussion_r63892035 --- Diff: docs/apis/batch/libs/gelly.md --- @@ -2051,6 +2052,26 @@ The algorithm takes a directed, vertex (and possibly edge) attributed graph as i

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-18 Thread greghogan
Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1956#issuecomment-220147037 I also like @vasia's idea since we might get to add the analytic `DyadicCensus` (basically counting how many edges are `u <-> v` and `u -> v`). The

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-18 Thread greghogan
Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1956#issuecomment-220143133 @vasia that is a very good idea. I've been doing this for `TriangleListing` for directed clustering coefficient and it should probably be a separate `GraphAlgorithm

[GitHub] flink pull request: [FLINK-3925] GraphAlgorithm to filter by maxim...

2016-05-18 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/2005 [FLINK-3925] GraphAlgorithm to filter by maximum degree You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink

<    5   6   7   8   9   10   11   12   >