[GitHub] flink pull request #2718: [hotfix] Fixes the TimestampedInputSplit.EOS compa...

2016-10-28 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/2718 [hotfix] Fixes the TimestampedInputSplit.EOS comparison. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kl0u/flink cont_fix Alternatively you

[GitHub] flink pull request #2707: [FLINK-4939] GenericWriteAheadSink: Decouple the c...

2016-10-27 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/2707 [FLINK-4939] GenericWriteAheadSink: Decouple the creating from the committing subtask for a pending checkpoint So far the GenericWriteAheadSink expected that the subtask that wrote a temporary buffer

[GitHub] flink issue #2618: [FLINK-4800] Refactor the ContinuousFileMonitoringFunctio...

2016-10-27 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2618 @mxm I just did. Let's wait for travis again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #2618: Refactoring the Continuous File Monitoring Function.

2016-10-21 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2618 Hi @mxm! Travis says ok, so please have another look and let me know if you have any additional comments. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink issue #2618: Refactoring the Continuous File Monitoring Function.

2016-10-20 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2618 Thanks for the comments @mxm ! I integrated them and waiting for Travis. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink issue #2618: Refactoring the Continuous File Monitoring Function.

2016-10-20 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2618 Thanks a lot @mxm ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #2570: [FLINK-3674] Add an interface for Time aware User ...

2016-10-20 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2570#discussion_r84236439 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java --- @@ -0,0 +1,317

[GitHub] flink pull request #2570: [FLINK-3674] Add an interface for Time aware User ...

2016-10-20 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2570#discussion_r84235862 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractStreamOperator.java --- @@ -390,4 +425,141 @@ public void close

[GitHub] flink pull request #2570: [FLINK-3674] Add an interface for Time aware User ...

2016-10-20 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2570#discussion_r84237685 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/DefaultProcessingTimeService.java --- @@ -35,10 +34,10 @@ import

[GitHub] flink pull request #2570: [FLINK-3674] Add an interface for Time aware User ...

2016-10-20 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2570#discussion_r84236659 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java --- @@ -0,0 +1,317

[GitHub] flink pull request #2570: [FLINK-3674] Add an interface for Time aware User ...

2016-10-20 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2570#discussion_r84237459 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/HeapInternalTimerService.java --- @@ -0,0 +1,317

[GitHub] flink issue #2618: Refactoring the Continuous File Monitoring Function.

2016-10-19 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2618 Hi @mxm ! Please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #2618: Refactoring the Continuous File Monitoring Functio...

2016-10-13 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2618#discussion_r83183505 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java --- @@ -60,26 +63,27

[GitHub] flink issue #2618: Refactoring the Continuous File Monitoring Function.

2016-10-11 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2618 Thanks @rmetzger ! This is the issue: https://issues.apache.org/jira/browse/FLINK-4800 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request #2618: [hotfix] Refactoring the Continuous File Monitorin...

2016-10-11 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/2618 [hotfix] Refactoring the Continuous File Monitoring Function. This is a refactoring of the code of the ContinuousFileMonitoringFunction and the related tests. The functionality is the same. You

[GitHub] flink pull request #2602: [hotfix] Re-register restored processing time time...

2016-10-06 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/2602 [hotfix] Re-register restored processing time timers. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kl0u/flink hotfix_reregister Alternatively

[GitHub] flink pull request #2593: [FLINK-4329] Fix Streaming File Source Timestamps/...

2016-10-05 Thread kl0u
Github user kl0u closed the pull request at: https://github.com/apache/flink/pull/2593 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #2593: [FLINK-4329] Fix Streaming File Source Timestamps/...

2016-10-05 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2593#discussion_r81995575 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamSource.java --- @@ -214,14 +216,26 @@ public

[GitHub] flink issue #2593: [FLINK-4329] Fix Streaming File Source Timestamps/Waterma...

2016-10-05 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2593 Thanks @mxm and @StephanEwen for the comments. I have updated the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request #2593: [FLINK-4329] Fix Streaming File Source Timestamps/...

2016-10-05 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/2593 [FLINK-4329] Fix Streaming File Source Timestamps/Watermarks Handling This is a quick fix for the [FLINK-4329] issue. The fix on the master is different but it contains more changes that are not easy

[GitHub] flink issue #2546: [FLINK-4329] Fix Streaming File Source Timestamps/Waterma...

2016-09-29 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2546 Hi @StephanEwen . If I understand correctly, your suggestion is to make the test something like the following: 1) put the split in the reader 2) read the split 3) when the split finishes update

[GitHub] flink issue #2546: [FLINK-4329] Fix Streaming File Source Timestamps/Waterma...

2016-09-29 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2546 Thanks for the comments @StephanEwen and @aljoscha ! I integrated most of them. Please have a look. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request #2546: [FLINK-4329] Fix Streaming File Source Timestamps/...

2016-09-29 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2546#discussion_r81089031 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/DefaultTimeServiceProvider.java --- @@ -99,7 +100,7 @@ public void run

[GitHub] flink pull request #2546: [FLINK-4329] Fix Streaming File Source Timestamps/...

2016-09-29 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2546#discussion_r81088167 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/DefaultTimeServiceProvider.java --- @@ -99,7 +100,7 @@ public void run

[GitHub] flink issue #2546: [FLINK-4329] Fix Streaming File Source Timestamps/Waterma...

2016-09-28 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2546 Hi @aljoscha, the problem with the AlignedWindowOperator tests is that they were using the DefaultTimeServiceProvider and by not shutting down the service, the previous timers would fire and throw

[GitHub] flink issue #2546: [FLINK-4329] Fix Streaming File Source Timestamps/Waterma...

2016-09-28 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2546 Hi @StephanEwen , thanks for the review! The watermarks/timestamps are now generated by the Reader, and not the operator that creates the splits. The same holds for the LongMax watermark

[GitHub] flink pull request #2546: [FLINK-4329] Fix Streaming File Source Timestamps/...

2016-09-25 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/2546 [FLINK-4329] Fix Streaming File Source Timestamps/Watermarks Handling You can merge this pull request into a Git repository by running: $ git pull https://github.com/kl0u/flink

[GitHub] flink pull request #2434: [FLINK-4496] Refactor the TimeServiceProvider to t...

2016-09-23 Thread kl0u
Github user kl0u closed the pull request at: https://github.com/apache/flink/pull/2434 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #2532: [FLINK-4494] Expose the TimeServiceProvider from t...

2016-09-23 Thread kl0u
Github user kl0u closed the pull request at: https://github.com/apache/flink/pull/2532 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #2532: [FLINK-4494] Expose the TimeServiceProvider from the Task...

2016-09-23 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2532 Yes. Thanks a lot @aljoscha ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink issue #2434: [FLINK-4496] Refactor the TimeServiceProvider to take a T...

2016-09-22 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2434 Thanks @mxm and @aljoscha ! I already have the followup on this open here: https://github.com/apache/flink/pull/2532 --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request #2532: [FLINK-4494] Expose the TimeServiceProvider from t...

2016-09-21 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/2532 [FLINK-4494] Expose the TimeServiceProvider from the Task to each Operator. This is a PR for both [FLINK-4496] and [FLINK-4494]. R: @aljoscha You can merge this pull request into a Git repository

[GitHub] flink pull request #934: Framesize fix

2016-09-20 Thread kl0u
Github user kl0u closed the pull request at: https://github.com/apache/flink/pull/934 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #2434: [FLINK-4496] Refactor the TimeServiceProvider to take a T...

2016-09-20 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2434 R: @mxm @aljoscha @rmetzger This is ready for review. Thanks a lot for the comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request #2434: [FLINK-4496] Refactor the TimeServiceProvider to t...

2016-09-19 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2434#discussion_r79390766 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/util/OneInputStreamOperatorTestHarness.java --- @@ -98,7 +99,7 @@ public

[GitHub] flink issue #2446: [hotfix] Fixes unstable ContinuousFileMonitoringTest.

2016-09-01 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2446 Thanks a lot @aljoscha ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #2446: [hotfix] Fixes unstable ContinuousFileMonitoringTe...

2016-08-31 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/2446 [hotfix] Fixes unstable ContinuousFileMonitoringTest. R: @aljoscha Please review. This is a fix to the unstable test shown here: https://s3.amazonaws.com/archive.travis-ci.org/jobs

[GitHub] flink pull request #2434: [FLINK-4496] Refactor the TimeServiceProvider to t...

2016-08-29 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/2434 [FLINK-4496] Refactor the TimeServiceProvider to take a Trigerable in… This is a first step towards https://issues.apache.org/jira/browse/FLINK-4329 R: @aljoscha @rmetzger You can merge

[GitHub] flink pull request #2350: [FLINK-4329] Fix Streaming File Source Timestamps/...

2016-08-27 Thread kl0u
Github user kl0u closed the pull request at: https://github.com/apache/flink/pull/2350 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #2415: [FLINK-4407] Implement the trigger DSL

2016-08-24 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/2415 [FLINK-4407] Implement the trigger DSL This PR implements the Trigger DSL as presented in [FLIP-9](https://cwiki.apache.org/confluence/display/FLINK/FLIP-9%3A+Trigger+DSL) with the addition

[GitHub] flink issue #2350: [FLINK-4329] Fix Streaming File Source Timestamps/Waterma...

2016-08-11 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2350 The way it works is that now the reader gets a ReaderContext and emits its own watermarks depending on which timeCharacteristic we are operating on. If it is on IngestionTime, which was the original

[GitHub] flink pull request #2350: [FLINK-4329] Fix Streaming File Source Timestamps/...

2016-08-10 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/2350 [FLINK-4329] Fix Streaming File Source Timestamps/Watermarks Handling You can merge this pull request into a Git repository by running: $ git pull https://github.com/kl0u/flink

[GitHub] flink issue #2278: [FLINK-4239] Set Default Allowed Lateness to Zero and Mak...

2016-07-25 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2278 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #2278: [FLINK-4239] Set Default Allowed Lateness to Zero ...

2016-07-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2278#discussion_r72077206 --- Diff: flink-tests/src/test/java/org/apache/flink/test/windowing/sessionwindows/SessionWindowITCase.java --- @@ -114,8 +115,8 @@ private void runTest

[GitHub] flink issue #2278: [FLINK-4239] Set Default Allowed Lateness to Zero and Mak...

2016-07-25 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2278 Thanks a lot for the work @aljoscha I just had some minor comments! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request #2278: [FLINK-4239] Set Default Allowed Lateness to Zero ...

2016-07-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2278#discussion_r72074373 --- Diff: flink-tests/src/test/java/org/apache/flink/test/windowing/sessionwindows/SessionWindowITCase.java --- @@ -114,8 +115,8 @@ private void runTest

[GitHub] flink pull request #2278: [FLINK-4239] Set Default Allowed Lateness to Zero ...

2016-07-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2278#discussion_r72073857 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java --- @@ -1409,7 +1409,7 @@ public

[GitHub] flink pull request #2278: [FLINK-4239] Set Default Allowed Lateness to Zero ...

2016-07-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2278#discussion_r72065910 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/PurgingTrigger.java --- @@ -93,13 +90,12 @@ public boolean

[GitHub] flink pull request #2278: [FLINK-4239] Set Default Allowed Lateness to Zero ...

2016-07-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2278#discussion_r72065896 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/PurgingTrigger.java --- @@ -44,39 +44,36 @@ private

[GitHub] flink pull request #2278: [FLINK-4239] Set Default Allowed Lateness to Zero ...

2016-07-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2278#discussion_r72065755 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/PurgingTrigger.java --- @@ -44,39 +44,36 @@ private

[GitHub] flink pull request #2278: [FLINK-4239] Set Default Allowed Lateness to Zero ...

2016-07-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2278#discussion_r72065711 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/PurgingTrigger.java --- @@ -44,39 +44,36 @@ private

[GitHub] flink issue #2278: [FLINK-4239] Set Default Allowed Lateness to Zero and Mak...

2016-07-25 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2278 @uce I will do it today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #2245: [hotfix] Fix Redis Sink to fail at opening if Redis is no...

2016-07-22 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2245 I think this is ok now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #2245: [hotfix] Fix Redis Sink to fail at opening if Redi...

2016-07-22 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2245#discussion_r71869640 --- Diff: flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkTest.java --- @@ -105,18 +105,13

[GitHub] flink issue #2245: [hotfix] Fix Redis Sink to fail at opening if Redis is no...

2016-07-22 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2245 Done! Thanks @tillrohrmann --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] flink pull request #2277: [FLINK-4207] WindowOperator becomes very slow with...

2016-07-21 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/2277 [FLINK-4207] WindowOperator becomes very slow with allowed lateness Fixes the slowdown due to the allowedLateness. The problem was the deleteCleanupTimer that was called on cleanup() for each

[GitHub] flink pull request #2270: [FLINK-3956] Make FileInputFormats independent fro...

2016-07-20 Thread kl0u
Github user kl0u closed the pull request at: https://github.com/apache/flink/pull/2270 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #2270: [FLINK-3956] Make FileInputFormats independent from Confi...

2016-07-20 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2270 Done! Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #2270: [FLINK-3956] Make FileInputFormats independent from Confi...

2016-07-20 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2270 Thanks a lot @aljoscha ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #2270: [FLINK-3956] Make FileInputFormats independent fro...

2016-07-20 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/2270 [FLINK-3956] Make FileInputFormats independent from Configuration This PR makes all the parameters from the input formats accessible through setters. Before, some could only be set through

[GitHub] flink issue #2245: [hotfix] Fix Redis Sink to fail at opening if Redis is no...

2016-07-20 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2245 Thanks a lot @tillrohrmann ! I integrated your comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink issue #2245: [hotfix] Fix Redis Sink to fail at opening if Redis is no...

2016-07-19 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2245 Hi @tillrohrmann !Thanks for the comments, I addressed the ones that should be addressed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request #2245: [hotfix] Fix Redis Sink to fail at opening if Redi...

2016-07-19 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2245#discussion_r71379345 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisContainer.java

[GitHub] flink issue #2259: [hotfix] Fixes broken TopSpeedWindowing scala example

2016-07-19 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2259 @tillrohrmann I integrated the comments. Please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request #2245: [hotfix] Fix Redis Sink to fail at opening if Redi...

2016-07-18 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2245#discussion_r71157753 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisContainer.java

[GitHub] flink pull request #2259: [hotfix] Fixes broken TopSpeedWindowing scala exam...

2016-07-18 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2259#discussion_r71155772 --- Diff: flink-examples/flink-examples-streaming/src/main/scala/org/apache/flink/streaming/scala/examples/windowing/TopSpeedWindowing.scala --- @@ -72,7

[GitHub] flink pull request #2259: [hotfix] Fixes broken TopSpeedWindowing scala exam...

2016-07-15 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/2259 [hotfix] Fixes broken TopSpeedWindowing scala example The problem was that in the case where no input file was provided, the `fromCollection()` source was never exiting and the actual program

[GitHub] flink pull request #2245: [hotfix] Fix Redis Sink to fail at opening if Redi...

2016-07-14 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/2245 [hotfix] Fix Redis Sink to fail at opening if Redis is not initialized. Before if Redis was not initialized, the job would start and would wait until the first element arrives in order to realize

[GitHub] flink issue #1813: [FLINK-3034] Redis Sink Connector

2016-07-12 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/1813 Hi @subhankarb ! By playing around with the sink during testing, I saw that if Redis goes down in the middle of the execution of a job, the job has to wait until the next element (after the Redis

[GitHub] flink issue #2109: [FLINK-3677] FileInputFormat: Allow to specify include/ex...

2016-07-08 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2109 1) If it is to include it, then I would suggest to just replace the DefaultFilter with that, and probably give some initial patterns for e.g. hidden files (start with "."). Having two imple

[GitHub] flink issue #2109: [FLINK-3677] FileInputFormat: Allow to specify include/ex...

2016-07-08 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2109 Hi @mushketyk , Sorry for the late reply. I have some general comments on the PR. 1) Given the FilePathFilter, I think that the GlobFilePathFilter is redundant, right

[GitHub] flink pull request #2199: [FLINK-3648] Introduce Trigger Test Harness

2016-07-07 Thread kl0u
Github user kl0u closed the pull request at: https://github.com/apache/flink/pull/2199 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #2198: [FLINK-4133] Reflect streaming file source changes in doc...

2016-07-05 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2198 Thanks @rmetzger ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #2198: [FLINK-4133] Reflect streaming file source changes in doc...

2016-07-05 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2198 @rmetzger I updated the PR. Please let me know if you have any further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request #2198: [FLINK-4133] Reflect streaming file source changes...

2016-07-05 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2198#discussion_r69561987 --- Diff: docs/apis/streaming/index.md --- @@ -1310,21 +1310,28 @@ Data Sources -Sources can by created by using

[GitHub] flink pull request #2198: [FLINK-4133] Reflect streaming file source changes...

2016-07-05 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2198#discussion_r69561903 --- Diff: docs/apis/streaming/index.md --- @@ -1310,21 +1310,28 @@ Data Sources -Sources can by created by using

[GitHub] flink pull request #2198: [FLINK-4133] Reflect streaming file source changes...

2016-07-05 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2198#discussion_r69561860 --- Diff: docs/apis/streaming/index.md --- @@ -1310,21 +1310,28 @@ Data Sources -Sources can by created by using

[GitHub] flink pull request #2198: [FLINK-4133] Reflect streaming file source changes...

2016-07-05 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2198#discussion_r69561347 --- Diff: docs/apis/streaming/index.md --- @@ -1357,20 +1364,27 @@ Custom: -Sources can by created by using

[GitHub] flink issue #2199: [FLINK-3648] Introduce Trigger Test Harness

2016-07-05 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2199 Thanks for the comments @aljoscha ! I integrated them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request #2199: [FLINK-3648] Introduce Trigger Test Harness

2016-07-05 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/2199 [FLINK-3648] Introduce Trigger Test Harness Adds a test harness that facilitates the testing of custom triggers and window assigners. You can merge this pull request into a Git repository by running

[GitHub] flink pull request #2198: [FLINK-4133] Reflect streaming file source changes...

2016-07-04 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/2198 [FLINK-4133] Reflect streaming file source changes in documentation The title says it all. It documents the continuous file processing semantics recently introduced in the Streaming API. You can

[GitHub] flink issue #2109: [FLINK-3677] FileInputFormat: Allow to specify include/ex...

2016-07-01 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2109 @mushketyk Hello! Sorry for the later reply. I can review this on Monday. This week I am on holidays. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request #2124: [FLINK-3647] Change StreamSource to use Processing...

2016-06-30 Thread kl0u
Github user kl0u closed the pull request at: https://github.com/apache/flink/pull/2124 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #2154: [FLINK-4062] Update Windowing Documentation

2016-06-28 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2154 Thanks for updating/fixing the documentation @aljoscha ! I had some comments that I posted here. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request #2154: [FLINK-4062] Update Windowing Documentation

2016-06-28 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2154#discussion_r68744858 --- Diff: docs/apis/streaming/windows.md --- @@ -24,1023 +24,593 @@ specific language governing permissions and limitations under the License

[GitHub] flink pull request #2154: [FLINK-4062] Update Windowing Documentation

2016-06-28 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2154#discussion_r68744802 --- Diff: docs/apis/streaming/windows.md --- @@ -24,1023 +24,593 @@ specific language governing permissions and limitations under the License

[GitHub] flink pull request #2154: [FLINK-4062] Update Windowing Documentation

2016-06-28 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2154#discussion_r68744340 --- Diff: docs/apis/streaming/windows.md --- @@ -24,1023 +24,593 @@ specific language governing permissions and limitations under the License

[GitHub] flink pull request #2154: [FLINK-4062] Update Windowing Documentation

2016-06-28 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2154#discussion_r68743505 --- Diff: docs/apis/streaming/windows.md --- @@ -24,1023 +24,593 @@ specific language governing permissions and limitations under the License

[GitHub] flink pull request #2154: [FLINK-4062] Update Windowing Documentation

2016-06-28 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2154#discussion_r68743168 --- Diff: docs/apis/streaming/windows.md --- @@ -24,1023 +24,593 @@ specific language governing permissions and limitations under the License

[GitHub] flink pull request #2154: [FLINK-4062] Update Windowing Documentation

2016-06-28 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2154#discussion_r68742875 --- Diff: docs/apis/streaming/windows.md --- @@ -24,1023 +24,593 @@ specific language governing permissions and limitations under the License

[GitHub] flink pull request #2174: [FLINK-4075] ContinuousFileProcessingCheckpointITC...

2016-06-28 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/2174 [FLINK-4075] ContinuousFileProcessingCheckpointITCase failed on Travis You can merge this pull request into a Git repository by running: $ git pull https://github.com/kl0u/flink hotfix_file_src

[GitHub] flink pull request #2154: [FLINK-4062] Update Windowing Documentation

2016-06-28 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2154#discussion_r68733572 --- Diff: docs/apis/streaming/windows.md --- @@ -24,1023 +24,593 @@ specific language governing permissions and limitations under the License

[GitHub] flink pull request #2154: [FLINK-4062] Update Windowing Documentation

2016-06-28 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2154#discussion_r68732942 --- Diff: docs/apis/streaming/windows.md --- @@ -24,1023 +24,593 @@ specific language governing permissions and limitations under the License

[GitHub] flink pull request #2154: [FLINK-4062] Update Windowing Documentation

2016-06-28 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2154#discussion_r68732802 --- Diff: docs/apis/streaming/windows.md --- @@ -24,1023 +24,593 @@ specific language governing permissions and limitations under the License

[GitHub] flink pull request #2154: [FLINK-4062] Update Windowing Documentation

2016-06-28 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2154#discussion_r68732411 --- Diff: docs/apis/streaming/windows.md --- @@ -24,1023 +24,593 @@ specific language governing permissions and limitations under the License

[GitHub] flink pull request #2154: [FLINK-4062] Update Windowing Documentation

2016-06-28 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2154#discussion_r68731943 --- Diff: docs/apis/streaming/windows.md --- @@ -24,1023 +24,593 @@ specific language governing permissions and limitations under the License

[GitHub] flink pull request #2154: [FLINK-4062] Update Windowing Documentation

2016-06-28 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2154#discussion_r68731685 --- Diff: docs/apis/streaming/windows.md --- @@ -24,1023 +24,593 @@ specific language governing permissions and limitations under the License

[GitHub] flink pull request #2154: [FLINK-4062] Update Windowing Documentation

2016-06-28 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2154#discussion_r68731626 --- Diff: docs/apis/streaming/windows.md --- @@ -24,1023 +24,593 @@ specific language governing permissions and limitations under the License

[GitHub] flink pull request #2154: [FLINK-4062] Update Windowing Documentation

2016-06-28 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2154#discussion_r68731488 --- Diff: docs/apis/streaming/windows.md --- @@ -24,1023 +24,593 @@ specific language governing permissions and limitations under the License

[GitHub] flink pull request #2154: [FLINK-4062] Update Windowing Documentation

2016-06-28 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2154#discussion_r68731283 --- Diff: docs/apis/streaming/windows.md --- @@ -24,1023 +24,593 @@ specific language governing permissions and limitations under the License

<    3   4   5   6   7   8   9   10   >