[GitHub] flink issue #6232: [FLINK-9695] [mesos] Add option for Mesos executor to for...

2018-07-02 Thread lishim
Github user lishim commented on the issue: https://github.com/apache/flink/pull/6232 Hi @tillrohrmann. Thank you for your comment. I have updated the code to conform to other configuration options. ---

[GitHub] flink pull request #6232: [FLINK-9695] [mesos] Add option for Mesos executor...

2018-06-30 Thread lishim
GitHub user lishim opened a pull request: https://github.com/apache/flink/pull/6232 [FLINK-9695] [mesos] Add option for Mesos executor to forcefully pull Docker images ## What is the purpose of the change * This pull request introduces an option for Mesos executor

[GitHub] flink pull request #6207: [FLINK-9660] [mesos] Allow passing custom artifact...

2018-06-25 Thread lishim
GitHub user lishim opened a pull request: https://github.com/apache/flink/pull/6207 [FLINK-9660] [mesos] Allow passing custom artifacts to Mesos workers ## What is the purpose of the change * This pull request introduces a feature that allows passing custom artifact URIs

[GitHub] flink issue #5346: [FLINK-8490] [mesos] Allow custom docker parameters for d...

2018-01-24 Thread lishim
Github user lishim commented on the issue: https://github.com/apache/flink/pull/5346 Thanks @joerg84 for your review and comments. I have updated the PR to address your concerns. ---

[GitHub] flink pull request #5346: [FLINK-8490] [mesos] Allow custom docker parameter...

2018-01-24 Thread lishim
Github user lishim commented on a diff in the pull request: https://github.com/apache/flink/pull/5346#discussion_r163596583 --- Diff: flink-mesos/src/test/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParametersTest.java --- @@ -84,6 +84,35 @@ public void

[GitHub] flink pull request #5346: [FLINK-8490] [mesos] Allow custom docker parameter...

2018-01-24 Thread lishim
Github user lishim commented on a diff in the pull request: https://github.com/apache/flink/pull/5346#discussion_r163596501 --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java --- @@ -365,6 +386,31 @@ public String

[GitHub] flink pull request #5346: [FLINK-8490] [mesos] Allow custom docker parameter...

2018-01-24 Thread lishim
Github user lishim commented on a diff in the pull request: https://github.com/apache/flink/pull/5346#discussion_r163595840 --- Diff: docs/ops/config.md --- @@ -508,6 +508,8 @@ May be set to -1 to disable this feature. - `mesos.resourcemanager.tasks.container.volumes

[GitHub] flink pull request #5346: [FLINK-8490] [mesos] Allow custom docker parameter...

2018-01-24 Thread lishim
Github user lishim commented on a diff in the pull request: https://github.com/apache/flink/pull/5346#discussion_r163595893 --- Diff: docs/ops/deployment/mesos.md --- @@ -264,6 +264,8 @@ May be set to -1 to disable this feature

[GitHub] flink pull request #5346: [FLINK-8490] [mesos] Allow custom docker parameter...

2018-01-23 Thread lishim
GitHub user lishim opened a pull request: https://github.com/apache/flink/pull/5346 [FLINK-8490] [mesos] Allow custom docker parameters for docker tasks on Mesos ## What is the purpose of the change - This pull request introduces a feature that allows passing custom parameters