Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2542#discussion_r90032424
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/recommendation/ALS.scala
---
@@ -581,6 +637,16 @@ object ALS {
val
Github user mbalassi commented on the issue:
https://github.com/apache/flink/pull/2542
Yes @gaborhermann , I finally got here. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mbalassi commented on the issue:
https://github.com/apache/flink/pull/2094
Merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r88617516
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessorFactory.java
---
@@ -0,0 +1,197
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r88615926
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessorFactory.java
---
@@ -0,0 +1,197
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r88616007
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessorFactory.java
---
@@ -0,0 +1,197
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r88615630
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessor.java
---
@@ -0,0 +1,386 @@
+/*
+ * Licensed
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r88614862
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessor.java
---
@@ -0,0 +1,386 @@
+/*
+ * Licensed
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r88614874
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessor.java
---
@@ -0,0 +1,386 @@
+/*
+ * Licensed
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r88614846
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessor.java
---
@@ -0,0 +1,386 @@
+/*
+ * Licensed
Github user mbalassi commented on the issue:
https://github.com/apache/flink/pull/2094
Thanks @fhueske. I am happy to squash the commits and merge the PR given
that you are satisfied with it.
I would like to merge it by mid next week, so I could proceed with adding
Github user mbalassi commented on the issue:
https://github.com/apache/flink/pull/2094
As @fhueske and @StephanEwen has suggested I have refactored @ggevay's code
and now instead of adding two methods to the `TypeInformation` I have moved the
functionality to a `FieldAccessorFactory
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r86366630
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -264,6 +265,7 @@ public void getFlatFields(String
Github user mbalassi commented on the issue:
https://github.com/apache/flink/pull/2542
@gaborhermann @thvasilo I would definitely like to see a test on a larger
dataset, that is actually what I was asking for when I mentioned "benchmark",
maybe I was not clear then.
-
Github user mbalassi commented on the issue:
https://github.com/apache/flink/pull/2542
@gaborhermann @jfeher Could you share results where you benchmarked the
algorithm against other implementations, please?
---
If your project is set up for it, you can reply to this email and have
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2542#discussion_r80248596
--- Diff: docs/dev/libs/ml/als.md ---
@@ -49,6 +49,18 @@ By applying this step alternately to the matrices $U$
and $V$, we can iterativel
Github user mbalassi commented on the issue:
https://github.com/apache/flink/pull/2094
We have gone through the changes with @ggevay and found that the
documentation is lacking or misleading in a couple of cases.
1. The DataStream API JavaDocs mention that one can aggregate
Github user mbalassi commented on the issue:
https://github.com/apache/flink/pull/2211
@Xazax-hun you have not addressed @greghogan's initial comment on enabling
code generation by default. I do agree with @greghogan in the sense that we
should take the usual, humble road of first
Github user mbalassi commented on the issue:
https://github.com/apache/flink/pull/2211
@Xazax-hun, it is geat to see the progress in the code, we are looking
forward to the benchmark numbers posted here too.
---
If your project is set up for it, you can reply to this email and have
Github user mbalassi commented on the issue:
https://github.com/apache/flink/pull/2324
Oh, my bad - those are just IntelliJ files left over on my machine. Adding
the doc update to the tools script and quickly rebasing this commit. Sorry for
the fuss.
---
If your project is set up
Github user mbalassi commented on the issue:
https://github.com/apache/flink/pull/2324
If it can wait until tomorrow morning CEST I will add these to the change
version scripts in tools. If it is urgent go ahead.
---
If your project is set up for it, you can reply to this email
Github user mbalassi commented on the issue:
https://github.com/apache/flink/pull/2324
~~~
mbalassi$ grep 1.1-SNAPSHOT -R .
./docs/_config.yml:version: "1.1-SNAPSHOT"
./flink-metric-reporters/flink-metrics-dropwizard/flink-metrics-dropwizard.iml:
./fl
Github user mbalassi commented on the issue:
https://github.com/apache/flink/pull/2324
We also need to bump the version in the metrics imls.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mbalassi commented on the issue:
https://github.com/apache/flink/pull/2324
Good catch, looking into that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user mbalassi opened a pull request:
https://github.com/apache/flink/pull/2324
Bump version to 1.2-SNAPSHOT
It is about time to do this.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mbalassi/flink 12-bump
Github user mbalassi commented on the issue:
https://github.com/apache/flink/pull/2299
Thanks @nssalian, merging then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user mbalassi commented on the issue:
https://github.com/apache/flink/pull/2299
The code change is very concise and looks right, the one issue that bugs me
is that there are no direct tests in place to verify it - and it is not
necessarily straight forward to test
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1829#issuecomment-204587443
I think @smarthi has a point that the functionality is a nice fit for
`DataSetUtils` and he has properly added it to the scala API and covered the
tests
Github user mbalassi closed the pull request at:
https://github.com/apache/flink/pull/1784
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user mbalassi opened a pull request:
https://github.com/apache/flink/pull/1784
[FLINK-3610][api-breaking][streaming] Introduced Scala DataStreamSink
The change is effectively already tested in `DataStreamTest`.
It might make sense to introduce further testing
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1753#issuecomment-193707660
If no objections I would like to merge this Friday morning.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1766#issuecomment-192954747
Do not forget to add the licence header to `NotCallGenerator` when merging.
:)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1769#issuecomment-192954621
I would be curious about the soft reference implementation as in
DetaIteration cases I think it is a valid situation that the job needs less and
less memory. Please
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1753#issuecomment-191797058
Thanks or catching it, pushed the fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user mbalassi opened a pull request:
https://github.com/apache/flink/pull/1753
[build] Consolidate scala checkstyle usage and update version to 0.8.0
Consolidation is done via plugin management, so that configuration is done
in one central location.
Version update
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1685#issuecomment-190584934
If no objections will merge this tomorrow morning.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1730#issuecomment-189802390
Thanks for the fixes, @wuchong. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1594#issuecomment-180842858
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1574#issuecomment-179434902
Thanks for the comments, updated the PR accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1574#issuecomment-178823650
Thanks for the comments. @gumchum: Internally it is stored as a Java
`Iterator` and that is the reason why left it so, but it definitely make sense
to convert
GitHub user mbalassi opened a pull request:
https://github.com/apache/flink/pull/1574
Scala DataStream accessors fix
The PR contains two orthogonal approaches of fixing the access to
`DataStreamUtils.collect` for a scala environment. One or both of the
approaches can be merged
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1563#issuecomment-177088061
With the `RollingHDFSSink` this functionality is not needed any more and as
you suggested apparently was a misleading implmentation anyway. I like your not
to the docs
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1517#issuecomment-177094172
I think exposing the feature through the API similarly to the way join
strategies are exposed is the way to properly make this feature available for
users. I would
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1468#issuecomment-171931286
I do like the exponential back off as default, enables streaming but is
flexible enough to tolerate temporal resource unavailability.
Having simply 0
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1480#discussion_r48890591
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/DataSet.scala ---
@@ -89,7 +89,7 @@ class DataSet[T: ClassTag](set: JavaDataSet[T
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1480#discussion_r48891609
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/DataSet.scala ---
@@ -89,7 +89,7 @@ class DataSet[T: ClassTag](set: JavaDataSet[T
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1480#discussion_r48891663
--- Diff:
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/DataStream.scala
---
@@ -44,7 +44,14 @@ class DataStream[T](javaStream
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1480#discussion_r48892324
--- Diff:
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/DataStream.scala
---
@@ -44,7 +44,14 @@ class DataStream[T](javaStream
GitHub user mbalassi opened a pull request:
https://github.com/apache/flink/pull/1480
[streaming] [scala] Exposed environment from DataStream
This is needed for streaming library features, is identical to the batch
API.
You can merge this pull request into a Git repository
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1343#discussion_r44397599
--- Diff: tools/maven/checkstyle.xml ---
@@ -54,11 +54,18 @@ under the License
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1243#issuecomment-148675785
I would like to shepherd this PR.
@HilmiYildirim, I do agree with your suggestion regarding the checkpoint
log. Could you change that in the PR, please
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1251#issuecomment-147186840
I would like to shepherd this PR.
Thanks for solving your first Flink Jira, @ehnalis! :+1:
A line of description would have been nice, but the code
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1253#issuecomment-147186892
Nice catch! :+1: I think it is fine to put this in without creating to much
overhead.
Merging...
---
If your project is set up for it, you can reply to this email
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1239#issuecomment-146830200
I think when drawing the snapshot with `Checkpointed` you are already
inside a streaming `Function` or internal operator where one can easily access
that information
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1208#issuecomment-146542207
Thanks for this big update, guys!
Some comments:
* Explanation of operator chaining and options are missing.
* Collection Data Sources
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1155#issuecomment-145869707
@StephanEwen: Thanks, I will go ahead and merge it.
I still had a small hick-up in the scala api, that I had fixed just now -
so I am waiting for travis
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1155#issuecomment-145665200
@StephanEwen : Thanks for the heads-up.
Now I have addressed the comments and would like to merge this tomorrow if
there are no objections.
---
If your
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1155#issuecomment-145230558
Quick update:
I made some progress on the custom state checkpointer solution, but run
into an issue with key selectors. This would break the current API usage
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1168#issuecomment-142948084
@rmetzger, sure, somehow I missed those tests. Now fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1179#issuecomment-142954095
Merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user mbalassi opened a pull request:
https://github.com/apache/flink/pull/1168
[utils] Missing getters for ParameterTool
When using the `ParameterTool` I have found the `Boolean` getter missing,
so added the missing functions.
You can merge this pull request into a Git
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1155#issuecomment-141954741
@gyfora: I do not necessarily see that fit together yet, but let us have a
brainstorm on the topic.
@StephanEwen: This is the "infinite" version, but I
GitHub user mbalassi opened a pull request:
https://github.com/apache/flink/pull/1155
[FLINK-2283] [streaming] Make grouped reduce/fold/aggregations stateful
There is an open discussion at the related ticket [1] about fully removing
the operators that I touch and partially remove
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1126#discussion_r39383837
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/state/EagerStateStore.java
---
@@ -43,7 +44,7
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1120#issuecomment-140046200
Hey @lofifnc,
Thanks for your interest in Flink. Could you explain why do you need access
to the wrapped Java `StreamExecutionEnvironment`? I think all
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1126#issuecomment-140045524
Apart from that one comment looks good to me, handy feature.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1119#issuecomment-140056107
Makes sense, will merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1069#discussion_r38091104
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/partitioner/PartialPartitioner.java
---
@@ -0,0 +1,60
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1069#issuecomment-135418178
Thanks for the fast response on your side addressing my comments. :)
I generally love the idea described at
[FLINK-1725](https://issues.apache.org/jira/browse
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1068#issuecomment-135420490
Thanks for picking up the issue. Could you make the changes for the
`flink-streaming-examples` and the `flink-storm-compatibility-example` modules
too, please? Also
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1069#discussion_r38088713
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/partitioner/PartialPartitioner.java
---
@@ -0,0 +1,60
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1037#discussion_r37661571
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/wordcount
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1025#issuecomment-132153447
Hey @Rucongzhang,
As this is your first contribution to Flink and the PR was issued before a
relevant notice on the developer mailing list that advises against
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1025#issuecomment-131616685
I think this is a small enough and straightforward function that having the
same name for the return variable does not hurt that much. The name you have
suggested
GitHub user mbalassi opened a pull request:
https://github.com/apache/flink/pull/1014
[Flink-2286] [0.9.1] ParallelMerge fix
This PR augments #994 with a test. In my experience the issue only appears
occasionally with the code that @gaborhermann suggested.
You can merge this pull
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1007#issuecomment-130219835
Will merge this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/980#issuecomment-129851909
Merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/980#issuecomment-129042045
Simplified the testing topology and added a bit more comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/994#issuecomment-128691615
We could add an ITCase to make sure that the fix works. I am not saying
that this is the ideal way to test it, but it is definitely a way to get some
coverage over
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/993#issuecomment-128383932
Big +1, this should fix the checkpointing test failures.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/980#issuecomment-127952500
Sure, thanks for checking it out. :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/980#issuecomment-128003870
Thanks, fair enough. I'll give it another try soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/988#discussion_r36284249
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/transformations/CoFeedbackTransformation.java
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/988#discussion_r36284613
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/transformations/SinkTransformation.java
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/988#issuecomment-127940968
I am not sure that I understand this correctly: If a non parallel source is
used does the user need to call `rebalance` to use all parallel instances of
the downstream
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/853#issuecomment-127944348
If no objections I will merge this in the evening. (Maybe also squashing
the commits a bit.)
---
If your project is set up for it, you can reply to this email and have
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/980#issuecomment-127944519
If no objections I will merge this in the evening.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user mbalassi opened a pull request:
https://github.com/apache/flink/pull/980
[FLINK-2423] [streaming] ITCase for checkpoint notifications
See javadoc and Jira.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mbalassi
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/980#discussion_r36168137
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/StreamCheckpointNotifierITCase.java
---
@@ -0,0 +1,429 @@
+/*
+ * Licensed
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/965#issuecomment-126619190
Good catch, if no objections I will merge this in the evening.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/802#issuecomment-15823
I think this has been merged manually by @gyfora.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/911#issuecomment-121503903
I also prefer `of` as a method name.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user mbalassi opened a pull request:
https://github.com/apache/flink/pull/873
[FLINK-2285] [streaming] Removed duplicate call in close from
GroupedActiveDiscretizer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/862#issuecomment-114800805
Hey,
Thanks for picking up this issue. The main task here is that the
`Reader#read()` method returns an int representation of a character. To use
String
Github user mbalassi commented on a diff in the pull request:
https://github.com/apache/flink/pull/860#discussion_r33128501
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/operators/StreamFoldTest.java
---
@@ -1,57 +0,0
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/855#issuecomment-114179961
Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/835#issuecomment-114149626
I do not think that we can expect that every user starts from the
quickstart poms, but it is true that a reference to that would have been nicer.
I have
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/857#issuecomment-114184152
Thanks for spotting this, Gabor. Looks good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user mbalassi opened a pull request:
https://github.com/apache/flink/pull/855
[streaming] Properly forward rich window function calls to wrapped fuâ¦
â¦nctions
Open and close were not called, because of the wrapping in windowing. I
should have realized this when
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/684#issuecomment-113820597
Merged the first commit as that was already clarified. As for the second
one the placement to either `streaming-core` or `streaming-contrib` is still
unclear. I moved
1 - 100 of 303 matches
Mail list logo
