[GitHub] flink issue #3192: [FLINK-1731][ml] Add KMeans clustering(Lloyd's algorithm)

2017-02-08 Thread sachingoel0101
Github user sachingoel0101 commented on the issue: https://github.com/apache/flink/pull/3192 @skonto I'm traveling right now and won't be able to push an update until Monday/Tuesday. On Feb 9, 2017 09:31, "Stavros Kontopoulos" <notificati...@github.c

[GitHub] flink pull request #3192: [FLINK-1731][ml] Add KMeans clustering(Lloyd's alg...

2017-01-31 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/3192#discussion_r98649636 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/clustering/KMeans.scala --- @@ -0,0 +1,263 @@ +/* + * Licensed

[GitHub] flink pull request #3192: [FLINK-1731][ml] Add KMeans clustering(Lloyd's alg...

2017-01-31 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/3192#discussion_r98649239 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/clustering/KMeans.scala --- @@ -0,0 +1,263 @@ +/* + * Licensed

[GitHub] flink issue #3192: [FLINK-1731][ml] Add KMeans clustering(Lloyd's algorithm)

2017-01-30 Thread sachingoel0101
Github user sachingoel0101 commented on the issue: https://github.com/apache/flink/pull/3192 Just fyi, that is not an example of the usage of machine learning library. It is just a standalone implementation of the linear regression model. --- If your project is set up for it, you

[GitHub] flink issue #3192: [FLINK-1731][ml] Add KMeans clustering(Lloyd's algorithm)

2017-01-30 Thread sachingoel0101
Github user sachingoel0101 commented on the issue: https://github.com/apache/flink/pull/3192 I'm not sure about adding examples under flink-examples project. None of the other ml algorithms are there either. Also, requires adding flink-ml as a dependency in the pom. I can however add

[GitHub] flink pull request #3192: [FLINK-1731][ml] Add KMeans clustering(Lloyd's alg...

2017-01-30 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/3192#discussion_r98471870 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/clustering/KMeans.scala --- @@ -0,0 +1,263 @@ +/* + * Licensed

[GitHub] flink issue #3192: [FLINK-1731][ml] Add KMeans clustering(Lloyd's algorithm)

2017-01-24 Thread sachingoel0101
Github user sachingoel0101 commented on the issue: https://github.com/apache/flink/pull/3192 /cc @skonto @thvasilo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink issue #757: [FLINK-2131][ml]: Initialization schemes for k-means clust...

2017-01-23 Thread sachingoel0101
Github user sachingoel0101 commented on the issue: https://github.com/apache/flink/pull/757 I have opened a PR https://github.com/apache/flink/pull/3192 as per the discussion here to add the Lloyd's algorithm first. Please review that first and then I will rebase this work on top

[GitHub] flink pull request #3192: [FLINK-1731][ml] Add KMeans clustering(Lloyd's alg...

2017-01-23 Thread sachingoel0101
GitHub user sachingoel0101 opened a pull request: https://github.com/apache/flink/pull/3192 [FLINK-1731][ml] Add KMeans clustering(Lloyd's algorithm) This is a breakoff from https://github.com/apache/flink/pull/757 to add the lloyd's algorithm first. I will follow this up

[GitHub] flink issue #757: [FLINK-2131][ml]: Initialization schemes for k-means clust...

2017-01-17 Thread sachingoel0101
Github user sachingoel0101 commented on the issue: https://github.com/apache/flink/pull/757 @skonto Been a bit busy. My apologies. I was working on this again some time back and would like to split this into two PRs. One for K means itself, another for adding initialization

[GitHub] flink pull request #3093: [FLINK-5444] Made Flink UI links relative.

2017-01-12 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/3093#discussion_r95749646 --- Diff: flink-runtime-web/web-dashboard/app/scripts/modules/submit/submit.ctrl.coffee --- @@ -167,7 +167,7 @@ angular.module('flinkApp

[GitHub] flink pull request #3093: [FLINK-5444] Made Flink UI links relative.

2017-01-12 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/3093#discussion_r95740581 --- Diff: flink-runtime-web/web-dashboard/app/scripts/modules/submit/submit.ctrl.coffee --- @@ -167,7 +167,7 @@ angular.module('flinkApp

[GitHub] flink issue #2941: [FLINK-3555] Web interface does not render job informatio...

2017-01-09 Thread sachingoel0101
Github user sachingoel0101 commented on the issue: https://github.com/apache/flink/pull/2941 Imo, the best way to achieve the change equivalent to the change to vendor.css file would be to add a new class, say, .panel-body-flowable in index.styl which defines the overflow rule

[GitHub] flink pull request #3070: [FLINK-5119][web-frontend] Fix problems in display...

2017-01-05 Thread sachingoel0101
GitHub user sachingoel0101 opened a pull request: https://github.com/apache/flink/pull/3070 [FLINK-5119][web-frontend] Fix problems in displaying TM heartbeat and path You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] flink pull request #3069: [FLINK-5381][web-frontend] Fix scrolling issues

2017-01-05 Thread sachingoel0101
GitHub user sachingoel0101 opened a pull request: https://github.com/apache/flink/pull/3069 [FLINK-5381][web-frontend] Fix scrolling issues This also fixes Flink-5359, Flink-5267. These should also be marked resolved. While working on this, I also observed scrolling issues

[GitHub] flink pull request #3055: [FLINK-5382][web-frontend] Fix problems with downl...

2017-01-04 Thread sachingoel0101
Github user sachingoel0101 closed the pull request at: https://github.com/apache/flink/pull/3055 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #3055: [FLINK-5382][web-frontend] Fix problems with downloading ...

2017-01-03 Thread sachingoel0101
Github user sachingoel0101 commented on the issue: https://github.com/apache/flink/pull/3055 Unrelated failures on travis. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request #3055: [FLINK-5382][web-frontend] Fix problems with downl...

2017-01-03 Thread sachingoel0101
GitHub user sachingoel0101 opened a pull request: https://github.com/apache/flink/pull/3055 [FLINK-5382][web-frontend] Fix problems with downloading TM logs on Yarn Handle transition URL relative to current page. You can merge this pull request into a Git repository by running

[GitHub] flink issue #757: [FLINK-2131][ml]: Initialization schemes for k-means clust...

2016-10-07 Thread sachingoel0101
Github user sachingoel0101 commented on the issue: https://github.com/apache/flink/pull/757 I'll update based on your comments in a few days. ^^ On Oct 8, 2016 06:21, "Stavros Kontopoulos" <notificati...@github.com> wrote: > @sachingoel0101

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2016-02-09 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1186#issuecomment-181772422 That said, just for a comparison purpose, spark has its own model export and import feature, along with pmml export. Hoping to fully support pmml import

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2016-02-09 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1186#issuecomment-181771679 As the original author of this PR, I'd say this: I tried implementing the import features but they aren't worth it. You have to discard most of the valid

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2016-02-09 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1186#issuecomment-181798643 That is a good point. In streaming setting, it does indeed make sense for the model to be available. However, in my opinion, then it would make sense to actually

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2016-02-09 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1186#issuecomment-181803637 I'm all for that. Flink's models should be transferable at least across flink. But that should be part of a separate PR, and not block this one as it has been

[GitHub] flink pull request: [FLINK-2928][web-dashboard] Fix confusing job ...

2016-01-04 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1421#issuecomment-168634287 Hi @StephanEwen, apologies for the delayed response. Unfortunately, I haven't been able to work on Flink recently as I've just moved abroad. I've also just

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-12-18 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1338#issuecomment-165744791 @StephanEwen can you have a look at this again? Apologies for being hasty, but I've already addressed all concerns; this should be mergeable now. --- If your

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-12-18 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1338#issuecomment-165754941 Olrite. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-12-14 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1338#issuecomment-164384200 @StephanEwen, @rmetzger. Ping. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request: [FLINK-2769] [runtime-web] Add configurable jo...

2015-12-10 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1449#issuecomment-163866658 Tested it out locally. Works well with `gulp watch` and custom web frontend port. A few things I noticed: 1. Job Manager's log and stdout

[GitHub] flink pull request: [FLINK-3023][web-dashboard] Display version an...

2015-12-09 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/1422#discussion_r47076123 --- Diff: flink-runtime-web/web-dashboard/app/partials/overview.jade --- @@ -22,6 +22,12 @@ nav.navbar.navbar-default.navbar-fixed-top.navbar-main

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-12-09 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1338#issuecomment-163188173 Hi @StephanEwen, I have modified the signature of the `handleRequest` method to separate path and query parameters. If there are any more concerns, let me

[GitHub] flink pull request: [FLINK-3023][web-dashboard] Display version an...

2015-12-09 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1422#issuecomment-163200275 Olrite. Great! #1418 should also be meregable with this one IMO. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-3077][cli] Add version option to Cli.

2015-12-07 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1418#issuecomment-162796587 Ping. Also, what is the procedure for creating a release artifact locally[without GPG keys, Apache id, etc.] so I can check that this works okay for those too

[GitHub] flink pull request: [FLINK-2928][web-dashboard] Fix confusing job ...

2015-12-07 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1421#issuecomment-162796105 That sounds great. @iampeter thanks for the suggestion. :) I will see if I can update the PR today. --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-2379][ml]Add column wise statistics for...

2015-12-07 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1032#issuecomment-162550968 Hi @chiwanpark, thanks for picking this up. :) Since a `Vector` might contain discrete fields as well as continuous fields, we need to have a `FieldStats

[GitHub] flink pull request: [FLINK-2488] Expose Attempt Number in RuntimeC...

2015-12-07 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1386#issuecomment-162463009 Travis passes. Should be good to merge. This also resolves FLINK-2524, so the commit message should reflect that too. --- If your project is set up

[GitHub] flink pull request: [FLINK-2488] Expose Attempt Number in RuntimeC...

2015-12-06 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1386#issuecomment-162325866 @StephanEwen can you take a look again? I have introduced the `TaskInfo` object in the second commit, and we can squash them before merging. --- If your project

[GitHub] flink pull request: [FLINK-2488] Expose Attempt Number in RuntimeC...

2015-12-06 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1386#issuecomment-162345554 @StephanEwen thanks for the review. I have addressed all but one of your comments. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-12-06 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1338#issuecomment-162340095 @rmetzger thanks. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-2488] Expose Attempt Number in RuntimeC...

2015-12-06 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/1386#discussion_r46775517 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/BatchTask.java --- @@ -1150,8 +1149,8 @@ else if (index < 0 || in

[GitHub] flink pull request: [FLINK-3023][web-dashboard] Display version an...

2015-12-06 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/1422#discussion_r46774718 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ClusterOverviewHandler.java --- @@ -63,6 +67,10 @@ public

[GitHub] flink pull request: [FLINK-2928][web-dashboard] Fix confusing job ...

2015-12-06 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1421#issuecomment-162341452 Makes sense. Lemme figure something out here, and I will post an update in a day or two. --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: [FLINK-2928][web-dashboard] Fix confusing job ...

2015-12-05 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1421#issuecomment-162207406 I'm not very sure about this. Displaying two rows doesn't look good at all. Maybe @iampeter has a better suggestion here. --- If your project is set up

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-12-05 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/1338#discussion_r46759219 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -302,6 +302,15 @@ */ public static

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-12-05 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/1338#discussion_r46760092 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -302,6 +302,15 @@ */ public static

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-12-05 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1338#issuecomment-162224088 Hi @rmetzger, can you test this on a cluster again? @StephanEwen can we discuss your concerns about this? I would like to quickly get this merged after

[GitHub] flink pull request: [FLINK-3077][cli] Add version option to Cli.

2015-12-04 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1418#issuecomment-161910704 I have made the required changes. @StephanEwen can you take a look again? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: [FLINK-2488] Expose Attempt Number in RuntimeC...

2015-12-04 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1386#issuecomment-161921756 @StephanEwen you're absolutely right. It will most certainly do that. I will push both things in a single commit and file an additional jira for introducing

[GitHub] flink pull request: [FLINK-3023][web-dashboard] Display version an...

2015-12-04 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1422#issuecomment-161914994 Addressed null commit ids. If the commit id is not available, only version will be displayed. --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: [FLINK-3077][cli] Add version option to Cli.

2015-12-02 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1418#issuecomment-161339112 Makes sense. I will address it as per Stephan's comments. I won't be able to get to it till this weekend though as I'm on vacation. On Dec 2, 2015 8:04 PM

[GitHub] flink pull request: [FLINK-2488] Expose Attempt Number in RuntimeC...

2015-12-02 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1386#issuecomment-161449824 Yes. I was planning to start working on that after this. Since it's preferable to fix different jiras in different commits, it'd be good if I can base my

[GitHub] flink pull request: [FLINK-2928][web-dashboard] Fix confusing job ...

2015-11-30 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1421#issuecomment-160743609 The presence of job id was leading to the cancel button disappearing sometimes due to lack of space which is something very important. I considered a two row

[GitHub] flink pull request: [FLINK-3077][cli] Add version option to Cli.

2015-11-30 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1418#issuecomment-160744724 Do I need to address this? Perhaps we can check if the commit id is null and not print it in such a case? --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-2399] Version checks for Job Manager an...

2015-11-29 Thread sachingoel0101
Github user sachingoel0101 closed the pull request at: https://github.com/apache/flink/pull/945 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-2399] Version checks for Job Manager an...

2015-11-29 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/945#issuecomment-160431771 Un-assigning myself from the issue for now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: [FLINK-3077] Add functions to access Flink Ver...

2015-11-29 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/1418#discussion_r46093211 --- Diff: flink-core/src/main/java/org/apache/flink/util/VersionUtils.java --- @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software

[GitHub] flink pull request: [FLINK-3023][web-dashboard] Display version an...

2015-11-29 Thread sachingoel0101
GitHub user sachingoel0101 opened a pull request: https://github.com/apache/flink/pull/1422 [FLINK-3023][web-dashboard] Display version and commit information on Overview Page. You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] flink pull request: [FLINK-3077][cli] Add version option to Cli.

2015-11-29 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1418#issuecomment-160422689 @rmetzger I have split this PR to separate the Web dashboard specific work into another PR #1422 --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-2030][FLINK-2274][core][utils]Histogram...

2015-11-29 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/861#issuecomment-160428072 Ping! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-3077][cli] Add version option to Cli.

2015-11-28 Thread sachingoel0101
GitHub user sachingoel0101 opened a pull request: https://github.com/apache/flink/pull/1418 [FLINK-3077][cli] Add version option to Cli. Adds a version option (-v, --version) to the Cli, which prints the implementation version and the git commit for the build. You can merge

[GitHub] flink pull request: [FLINK-3056][web-dashboard] Represent bytes in...

2015-11-28 Thread sachingoel0101
GitHub user sachingoel0101 opened a pull request: https://github.com/apache/flink/pull/1419 [FLINK-3056][web-dashboard] Represent bytes in more readable form. Bytes are now displayed in the following fashion: 1. For [0, 1000) units, display three significant digits. 2

[GitHub] flink pull request: [FLINK-2928][web-dashboard] Fix confusing job ...

2015-11-28 Thread sachingoel0101
GitHub user sachingoel0101 opened a pull request: https://github.com/apache/flink/pull/1421 [FLINK-2928][web-dashboard] Fix confusing job status visualization in job overview. You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] flink pull request: [FLINK-3077] Add functions to access Flink Ver...

2015-11-28 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1418#issuecomment-160311838 Also, resolves FLINK-3056. ![capture10](https://cloud.githubusercontent.com/assets/8874261/11452591/aa9f5dae-9613-11e5-9546-d862f29cfd3c.PNG) --- If your

[GitHub] flink pull request: [FLINK-3077] Add functions to access Flink Ver...

2015-11-28 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1418#issuecomment-160312062 Also resolves FLINK-3023. ![capture10](https://cloud.githubusercontent.com/assets/8874261/11452593/d80811aa-9613-11e5-9c1e-c5fe6c61adc8.PNG) --- If your

[GitHub] flink pull request: [FLINK-2488] Expose Attempt Number in RuntimeC...

2015-11-26 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1386#issuecomment-159853758 I'll wait for Stephan to review this then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: [FLINK-2904][web-dashboard] Fix truncation of ...

2015-11-25 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1321#issuecomment-159655565 Hi @mxm, is there any further improvement needed on this? If not, I think it should be merged. --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: [FLINK-2488] Expose Attempt Number in RuntimeC...

2015-11-25 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1386#issuecomment-159656251 Hi @rmetzger, can you take another look? I need to base some further work on this [related to cleaning up passing of task name, index, etc.]. --- If your

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-11-23 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r45640613 --- Diff: flink-runtime-web/web-dashboard/app/partials/jobs/job.jade --- @@ -43,6 +43,10 @@ nav.navbar.navbar-default.navbar-fixed-top.navbar-main(ng

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-11-23 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r45639014 --- Diff: flink-runtime-web/web-dashboard/app/partials/jobs/job.jade --- @@ -43,6 +43,10 @@ nav.navbar.navbar-default.navbar-fixed-top.navbar-main(ng

[GitHub] flink pull request: [FLINK-3000]Adds shutdown hook to clean up lin...

2015-11-23 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1354#issuecomment-159054302 Ping. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-11-23 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r45634054 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java --- @@ -188,9 +189,12 @@ public WebRuntimeMonitor

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-11-23 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r45635941 --- Diff: flink-runtime-web/web-dashboard/web/partials/jobs/job.html --- @@ -32,7 +32,7 @@ - {{ job['end-time'] | amDateFormat

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-11-23 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r45636371 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java --- @@ -188,9 +189,12 @@ public WebRuntimeMonitor

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-11-23 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r45634227 --- Diff: flink-runtime-web/web-dashboard/app/partials/jobs/job.jade --- @@ -43,6 +43,10 @@ nav.navbar.navbar-default.navbar-fixed-top.navbar-main(ng

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-11-23 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r45634353 --- Diff: flink-runtime-web/web-dashboard/app/scripts/modules/jobs/jobs.svc.coffee --- @@ -216,4 +216,7 @@ angular.module('flinkApp') # proper

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-22 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1338#issuecomment-158765098 @rmetzger 1. I have introduced a separate directory for uploads, named randomly, and deleted as part of the shut down hook. 2. I also tried closing

[GitHub] flink pull request: [FLINK-2488] Expose Attempt Number in RuntimeC...

2015-11-20 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1386#issuecomment-158408532 @rmetzger I have added a test case to verify the functionality. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-19 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/1338#discussion_r45317406 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -635,8 +644,18 @@ * The default number

[GitHub] flink pull request: [FLINK-2488] Expose Attempt Number in RuntimeC...

2015-11-19 Thread sachingoel0101
GitHub user sachingoel0101 opened a pull request: https://github.com/apache/flink/pull/1386 [FLINK-2488] Expose Attempt Number in RuntimeContext Passes the attempt number all the way from `TaskDeploymentDescriptor` to the `RuntimeContext`. Small thing I want to confirm

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-18 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/1338#discussion_r45240771 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/HttpRequestHandler.java --- @@ -0,0 +1,131 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-11-18 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-157817216 Hi @mjsax , your change to coffeescript aren't ported to the actual javascript. It appears you forgot to run `gulp`. --- If your project is set up for it, you

[GitHub] flink pull request: [FLINK-2488][FLINK-2496] Expose Task Manager c...

2015-11-18 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1026#issuecomment-157818292 Yes. That's why I closed it. :') I'm thinking of having a construct named `TaskInfo`, which contains information like name, index, parallel tasks, attempt

[GitHub] flink pull request: [FLINK-2488][FLINK-2496] Expose Task Manager c...

2015-11-18 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1026#issuecomment-157826454 Agreed. I also would like to cleanup the several getter functions for these fields. We can just add a `getTaskInfo` in the `TDD`, `Task` and `Environment

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-18 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/1338#discussion_r45245432 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/HttpRequestHandler.java --- @@ -0,0 +1,131 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-17 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/1338#discussion_r45091056 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/PipelineErrorHandler.java --- @@ -0,0 +1,79 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-17 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/1338#discussion_r45090748 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarDeleteHandler.java --- @@ -0,0 +1,70

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-17 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/1338#discussion_r45091186 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarListHandler.java --- @@ -0,0 +1,130

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-17 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/1338#discussion_r45090990 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -635,8 +644,18 @@ * The default number

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-17 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/1338#discussion_r45094279 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarListHandler.java --- @@ -0,0 +1,130

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-17 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/1338#discussion_r45095325 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarDeleteHandler.java --- @@ -0,0 +1,70

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-17 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/1338#discussion_r45101828 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/RuntimeMonitorHandler.java --- @@ -113,7 +117,17 @@ private void

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-17 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/1338#discussion_r45101180 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -635,8 +644,18 @@ * The default number

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-17 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/1338#discussion_r45103208 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -302,6 +302,15 @@ */ public static

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-17 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/1338#discussion_r45103312 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/HttpRequestHandler.java --- @@ -0,0 +1,131 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-17 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/1338#discussion_r45104323 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/RuntimeMonitorHandler.java --- @@ -113,7 +117,17 @@ private void

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-17 Thread sachingoel0101
Github user sachingoel0101 commented on a diff in the pull request: https://github.com/apache/flink/pull/1338#discussion_r45104595 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarActionHandler.java --- @@ -0,0 +1,253

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-16 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1338#issuecomment-157056790 @gyfora this is the PR I was talking about regarding your *connection reset* exception. If you want, you can add the `PipelineErrorHandler` at the end of current

[GitHub] flink pull request: [FLINK-3000]Adds shutdown hook to clean up lin...

2015-11-14 Thread sachingoel0101
GitHub user sachingoel0101 opened a pull request: https://github.com/apache/flink/pull/1354 [FLINK-3000]Adds shutdown hook to clean up lingering yarn sessions Adds a shutdown hook to cleanup the submitted yarn application while the user cancels it in any but a `RUNNING` state

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-13 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1338#issuecomment-156475956 Hi @rmetzger , are you sure you built the source with scala 2.11? I was getting the same error you showed here, but building with scala 2.11 fixes

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-13 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1338#issuecomment-156483602 Yes. Except for the trace leading up to the handler, I think rest should be okay to show. In case the exception isn't`ProgramInvocationException

[GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...

2015-11-13 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1338#issuecomment-156477959 Yes. I will write some better exception reporting. As for this particular error, how can it be detected? From what I observed, ideally, `Client

  1   2   3   4   5   6   >