[GitHub] flink pull request: [FLINK-1297] Added OperatorStatsAccumulator fo...

2015-09-09 Thread tammymendt
Github user tammymendt commented on the pull request: https://github.com/apache/flink/pull/605#issuecomment-138895774 Yes, I'm on it On Wed, Sep 9, 2015 at 2:34 PM, Max <notificati...@github.com> wrote: > Could you update the pull request with the new clone

[GitHub] flink pull request: [FLINK-1297] Added OperatorStatsAccumulator fo...

2015-09-09 Thread tammymendt
Github user tammymendt commented on the pull request: https://github.com/apache/flink/pull/605#issuecomment-138883419 The test I wrote checks if the final accumulator result is the one that is expected. If I understand correctly, now accumulator values are sent periodically before

[GitHub] flink pull request: [FLINK-1297] Added OperatorStatsAccumulator fo...

2015-09-09 Thread tammymendt
Github user tammymendt commented on the pull request: https://github.com/apache/flink/pull/605#issuecomment-138852658 I can have a look at it this afternoon. I suspect it might be because the function getAllAccumulators has been deprecated. On Sep 9, 2015 11:11 AM, "F

[GitHub] flink pull request: [FLINK-1297] Added OperatorStatsAccumulator fo...

2015-09-09 Thread tammymendt
Github user tammymendt commented on the pull request: https://github.com/apache/flink/pull/605#issuecomment-138906837 I rebased with master and included the new clone() method. I had to include extra conditionals that check whether count distinct or heavy hitters are being tracked

[GitHub] flink pull request: [FLINK-2567]

2015-08-26 Thread tammymendt
GitHub user tammymendt opened a pull request: https://github.com/apache/flink/pull/1059 [FLINK-2567] Allow quoted strings in CSV fields to contain quotation character inside of the field, as long as its escaped Ex: 'Hi my name is \'Flink\' '. If a quotation character is found

[GitHub] flink pull request: [FLINK-1297] Added OperatorStatsAccumulator fo...

2015-08-05 Thread tammymendt
Github user tammymendt commented on the pull request: https://github.com/apache/flink/pull/605#issuecomment-127923972 I will maintain the code. Though I am not committing other code to Flink, I am responsible for what I coded and will not bail as soon as it is merged. I think

[GitHub] flink pull request: [FLINK-1297] Added OperatorStatsAccumulator fo...

2015-08-04 Thread tammymendt
Github user tammymendt commented on the pull request: https://github.com/apache/flink/pull/605#issuecomment-127519735 Hey! So I've been using and testing this code throughout my master thesis. Collecting count distinct makes jobs about 10% slower whereas collecting heavy hitters can

[GitHub] flink pull request: [FLINK-1297] Added OperatorStatsAccumulator fo...

2015-06-10 Thread tammymendt
Github user tammymendt commented on the pull request: https://github.com/apache/flink/pull/605#issuecomment-110702228 Everything seems to be OK now. Is there still a chance to merge this before the upcoming release? I have pushed two commits. The first is the original version

[GitHub] flink pull request: [FLINK-1297] Added OperatorStatsAccumulator fo...

2015-06-10 Thread tammymendt
Github user tammymendt commented on the pull request: https://github.com/apache/flink/pull/605#issuecomment-110720993 Sounds good! Thanks =) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-1297] Added OperatorStatsAccumulator fo...

2015-06-08 Thread tammymendt
Github user tammymendt commented on the pull request: https://github.com/apache/flink/pull/605#issuecomment-109990676 Hey! So I solved the NullPointer and as far as I can see it is not bothering any more. Given the non-deterministic nature of the algorithms, some tests fail

[GitHub] flink pull request: [FLINK-1297] Added OperatorStatsAccumulator fo...

2015-06-06 Thread tammymendt
Github user tammymendt commented on the pull request: https://github.com/apache/flink/pull/605#issuecomment-109537258 Ok, I will check this out today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-2059] Changed flink-compiler to flink-o...

2015-05-20 Thread tammymendt
GitHub user tammymendt opened a pull request: https://github.com/apache/flink/pull/701 [FLINK-2059] Changed flink-compiler to flink-optimizer in the pom.xml You can merge this pull request into a Git repository by running: $ git pull https://github.com/tammymendt/flink FLINK

[GitHub] flink pull request: [FLINK-1297] Added OperatorStatsAccumulator fo...

2015-04-21 Thread tammymendt
Github user tammymendt commented on a diff in the pull request: https://github.com/apache/flink/pull/605#discussion_r28776656 --- Diff: flink-core/src/main/java/org/apache/flink/statistics/OperatorStatistics.java --- @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1297] Added OperatorStatsAccumulator fo...

2015-04-21 Thread tammymendt
Github user tammymendt commented on a diff in the pull request: https://github.com/apache/flink/pull/605#discussion_r28789034 --- Diff: flink-contrib/src/test/java/org/apache/flink/contrib/operatorstatistics/OperatorStatsAccumulatorsTest.java --- @@ -0,0 +1,144

[GitHub] flink pull request: [FLINK-1297] Added OperatorStatsAccumulator fo...

2015-04-17 Thread tammymendt
Github user tammymendt commented on a diff in the pull request: https://github.com/apache/flink/pull/605#discussion_r28593077 --- Diff: flink-core/pom.xml --- @@ -63,6 +63,19 @@ under the License. artifactIdguava/artifactId version

[GitHub] flink pull request: [FLINK-1297] Added OperatorStatsAccumulator fo...

2015-04-16 Thread tammymendt
GitHub user tammymendt opened a pull request: https://github.com/apache/flink/pull/605 [FLINK-1297] Added OperatorStatsAccumulator for tracking operator related stats The accumulator tracks min and max values, and estimates for count distinct and heavy hitters. The count