Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6401
Thanks for your contribution @rileyli. Even though this change seems rather
trivial I would like to discourage these kind of contributions. The problem is
that it does not add much additional
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6398
Thanks for the review @zentol. Merging this PR.
---
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6398
Given that the `WatermarkGauge` is not super critical, I'm ok with changing
it to a `volatile long`. If the `OneInputStreamTask` should fail again with a
similar problem, then we know
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6398
I got this from an IntelliJ inspection warning which says
>Reports fields of type long or double which are declared as volatile.
While Java specifies that reads and writes from such fie
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/6398
[FLINK-9923][tests] Harden OneInputStreamTaskTest#testWatermarkMetrics
## What is the purpose of the change
Convert the WatermarkGauge's field currentWatermark from long to AtomicLong
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6373
Thanks for the review @yanghua and @bowenli86. Merging this PR.
---
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6386
Thanks for the review @GJL. I've addressed your comments. Once Travis gives
green light, I'll merge this PR.
---
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6386#discussion_r204435941
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphSchedulingTest.java
---
@@ -504,6 +512,107 @@ public void
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6386#discussion_r204435027
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphSchedulingTest.java
---
@@ -504,6 +512,107 @@ public void
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6386#discussion_r204434452
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java
---
@@ -323,7 +323,7 @@ public void
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/6394
[FLINK-9912][JM] Release TaskExecutors if they have no slots registered at
SlotPool
## What is the purpose of the change
This commit extends the SlotPools behaviour when failing
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/6389
[FLINK-9917][JM] Remove superfluous lock from SlotSharingManager
## What is the purpose of the change
The SlotSharingManager is designed to be used by a single thread. Therefore
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/6386
[FLINK-9911][JM] Use SlotPoolGateway to call failAllocation
## What is the purpose of the change
Since the SlotPool is an actor, we must use the SlotPoolGateway to interact
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/6385
[FLINK-9910][scheduling] Execution#scheduleForeExecution does not cancel
slot future
## What is the purpose of the change
In order to properly give back an allocated slot
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/6384
Remove conjunct future cancellation
## What is the purpose of the change
If a ConjunctFuture is cancelled, then it won't cancel all of its input
futures automatically. If the users
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/6383
[FLINK-9908][scheduling] Do not cancel individual scheduling future
## What is the purpose of the change
Since the individual scheduling futures contain logic to release the slot
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6357
Hi @liurenjie1024, thanks for opening this PR. The Flink community is
currently preparing the Flink 1.6 release and, thus, it might take a bit longer
for the review to happen. Please bear
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/6373
[FLINK-9838][logging] Don't log slot request failures on the ResourceManager
## What is the purpose of the change
Decrease log cluttering by not logging slot request failures
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6342#discussion_r203626668
--- Diff: tools/releasing/create_binary_release.sh ---
@@ -44,6 +44,12 @@ else
SHASUM="sha512sum"
fi
+cd ..
+
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5894#discussion_r203368063
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PrioritizedOperatorSubtaskState.java
---
@@ -281,10 +281,15 @@ public
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6330#discussion_r203365784
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandler.java
---
@@ -138,12 +154,22 @@ public
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6322
No worries @Wosin. I've already fixed the problem.
---
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6334
Thanks for opening this PR @yanghua. The community is currently preparing
the Flink 1.6 release. Due to this, it might take a bit longer until someone
can review this PR. Please bear with us
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6352
Interesting. I thought I would have executed `flink-yarn-tests` locally
with all tests. But it looks as if `YARNHighAvailabilityITCase` suffers from
the same problem
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6344#discussion_r203360721
--- Diff: flink-dist/src/main/flink-bin/bin/standalone-job.sh ---
@@ -56,7 +56,7 @@ if [[ $STARTSTOP == "start" ]] || [[ $STARTSTOP
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6330#discussion_r203359445
--- Diff:
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandlerParameterTest.java
---
@@ -0,0 +1,313
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6330#discussion_r203358033
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandler.java
---
@@ -138,12 +154,22 @@ public
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6345
Thanks for opening this PR @tison1. The Flink community is currently
preparing the Flink 1.6 release and, thus, it could take a bit longer until
someone reviews your PR. Please bear with us
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5801#discussion_r203352693
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java ---
@@ -49,30 +54,45 @@ public YarnClusterDescriptor
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6352
The failing test case seems to be caused by
`YARNSessionFIFOITCase#testJavaAPI` not calling `yarnCluster.shutdownCluster`.
I've fixed this problem in master and the release branch. Rebasing
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6352#discussion_r203293425
--- Diff:
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java ---
@@ -186,39 +189,56 @@ public static void
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6330#discussion_r203288895
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarRunRequestBody.java
---
@@ -0,0 +1,109
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6330#discussion_r203288959
--- Diff:
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandlerParameterTest.java
---
@@ -0,0 +1,313
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6330#discussion_r203287485
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandler.java
---
@@ -138,12 +154,22 @@ public
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6330#discussion_r203291791
--- Diff:
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandlerParameterTest.java
---
@@ -0,0 +1,313
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6344#discussion_r203284749
--- Diff: flink-dist/src/main/flink-bin/bin/standalone-job.sh ---
@@ -56,7 +56,7 @@ if [[ $STARTSTOP == "start" ]] || [[ $STARTSTOP
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6311#discussion_r203273357
--- Diff:
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarSubmissionITCase.java
---
@@ -0,0 +1,225
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202589096
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/CachingInternalPriorityQueueSet.java
---
@@ -80,13 +82,57 @@ public E peek
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6327
@NicoK #6326 has been merged into master. Please rebase this PR.
---
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202552616
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/PriorityComparable.java
---
@@ -0,0 +1,35 @@
+/*
+ * Licensed
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202552483
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyExtractorFunction.java
---
@@ -28,9 +28,22 @@
@FunctionalInterface
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202553765
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java
---
@@ -342,16 +379,20 @@ private void
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202553358
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/TieBreakingPriorityComparator.java
---
@@ -85,10 +85,10 @@ public int compare(T
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202552563
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyGroupPartitioner.java
---
@@ -264,6 +265,42 @@ public void
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202553887
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java
---
@@ -446,8 +485,10 @@ public String toString
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202552705
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/RegisteredBroadcastStateBackendMetaInfo.java
---
@@ -24,37 +24,46 @@
import
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202553524
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/CachingInternalPriorityQueueSet.java
---
@@ -80,13 +82,57 @@ public E peek
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202552876
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/RegisteredBroadcastStateBackendMetaInfo.java
---
@@ -63,54 +72,46 @@ public
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202553958
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapPriorityQueueStateSnapshot.java
---
@@ -60,36 +61,35
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6320
Thanks for the review @GJL. I've addressed your comments. Merging this PR.
---
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6320#discussion_r202390083
--- Diff: flink-container/docker/build.sh ---
@@ -0,0 +1,128 @@
+#!/bin/sh
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6320#discussion_r202376970
--- Diff: flink-container/docker/README.md ---
@@ -0,0 +1,44 @@
+# Apache Flink cluster deployment on docker using docker-compose
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6320#discussion_r202376612
--- Diff: flink-container/docker/README.md ---
@@ -0,0 +1,44 @@
+# Apache Flink cluster deployment on docker using docker-compose
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6320#discussion_r202376520
--- Diff: flink-container/pom.xml ---
@@ -0,0 +1,67 @@
+
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6320#discussion_r202376168
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterConfiguration.java
---
@@ -18,27 +18,43 @@
package
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6320#discussion_r202375386
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/entrypoint/EntrypointClusterConfigurationParserFactoryTest.java
---
@@ -0,0 +1,84
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6320#discussion_r202373877
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/entrypoint/EntrypointClusterConfigurationParserFactoryTest.java
---
@@ -0,0 +1,84
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6319#discussion_r202371742
--- Diff: flink-container/docker/build.sh ---
@@ -0,0 +1,118 @@
+#!/bin/sh
--- End diff --
Good point. I will correct it.
---
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6283
Alright, I think I fetched the last commit as well. Once Travis gives green
light, I'll merge it.
---
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6283#discussion_r202333518
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
---
@@ -567,22 +560,16 @@ private
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6283#discussion_r202297327
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/restart/RestartStrategyFactory.java
---
@@ -149,7 +149,7 @@ public
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6283#discussion_r202298725
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterTest.java
---
@@ -357,6 +362,42 @@ public void
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6283#discussion_r202297182
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/restart/NoOrFixedIfCheckpointingEnabledRestartStrategy.java
---
@@ -0,0
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6283#discussion_r202304777
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java ---
@@ -339,12 +339,28 @@ public void
setSnapshotSettings
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6103
With [FLINK-5129](https://issues.apache.org/jira/browse/FLINK-5129) which
is part of Flink 1.3.0, we allow the `BlobCache` to retrieve the blobs from the
HA storage location. In your case
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6240
Nice, thank you. Merging this PR.
---
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/5375
Sorry for not getting back to you earlier @zhangminglei. I accidentally
addressed this issue with #6318. I think we can therefore close this PR.
Sorry for the bad PR management
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6319#discussion_r202254368
--- Diff: flink-container/docker/README.md ---
@@ -0,0 +1,44 @@
+# Apache Flink cluster deployment on docker using docker-compose
--- End diff
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6319#discussion_r202254410
--- Diff: flink-container/docker/README.md ---
@@ -0,0 +1,44 @@
+# Apache Flink cluster deployment on docker using docker-compose
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6305#discussion_r202249510
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/EventTimeWindowCheckpointingITCase.java
---
@@ -99,11 +110,21
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/5954
I think this is not super critical and since we only pass in `Exceptions`
at the moment I would say let's close this PR.
---
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6322#discussion_r202248523
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1759,11 +1759,22 @@ class JobManager
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6322#discussion_r202248449
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1759,11 +1759,22 @@ class JobManager
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6322#discussion_r202248365
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1759,11 +1759,22 @@ class JobManager
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6288#discussion_r202171601
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -332,6 +334,22 @@ public String
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6283#discussion_r202103545
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CoordinatorShutdownTest.java
---
@@ -83,6 +86,10 @@ public void
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6103
@RalphSu you could try increasing the
`taskmanager.network.request-backoff.max` configuration parameter. Per default
it is set to `1` ms.
---
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6284#discussion_r202075077
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java ---
@@ -181,12 +181,17 @@
* The config parameter defining
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6284#discussion_r202086059
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java ---
@@ -181,12 +181,17 @@
* The config parameter defining
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6284#discussion_r202087570
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java
---
@@ -250,6 +250,10 @@ public static
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6284#discussion_r202090987
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
@@ -473,8 +474,13 @@ private ContainerLaunchContext
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6284#discussion_r202082557
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java
---
@@ -467,4 +471,22 @@ public static String
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6284#discussion_r202084291
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java
---
@@ -467,4 +471,22 @@ public static String
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6284#discussion_r202087890
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
@@ -473,8 +474,13 @@ private ContainerLaunchContext
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6284#discussion_r202087987
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
@@ -473,8 +474,13 @@ private ContainerLaunchContext
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6283#discussion_r202065050
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/restart/RestartStrategyResolvingTest.java
---
@@ -0,0 +1,72
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6283#discussion_r202065356
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/restart/RestartStrategyResolvingTest.java
---
@@ -0,0 +1,72
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6283#discussion_r202070020
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/RestartStrategyTest.java
---
@@ -33,12 +33,11 @@
public class
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6283#discussion_r202070710
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CoordinatorShutdownTest.java
---
@@ -83,6 +86,10 @@ public void
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6283#discussion_r202013103
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/restart/RestartStrategyResolving.java
---
@@ -0,0 +1,74
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6283#discussion_r202071547
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/restart/RestartStrategyResolving.java
---
@@ -0,0 +1,74
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6283#discussion_r202012704
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/restart/RestartStrategyResolving.java
---
@@ -0,0 +1,74
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/5954
Thanks for opening this PR @yanghua and sorry for my late reply.
I think we accidentally addressed this problem already with another PR
(#6202). This was an oversight because you
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6266
I would be ok with splitting the work between the backend and frontend work.
@zentol raised an important point which is where to place the content. Wha
about the following proposal
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6279
Thanks for the review @GJL. Merging this PR.
---
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6279#discussion_r201869163
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
@@ -536,7 +540,25 @@ private JobManagerRunner
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/6320
[FLINK-9823] Add Kubernetes deployment ymls
## What is the purpose of the change
The Kubernetes files contain a job-cluster service specification, a job
specification
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/6319
[FLINK-9822] Add Dockerfile for StandaloneJobClusterEntryPoint image
## What is the purpose of the change
This commit adds a Dockerfile for a standalone job cluster image. The image
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/6318
[FLINK-9821] Forward dynamic properties to configuration in
TaskManagerRunner
## What is the purpose of the change
With this commit we can use dynamic properties to overwrite
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/6317
[FLINK-9820] Forward dynamic properties to Flink configuration in
ClusterEntrypoint
## What is the purpose of the change
With this commit we can use dynamic properties to overwrite
1 - 100 of 6303 matches
Mail list logo
