[jira] [Commented] (FLINK-2127) The GSA Documentation has trailing /p s

2015-07-27 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14642411#comment-14642411 ] Vasia Kalavri commented on FLINK-2127: -- Is this one still a problem? The GSA

[jira] [Commented] (FLINK-2163) VertexCentricConfigurationITCase sometimes fails on Travis

2015-07-27 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14642410#comment-14642410 ] Vasia Kalavri commented on FLINK-2163: -- I will mark this as resolved. We haven't seen

[jira] [Resolved] (FLINK-2163) VertexCentricConfigurationITCase sometimes fails on Travis

2015-07-27 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri resolved FLINK-2163. -- Resolution: Fixed Fix Version/s: 0.10 VertexCentricConfigurationITCase sometimes fails

[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API

2015-07-27 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/808#issuecomment-125112165 Hey @PieterJanVanAeken! Are you back working on this or would you rather someone else takes over? I think I can find some time next week to resolve remaining issues

[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API

2015-07-27 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/808#issuecomment-125132370 Perfect, thanks @PieterJanVanAeken! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-2375] Add Approximate Adamic Adar Simil...

2015-07-21 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/923#issuecomment-123394302 Hi @shghatge! The comments I left on #892 apply here as well. The difference would be that the neighborhoods of each of the neighbors will be represented

[GitHub] flink pull request: [FLINK-2310] Add an Adamic Adar Similarity exa...

2015-07-21 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/892#issuecomment-123236061 Hi @shghatge, let me try to explain the implementation in detail here :) First of all, can you change this to a library method instead of an example

[jira] [Commented] (FLINK-2361) flatMap + distinct gives erroneous results for big data sets

2015-07-15 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627773#comment-14627773 ] Vasia Kalavri commented on FLINK-2361: -- Hey, I have seen this exception before and I

[GitHub] flink pull request: [FLINK-1943] [gelly] Added GSA compiler and tr...

2015-07-15 Thread vasia
GitHub user vasia opened a pull request: https://github.com/apache/flink/pull/916 [FLINK-1943] [gelly] Added GSA compiler and translation tests Thanks @StephanEwen for the help! You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-07-14 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/847#issuecomment-121215586 yes, I mean `NullValue.class` :) I'd like to know @shghatge's opinion, too! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-07-13 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/847#issuecomment-121025189 Hi @andralungu, do you mean support for POJOs as vertex / edge values? I guess that's a limitation we can't easily overcome, I agree. Still though, a nicely

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-07-13 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/847#issuecomment-121033796 I hadn't realized that they would both need to be called in my previous comment, my bad. Any idea for decent method names? `typesNoEdgeValue` and `typesNoVertexValue

[GitHub] flink pull request: [FLINK-2310] Add an Adamic Adar Similarity exa...

2015-07-10 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/892#issuecomment-120319905 Hi @shghatge! I agree, let's deal with the approximate version as a separate issue. In the end though, it would be nice to have a single library method

[GitHub] flink pull request: [FLINK-2310] Add an Adamic Adar Similarity exa...

2015-07-08 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/892#discussion_r34204894 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/AdamicAdarSimilarityMeasure.java --- @@ -0,0 +1,249

[GitHub] flink pull request: [FLINK-2310] Add an Adamic Adar Similarity exa...

2015-07-08 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/892#issuecomment-119750756 Hi @shghatge, thank you for working on this! It's not a trivial problem :) I have two general comments: - I would prefer to see this as library method

[jira] [Assigned] (FLINK-1943) Add Gelly-GSA compiler and translation tests

2015-07-07 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri reassigned FLINK-1943: Assignee: Vasia Kalavri Add Gelly-GSA compiler and translation tests

[GitHub] flink pull request: [FLINK-2141] Allow GSA's Gather to perform thi...

2015-07-06 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/877#issuecomment-118912040 Hi @shghatge, @andralungu! I left one comment that I think is quite serious. Apart from that, I had also left a minor comment on the gelly-guide changes in the last

[GitHub] flink pull request: Hits

2015-07-02 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/765#issuecomment-118161158 Hi there! What is the status of this PR? It seems that travis is failing with checkstyle violations related to using spaces instead of tabs. Let us know if you

[GitHub] flink pull request: [FLINK-2150] Added zipWithUniqueIds

2015-07-02 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/801#discussion_r33820633 --- Diff: docs/apis/zip_elements_guide.md --- @@ -63,4 +63,44 @@ env.execute() will yield the tuples: (0,A), (1,B), (2,C), (3,D), (4,E), (5,F

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-07-02 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r33822502 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java --- @@ -0,0 +1,471 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-07-02 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r33822653 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java --- @@ -0,0 +1,471 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-07-02 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r33823666 --- Diff: flink-staging/flink-gelly/src/test/java/org/apache/flink/graph/test/operations/GraphCreationITCase.java --- @@ -54,16 +75,13 @@ public void

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-07-02 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r33823849 --- Diff: flink-staging/flink-gelly/src/test/java/org/apache/flink/graph/test/operations/GraphCreationWithMapperITCase.java --- @@ -52,16 +72,13 @@ public void

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-07-02 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/847#issuecomment-118173012 Hi @shghatge! Thank you for the update :) I left some comments inline. There are still some formatting issues in the code. Please, carefully go through your

[GitHub] flink pull request: [FLINK-2141] Allow GSA's Gather to perform thi...

2015-07-02 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/877#discussion_r33826389 --- Diff: docs/libs/gelly_guide.md --- @@ -734,6 +737,24 @@ public static final class Apply { {% endhighlight %} +The following example

[GitHub] flink pull request: [FLINK-2141] Allow GSA's Gather to perform thi...

2015-07-02 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/877#issuecomment-118179278 Hi @shghatge! This looks good in general. Apart from my small inline comment, I have an objection regarding the added example. If I understand correctly

[GitHub] flink pull request: [FLINK-2141] Allow GSA's Gather to perform thi...

2015-07-02 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/877#issuecomment-118180990 In my view it's a straight-forward configuration option. If the user wants to propagate changes in this direction, they set the parameter. Also, I'm seeing that Gelly

[GitHub] flink pull request: [Flink-Gelly] [example] added missing assumpti...

2015-07-02 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/883#issuecomment-118181248 Hi @samk3211! Thank you for spotting this :) Can you please (1) close #881, (2) add this comment also to GSAPageRank as @andralungu (3) squash your commits to a single

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference Method

2015-06-25 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/818#issuecomment-115215460 Thank you @shghatge! I'll merge this :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request: [FLINK-2264] [gelly] changed the tests to use ...

2015-06-25 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/863#issuecomment-115194215 Thank you @samk3211! This looks good :) I see that like here, @mjsax has also created a utils class for the new comparison methods in #866. Since all migrated

[jira] [Commented] (FLINK-2163) VertexCentricConfigurationITCase sometimes fails on Travis

2015-06-25 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14602000#comment-14602000 ] Vasia Kalavri commented on FLINK-2163: -- This test has now been changed to use collect

[jira] [Resolved] (FLINK-2264) Migrate integration tests for Gelly

2015-06-25 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri resolved FLINK-2264. -- Resolution: Fixed Fix Version/s: 0.10 Congrats on your first contribution [~Samia

[jira] [Resolved] (FLINK-1522) Add tests for the library methods and examples

2015-06-25 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri resolved FLINK-1522. -- Resolution: Fixed Fix Version/s: 0.10 Add tests for the library methods and examples

[jira] [Resolved] (FLINK-2271) PageRank gives wrong results with weighted graph input

2015-06-25 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri resolved FLINK-2271. -- Resolution: Fixed PageRank gives wrong results with weighted graph input

[jira] [Created] (FLINK-2271) PageRank gives wrong results with weighted graph input

2015-06-24 Thread Vasia Kalavri (JIRA)
Vasia Kalavri created FLINK-2271: Summary: PageRank gives wrong results with weighted graph input Key: FLINK-2271 URL: https://issues.apache.org/jira/browse/FLINK-2271 Project: Flink Issue

[jira] [Updated] (FLINK-2271) PageRank gives wrong results with weighted graph input

2015-06-24 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri updated FLINK-2271: - Affects Version/s: (was: 0.9.1) (was: 0.10

[GitHub] flink pull request: [FLINK-2271] [FLINK-1522] [gelly] add missing ...

2015-06-24 Thread vasia
GitHub user vasia opened a pull request: https://github.com/apache/flink/pull/865 [FLINK-2271] [FLINK-1522] [gelly] add missing example tests This PR adds missing Gelly tests for PageRank and MusicProfiles examples. It also changes both vertex-centric and GSA PageRank examples

[jira] [Assigned] (FLINK-2271) PageRank gives wrong results with weighted graph input

2015-06-24 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri reassigned FLINK-2271: Assignee: Vasia Kalavri PageRank gives wrong results with weighted graph input

[jira] [Created] (FLINK-2264) Migrate integration tests for Gelly

2015-06-23 Thread Vasia Kalavri (JIRA)
Vasia Kalavri created FLINK-2264: Summary: Migrate integration tests for Gelly Key: FLINK-2264 URL: https://issues.apache.org/jira/browse/FLINK-2264 Project: Flink Issue Type: Sub-task

[jira] [Updated] (FLINK-2264) Migrate integration tests for Gelly

2015-06-23 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri updated FLINK-2264: - Assignee: Samia Khalid Migrate integration tests for Gelly

[jira] [Commented] (FLINK-2032) Migrate integration tests from temp output files to collect()

2015-06-23 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14597403#comment-14597403 ] Vasia Kalavri commented on FLINK-2032: -- Hi there, I am working with a new contributor

[GitHub] flink pull request: [FLINK-1962] Add Gelly Scala API

2015-06-23 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/808#issuecomment-114426618 Oh, one more thing :) In order to make this work in Eclipse, I had to add a few lines to the pom.xml. Basically, I copied the `build` block from the streaming-scala

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference Method

2015-06-23 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/818#discussion_r33026720 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java --- @@ -1234,6 +1248,17 @@ public void coGroup(IterableEdgeK, EV edge

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference Method

2015-06-23 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/818#issuecomment-114430160 Hi @shghatge! Thank you for the quick update. Apart from my minor comment, this looks good now :) --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference Method

2015-06-17 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/818#issuecomment-112923172 Hi @shghatge! For this issue, I think we should only add the `difference` method. If you want to avoid duplicating code, you can always define a private helper

[jira] [Commented] (FLINK-2235) Local Flink cluster allocates too much memory

2015-06-17 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590464#comment-14590464 ] Vasia Kalavri commented on FLINK-2235: -- We ran into the same issue today

[GitHub] flink pull request: [FLINK-2140][gelly] Allowed access to the numb...

2015-06-17 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/779#issuecomment-112933533 +1, looks good! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-17 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r32672972 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java --- @@ -282,6 +282,58 @@ public void flatMap(EdgeK, EV edge

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-17 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r32672778 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java --- @@ -282,6 +282,58 @@ public void flatMap(EdgeK, EV edge

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-17 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r32673063 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java --- @@ -282,6 +282,58 @@ public void flatMap(EdgeK, EV edge

[GitHub] flink pull request: [FLINK-2178][gelly] Fixed groupReduceOnNeighbo...

2015-06-17 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/799#issuecomment-112940323 Perfect, thanks @andralungu! +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-17 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r32673548 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java --- @@ -0,0 +1,388 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-17 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r32674993 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java --- @@ -0,0 +1,388 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-17 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r32674908 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java --- @@ -0,0 +1,388 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-17 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r32674944 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java --- @@ -0,0 +1,388 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-17 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r32672827 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java --- @@ -282,6 +282,58 @@ public void flatMap(EdgeK, EV edge

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-17 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r32673806 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java --- @@ -0,0 +1,388 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-17 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r32676277 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java --- @@ -0,0 +1,388 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-17 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/847#issuecomment-112954221 Hey @shghatge, this is a great first try, you got the logic right and I really like the detailed javadocs ^^ I left a few inline comments, which should be easy

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-17 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r32672995 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java --- @@ -282,6 +282,58 @@ public void flatMap(EdgeK, EV edge

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-17 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r32673105 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java --- @@ -0,0 +1,388 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-17 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r32673158 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java --- @@ -0,0 +1,388 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-17 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r32674930 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java --- @@ -0,0 +1,388 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-17 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r32674923 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java --- @@ -0,0 +1,388 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-17 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r32674967 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java --- @@ -0,0 +1,388 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-17 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r32675011 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java --- @@ -0,0 +1,388 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-17 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r32672805 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java --- @@ -282,6 +282,58 @@ public void flatMap(EdgeK, EV edge

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-17 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r32672727 --- Diff: docs/libs/gelly_guide.md --- @@ -102,6 +102,15 @@ DataSetTuple3String, String, Double edgeTuples = env.readCsvFile(path/to/ed GraphString, Long

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-17 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r32673221 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java --- @@ -0,0 +1,388 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-17 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r32673330 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java --- @@ -282,6 +282,58 @@ public void flatMap(EdgeK, EV edge

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

2015-06-17 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/847#discussion_r32673274 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java --- @@ -0,0 +1,388 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference Method

2015-06-17 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/818#issuecomment-112814353 Hey, difference in not a fancy way of removing vertices, no :) If you recall our previous conversation in #678, we decided to have add/remove methods for small

[GitHub] flink pull request: [FLINK-2178][gelly] Fixed groupReduceOnNeighbo...

2015-06-15 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/799#issuecomment-111993642 @andralungu, I believe the same issue appears in `ApplyCoGroupFunctionOnAllEdges` and `ApplyCoGroupFunction`. Could you check if that's the case and fix those too

[GitHub] flink pull request: [FLINK-2178][gelly] Fixed groupReduceOnNeighbo...

2015-06-13 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/799#issuecomment-111760267 Hey @andralungu, I'm not sure I understand this one. It's a coGroup of vertices with the edges. For the vertex iterator to be empty, doesn't it mean that there's

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference Method

2015-06-13 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/818#discussion_r32374715 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java --- @@ -1234,6 +1234,18 @@ public void coGroup(IterableEdgeK, EV edge

[jira] [Commented] (FLINK-1520) Read edges and vertices from CSV files

2015-06-13 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14584886#comment-14584886 ] Vasia Kalavri commented on FLINK-1520: -- I don't think it'll be a lot of duplicate

[GitHub] flink pull request: [FLINK-2149][gelly] Simplified Jaccard Example

2015-06-13 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/770#discussion_r32374939 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/JaccardSimilarityMeasure.java --- @@ -66,34 +63,47 @@ public static void main

[jira] [Comment Edited] (FLINK-1520) Read edges and vertices from CSV files

2015-06-13 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14584855#comment-14584855 ] Vasia Kalavri edited comment on FLINK-1520 at 6/13/15 10:44 PM

[GitHub] flink pull request: [FLINK-2093][gelly] Added difference Method

2015-06-13 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/818#discussion_r32374703 --- Diff: docs/libs/gelly_guide.md --- @@ -240,6 +240,7 @@ GraphLong, Double, Double networkWithWeights = network.joinWithEdgesOnSource(v img alt=Union

[jira] [Commented] (FLINK-1520) Read edges and vertices from CSV files

2015-06-03 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14570586#comment-14570586 ] Vasia Kalavri commented on FLINK-1520: -- Hey [~cebe]! One more ping to you

[jira] [Created] (FLINK-2150) Add a library method that assigns unique Long values to vertices

2015-06-03 Thread Vasia Kalavri (JIRA)
Vasia Kalavri created FLINK-2150: Summary: Add a library method that assigns unique Long values to vertices Key: FLINK-2150 URL: https://issues.apache.org/jira/browse/FLINK-2150 Project: Flink

[jira] [Created] (FLINK-2149) Simplify Gelly Jaccard similarity example

2015-06-03 Thread Vasia Kalavri (JIRA)
Vasia Kalavri created FLINK-2149: Summary: Simplify Gelly Jaccard similarity example Key: FLINK-2149 URL: https://issues.apache.org/jira/browse/FLINK-2149 Project: Flink Issue Type

[jira] [Updated] (FLINK-1759) Execution statistics for vertex-centric iterations

2015-06-03 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri updated FLINK-1759: - Labels: (was: easyfix starter) Execution statistics for vertex-centric iterations

[GitHub] flink pull request: [FLINK-1707][WIP]Add an Affinity Propagation L...

2015-06-03 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/649#issuecomment-108284020 Hey @joey001! Are you still working on this? Let us know if you need help! --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Updated] (FLINK-1759) Execution statistics for vertex-centric iterations

2015-06-03 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri updated FLINK-1759: - Labels: easyfix starter (was: ) Execution statistics for vertex-centric iterations

[jira] [Commented] (FLINK-1962) Add Gelly Scala API

2015-06-03 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14570607#comment-14570607 ] Vasia Kalavri commented on FLINK-1962: -- Awesome news [~vanaepi]! Add Gelly Scala

[GitHub] flink pull request: [docs/javadoc][hotfix] Corrected Join hint and...

2015-06-03 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/763#issuecomment-108262606 looks good, +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-1526][gelly] [work in progress] Added M...

2015-06-03 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/434#issuecomment-108278253 Hey @andralungu! I think we should close this one. We can't really continue from this state anyway. I guess we'll have to revisit this problem once we have

[GitHub] flink pull request: [FLINK-1528][Gelly] Added Local Clustering Coe...

2015-06-03 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/420#issuecomment-108283573 Hey @balidani! Would you like to finish this up? It's not really urgent, but it's almost finished and it'd be a pity to abandon :) Someone else could also take

[jira] [Updated] (FLINK-2149) Simplify Gelly Jaccard similarity example

2015-06-03 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri updated FLINK-2149: - Labels: easyfix starter (was: ) Simplify Gelly Jaccard similarity example

[GitHub] flink pull request: [FLINK-2012][gelly] Added methods to remove/ad...

2015-05-26 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/678#issuecomment-105429495 Great! +1 for opening a separate issue for `difference` and big +1 for remembering to use @ForwardedFields :)) --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-1941] documentation for the Gather-Sum-...

2015-05-26 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/722#issuecomment-105642132 and will merge :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-2012][gelly] Added methods to remove/ad...

2015-05-26 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/678#issuecomment-105641949 will merge! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Resolved] (FLINK-1941) Add documentation for Gelly-GSA

2015-05-26 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri resolved FLINK-1941. -- Resolution: Fixed Add documentation for Gelly-GSA

[jira] [Resolved] (FLINK-2012) addVertices, addEdges, removeVertices, removeEdges methods

2015-05-26 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri resolved FLINK-2012. -- Resolution: Implemented Fix Version/s: 0.9 addVertices, addEdges, removeVertices

[GitHub] flink pull request: [FLINK-1941] documentation for the Gather-Sum-...

2015-05-25 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/722#issuecomment-105201007 Added comparison section and SSSP drawings for vertex-centric ^^ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request: [FLINK-2012][gelly] Added methods to remove/ad...

2015-05-25 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/678#issuecomment-105287317 Hey @andralungu, first of all, you can always discuss implementation details by starting a thread in the mailing list. This is usually done for bigger changes, so

[GitHub] flink pull request: [FLINK-2012][gelly] Added methods to remove/ad...

2015-05-24 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/678#issuecomment-105014574 Hi @andralungu, I think that mixing DataSet with List is not the way to go. When would one end up with a DataSet of vertices, but just a list of Edges (given

[GitHub] flink pull request: [FLINK-1941] documentation for the Gather-Sum-...

2015-05-24 Thread vasia
GitHub user vasia opened a pull request: https://github.com/apache/flink/pull/722 [FLINK-1941] documentation for the Gather-Sum-Apply iterations in Gelly This one adds a high-level description of GSA iterative model and an example of implementing SSSP with GSA in Gelly. Also

[jira] [Assigned] (FLINK-1941) Add documentation for Gelly-GSA

2015-05-24 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri reassigned FLINK-1941: Assignee: Vasia Kalavri Add documentation for Gelly-GSA

<    4   5   6   7   8   9   10   11   12   >