Re: [PR] [FLINK-34482][checkpoint] Rename checkpointing options [flink]

2024-06-12 Thread via GitHub
masteryhx closed pull request #24878: [FLINK-34482][checkpoint] Rename checkpointing options URL: https://github.com/apache/flink/pull/24878 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [hotfix][checkpointing] Normalize file-merging sub dir [flink]

2024-06-12 Thread via GitHub
zoltar9264 commented on code in PR #24928: URL: https://github.com/apache/flink/pull/24928#discussion_r1637586337 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/AcrossCheckpointFileMergingSnapshotManager.java: ## @@ -31,12 +33,13 @@ public class

[PR] [FLINK-35512[flink-clinets] Don't depend on the flink-clients jar actually existing. [flink]

2024-06-12 Thread via GitHub
SamBarker opened a new pull request, #24931: URL: https://github.com/apache/flink/pull/24931 ## What is the purpose of the change Ensure that running `mvn clean verify` works for flink-clients (as is the recommended step from [contributing to

Re: [PR] [hotfix][checkpointing] Normalize file-merging sub dir [flink]

2024-06-12 Thread via GitHub
Zakelly commented on code in PR #24928: URL: https://github.com/apache/flink/pull/24928#discussion_r1637493879 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/AcrossCheckpointFileMergingSnapshotManager.java: ## @@ -31,12 +33,13 @@ public class

Re: [PR] [FLINK-34545][cdc-pipeline-connector]Add OceanBase pipeline connector to Flink CDC [flink-cdc]

2024-06-12 Thread via GitHub
whhe commented on code in PR #3360: URL: https://github.com/apache/flink-cdc/pull/3360#discussion_r1637472845 ##

Re: [PR] [FLINK-30400][docs] Add some notes about changes for flink-connector-base dependency in externalized connectors [flink]

2024-06-12 Thread via GitHub
flinkbot commented on PR #24930: URL: https://github.com/apache/flink/pull/24930#issuecomment-2164316211 ## CI report: * ace19bbeee9cc5e5f8ecf784aa3ed5e55d073f7f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [mysql] Mysql-cdc adapt mariadb. [flink-cdc]

2024-06-12 Thread via GitHub
linmingze commented on PR #2494: URL: https://github.com/apache/flink-cdc/pull/2494#issuecomment-2164291002 hello en how about this fix going -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [FLINK-30400][docs] Add some notes about changes for flink-connector-base dependency in externalized connectors [flink]

2024-06-12 Thread via GitHub
ruanhang1993 commented on PR #24930: URL: https://github.com/apache/flink/pull/24930#issuecomment-2164284187 @rmetzger @leonardBang Would you like to help to review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] [FLINK-30400][docs] Add some notes about changes for flink-connector-base dependency in externalized connectors [flink]

2024-06-12 Thread via GitHub
ruanhang1993 opened a new pull request, #24930: URL: https://github.com/apache/flink/pull/24930 ## What is the purpose of the change This pull request adds some notes about changes for flink-connector-base dependency in externalized connectors. ## Brief change log Add

Re: [PR] [FLINK-35157][runtime] Sources with watermark alignment get stuck once some subtasks finish [flink]

2024-06-12 Thread via GitHub
elon-X commented on code in PR #24757: URL: https://github.com/apache/flink/pull/24757#discussion_r1637436928 ## flink-runtime/src/test/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorAlignmentTest.java: ## @@ -310,6 +310,53 @@ void

Re: [PR] [FLINK-35157][runtime] Sources with watermark alignment get stuck once some subtasks finish [flink]

2024-06-12 Thread via GitHub
1996fanrui commented on code in PR #24757: URL: https://github.com/apache/flink/pull/24757#discussion_r1637386871 ## flink-runtime/src/test/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorAlignmentTest.java: ## @@ -310,6 +310,53 @@ void

Re: [PR] [FLINK-34470][Connectors/Kafka] Fix indefinite blocking by adjusting stopping condition in split reader [flink-connector-kafka]

2024-06-12 Thread via GitHub
dongwoo6kim commented on PR #100: URL: https://github.com/apache/flink-connector-kafka/pull/100#issuecomment-2164206983 Thanks for confirming @morazow, Please feel free to provide any additional advice before merging this fix. It would be also helpful if you could elaborate more on

Re: [PR] [FLINK-34990][cdc-connector][oracle] Oracle cdc support newly add table [flink-cdc]

2024-06-12 Thread via GitHub
gong commented on PR #3203: URL: https://github.com/apache/flink-cdc/pull/3203#issuecomment-2164201064 @leonardBang CI failure is not related to PR. Please help rerun CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core with,Package: core [flink]

2024-06-12 Thread via GitHub
1996fanrui commented on PR #24881: URL: https://github.com/apache/flink/pull/24881#issuecomment-2164197766 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-34977][API] Introduce State Access on DataStream API V2 [flink]

2024-06-12 Thread via GitHub
reswqa closed pull request #24725: [FLINK-34977][API] Introduce State Access on DataStream API V2 URL: https://github.com/apache/flink/pull/24725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] [FLINK-35586] shuffle Event of the same bucket to the same subtask to avoid conflict. [flink-cdc]

2024-06-12 Thread via GitHub
lvyanquan opened a new pull request, #3413: URL: https://github.com/apache/flink-cdc/pull/3413 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [FLINK-35585] Add documentation for distribution [flink]

2024-06-12 Thread via GitHub
flinkbot commented on PR #24929: URL: https://github.com/apache/flink/pull/24929#issuecomment-2163969225 ## CI report: * 401ad021195bca0d5329723dfb492760f4a147c8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-35585] Add documentation for distribution [flink]

2024-06-12 Thread via GitHub
jnh5y opened a new pull request, #24929: URL: https://github.com/apache/flink/pull/24929 ## What is the purpose of the change Add documentation to cover FLIP-376. ## Documentation - Does this pull request introduce a new feature? (yes / no) - If yes, how is the

Re: [PR] [FLINK-33759] [flink-parquet] Add support for nested array with row type [flink]

2024-06-12 Thread via GitHub
ukby1234 closed pull request #24029: [FLINK-33759] [flink-parquet] Add support for nested array with row type URL: https://github.com/apache/flink/pull/24029 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]

2024-06-12 Thread via GitHub
MartijnVisser commented on PR #24805: URL: https://github.com/apache/flink/pull/24805#issuecomment-2163842389 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [hotfix] [docs] reference.md: Add missing FlinkSessionJob CRD [flink-kubernetes-operator]

2024-06-12 Thread via GitHub
mattayes closed pull request #837: [hotfix] [docs] reference.md: Add missing FlinkSessionJob CRD URL: https://github.com/apache/flink-kubernetes-operator/pull/837 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [hotfix] [docs] reference.md: Add missing FlinkSessionJob CRD [flink-kubernetes-operator]

2024-06-12 Thread via GitHub
mattayes commented on PR #837: URL: https://github.com/apache/flink-kubernetes-operator/pull/837#issuecomment-2163720507 @gyfora Thanks for clarifying, I'll make the changes there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [hotfix][checkpointing] Normalize file-merging sub dir [flink]

2024-06-12 Thread via GitHub
flinkbot commented on PR #24928: URL: https://github.com/apache/flink/pull/24928#issuecomment-2163701730 ## CI report: * a0719f7e58a3666e9ea39ce673c47a58679c38e6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [hotfix][checkpointing] Normalize file-merging sub dir [flink]

2024-06-12 Thread via GitHub
zoltar9264 opened a new pull request, #24928: URL: https://github.com/apache/flink/pull/24928 ## What is the purpose of the change As title said, normalize file-merging sub dir, including subtask dir and exclusive dir. ## Brief change log *(for example:)* -

Re: [PR] [FLINK-35371][security] Add configuration for SSL keystore and truststore type [flink]

2024-06-12 Thread via GitHub
ammar-master commented on PR #24919: URL: https://github.com/apache/flink/pull/24919#issuecomment-2163411240 @gaborgsomogyi Can this go in before the feature freeze on June 15? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [FLINK-34977][API] Introduce State Access on DataStream API V2 [flink]

2024-06-12 Thread via GitHub
jeyhunkarimov commented on PR #24725: URL: https://github.com/apache/flink/pull/24725#issuecomment-2163282560 Thanks a lot @reswqa -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]

2024-06-12 Thread via GitHub
snuyanzin commented on code in PR #24805: URL: https://github.com/apache/flink/pull/24805#discussion_r1636593978 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/PrintSinkFunction.java: ## @@ -33,7 +33,10 @@ * no {@code sinkIdentifier}

Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]

2024-06-12 Thread via GitHub
MartijnVisser commented on code in PR #24805: URL: https://github.com/apache/flink/pull/24805#discussion_r1636642416 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/PrintSinkFunction.java: ## @@ -33,7 +33,10 @@ * no {@code sinkIdentifier}

Re: [PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-06-12 Thread via GitHub
caicancai commented on PR #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830#issuecomment-2163186911 @1996fanrui I'm very sorry for the late revision. I've been a bit busy recently. I'll check it again tomorrow. You don't need to review it yet. -- This is an

Re: [PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-06-12 Thread via GitHub
caicancai commented on code in PR #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1636594307 ## docs/content/docs/custom-resource/pod-template.md: ## @@ -125,4 +124,4 @@ arr1: [{name: a, p2: v2}, {name: c, p2: v2}] merged: [{name: a, p1:

Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]

2024-06-12 Thread via GitHub
snuyanzin commented on code in PR #24805: URL: https://github.com/apache/flink/pull/24805#discussion_r1636593978 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/PrintSinkFunction.java: ## @@ -33,7 +33,10 @@ * no {@code sinkIdentifier}

Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]

2024-06-12 Thread via GitHub
snuyanzin commented on code in PR #24805: URL: https://github.com/apache/flink/pull/24805#discussion_r1636593978 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/PrintSinkFunction.java: ## @@ -33,7 +33,10 @@ * no {@code sinkIdentifier}

Re: [PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-06-12 Thread via GitHub
caicancai commented on code in PR #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1636593737 ## docs/content/docs/custom-resource/pod-template.md: ## @@ -113,10 +112,10 @@ arr1: [{name: a, p2: v2}, {name: c, p2: v2}] merged: [{name: a, p1:

Re: [PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-06-12 Thread via GitHub
caicancai commented on code in PR #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1636593004 ## docs/content/docs/custom-resource/pod-template.md: ## @@ -93,16 +90,18 @@ spec: ``` {{< hint info >}} -When using the operator with Flink

Re: [PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-06-12 Thread via GitHub
caicancai commented on code in PR #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1636591874 ## docs/content/docs/custom-resource/pod-template.md: ## @@ -26,21 +26,18 @@ under the License. # Pod template -The operator CRD is designed to

Re: [PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-06-12 Thread via GitHub
caicancai commented on code in PR #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1636591482 ## docs/content/docs/custom-resource/pod-template.md: ## @@ -26,21 +26,18 @@ under the License. # Pod template -The operator CRD is designed to

Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]

2024-06-12 Thread via GitHub
MartijnVisser commented on code in PR #24805: URL: https://github.com/apache/flink/pull/24805#discussion_r1636585255 ## pom.xml: ## @@ -2371,6 +2371,11 @@ under the License.

Re: [PR] [FLINK-34172] Add support for altering a distribution via ALTER TABLE [flink]

2024-06-12 Thread via GitHub
jnh5y commented on code in PR #24886: URL: https://github.com/apache/flink/pull/24886#discussion_r1636579991 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlDdlToOperationConverterTest.java: ## @@ -1361,16 +1374,36 @@ public void

Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]

2024-06-12 Thread via GitHub
snuyanzin commented on code in PR #24805: URL: https://github.com/apache/flink/pull/24805#discussion_r1636579070 ## pom.xml: ## @@ -2371,6 +2371,11 @@ under the License.

Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]

2024-06-12 Thread via GitHub
MartijnVisser commented on code in PR #24805: URL: https://github.com/apache/flink/pull/24805#discussion_r1636572746 ## pom.xml: ## @@ -2371,6 +2371,11 @@ under the License.

Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]

2024-06-12 Thread via GitHub
snuyanzin commented on code in PR #24805: URL: https://github.com/apache/flink/pull/24805#discussion_r1636561747 ## pom.xml: ## @@ -2371,6 +2371,11 @@ under the License.

Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]

2024-06-12 Thread via GitHub
MartijnVisser commented on code in PR #24805: URL: https://github.com/apache/flink/pull/24805#discussion_r1636516611 ## pom.xml: ## @@ -2371,6 +2371,11 @@ under the License.

Re: [PR] Update flink-operations-playground.md for a typo [flink]

2024-06-12 Thread via GitHub
flinkbot commented on PR #24927: URL: https://github.com/apache/flink/pull/24927#issuecomment-2163075264 ## CI report: * 658b68a6bb0f6227fa16f7e990ee67db64e471e9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34172] Add support for altering a distribution via ALTER TABLE [flink]

2024-06-12 Thread via GitHub
twalthr commented on code in PR #24886: URL: https://github.com/apache/flink/pull/24886#discussion_r1636474722 ## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlDistribution.java: ## @@ -70,17 +70,28 @@ public List getOperandList() {

Re: [PR] [FLINK-35378] [FLIP-453] Promote Unified Sink API V2 to Public and Deprecate SinkFunction [flink]

2024-06-12 Thread via GitHub
snuyanzin commented on code in PR #24805: URL: https://github.com/apache/flink/pull/24805#discussion_r1636475673 ## pom.xml: ## @@ -2371,6 +2371,11 @@ under the License.

[PR] Update flink-operations-playground.md for a typo [flink]

2024-06-12 Thread via GitHub
rohimsh opened a new pull request, #24927: URL: https://github.com/apache/flink/pull/24927 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

Re: [PR] [FLINK-35570] Consider PlaceholderStreamStateHandle in checkpoint file merging [flink]

2024-06-12 Thread via GitHub
Zakelly closed pull request #24924: [FLINK-35570] Consider PlaceholderStreamStateHandle in checkpoint file merging URL: https://github.com/apache/flink/pull/24924 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [hotfix] Improve execution.checkpointing.unaligned.interruptible-timers.enabled documentation [flink]

2024-06-12 Thread via GitHub
flinkbot commented on PR #24926: URL: https://github.com/apache/flink/pull/24926#issuecomment-2162942962 ## CI report: * b88ad00e20b5f2e76c3d7eb02c7adc3239faed8a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [hotfix] Improve execution.checkpointing.unaligned.interruptible-timers.enabled documentation [flink]

2024-06-12 Thread via GitHub
pnowojski opened a new pull request, #24926: URL: https://github.com/apache/flink/pull/24926 Simple documentation improvement. ## Verifying this change N/A ## Does this pull request potentially affect one of the following parts: N/A ## Documentation

Re: [PR] [FLINK-35140][docs] Update Opensearch connector docs for 1.2.0 and 2.0.0 releases [flink]

2024-06-12 Thread via GitHub
snuyanzin commented on code in PR #24921: URL: https://github.com/apache/flink/pull/24921#discussion_r1636362092 ## docs/setup_docs.sh: ## @@ -59,7 +59,7 @@ if [ "$SKIP_INTEGRATE_CONNECTOR_DOCS" = false ]; then integrate_connector_docs rabbitmq v3.0

Re: [PR] [FLINK-35528][task] Skip execution of interruptible mails when yielding [flink]

2024-06-12 Thread via GitHub
pnowojski merged PR #24904: URL: https://github.com/apache/flink/pull/24904 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-20217][task] Allow certains operators to yield to unaligned checkpoint in case timers are firing [flink]

2024-06-12 Thread via GitHub
pnowojski merged PR #24895: URL: https://github.com/apache/flink/pull/24895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-35140][docs] Update Opensearch connector docs for 1.2.0 and 2.0.0 releases [flink]

2024-06-12 Thread via GitHub
dannycranmer commented on code in PR #24921: URL: https://github.com/apache/flink/pull/24921#discussion_r1636357425 ## docs/setup_docs.sh: ## @@ -59,7 +59,7 @@ if [ "$SKIP_INTEGRATE_CONNECTOR_DOCS" = false ]; then integrate_connector_docs rabbitmq v3.0

Re: [PR] [FLINK-34111][table] Add JSON_QUOTE and JSON_UNQUOTE function [flink]

2024-06-12 Thread via GitHub
anupamaggarwal commented on PR #24156: URL: https://github.com/apache/flink/pull/24156#issuecomment-2162795228 Hi @jeyhunkarimov thank you for contributing this PR!. Just wanted to check if you were planning on working further on this, otherwise I'd be happy to continue and address some

Re: [PR] [FLINK-35371][security] Add configuration for SSL keystore and truststore type [flink]

2024-06-12 Thread via GitHub
gaborgsomogyi commented on PR #24919: URL: https://github.com/apache/flink/pull/24919#issuecomment-2162792331 Unless there are further comments I'm intended to merge it beginning of next week. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [FLINK-35157][runtime] Sources with watermark alignment get stuck once some subtasks finish [flink]

2024-06-12 Thread via GitHub
elon-X commented on code in PR #24757: URL: https://github.com/apache/flink/pull/24757#discussion_r1636303927 ## flink-runtime/src/test/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorAlignmentTest.java: ## @@ -310,6 +310,53 @@ void

Re: [PR] [FLINK-34990][cdc-connector][oracle] Oracle cdc support newly add table [flink-cdc]

2024-06-12 Thread via GitHub
gong commented on code in PR #3203: URL: https://github.com/apache/flink-cdc/pull/3203#discussion_r1636249435 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-oracle-cdc/src/test/java/org/apache/flink/cdc/connectors/oracle/source/NewlyAddedTableITCase.java: ##

Re: [PR] [FLINK-35533][runtime] Support Flink hybrid shuffle integration with Apache Celeborn [flink]

2024-06-12 Thread via GitHub
reswqa merged PR #24900: URL: https://github.com/apache/flink/pull/24900 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core with,Package: core [flink]

2024-06-12 Thread via GitHub
1996fanrui commented on code in PR #24881: URL: https://github.com/apache/flink/pull/24881#discussion_r1636152962 ## flink-core/src/test/java/org/apache/flink/core/fs/InitOutputPathTest.java: ## @@ -23,59 +23,52 @@ import org.apache.flink.core.fs.local.LocalFileSystem; import

Re: [PR] [FLINK-34977][API] Introduce State Access on DataStream API V2 [flink]

2024-06-12 Thread via GitHub
jeyhunkarimov commented on PR #24725: URL: https://github.com/apache/flink/pull/24725#issuecomment-2162579459 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Revert [FLINK-34123][FLINK-35068]: Add built-in dedicated serialization support for Maps, Lists, Sets, and Collections [flink]

2024-06-12 Thread via GitHub
reswqa merged PR #24925: URL: https://github.com/apache/flink/pull/24925 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-35570] Consider PlaceholderStreamStateHandle in checkpoint file merging [flink]

2024-06-12 Thread via GitHub
Zakelly commented on PR #24924: URL: https://github.com/apache/flink/pull/24924#issuecomment-2162569651 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-35570] Consider PlaceholderStreamStateHandle in checkpoint file merging [flink]

2024-06-12 Thread via GitHub
Zakelly commented on code in PR #24924: URL: https://github.com/apache/flink/pull/24924#discussion_r1636034323 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/SnapshotFileMergingCompatibilityITCase.java: ## @@ -167,22 +166,25 @@ private void

Re: [PR] [FLINK-20217][task] Allow certains operators to yield to unaligned checkpoint in case timers are firing [flink]

2024-06-12 Thread via GitHub
pnowojski commented on PR #24895: URL: https://github.com/apache/flink/pull/24895#issuecomment-2162389538 Yes, fixed! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [FLINK-35143][cdc-connector][mysql] Expose newly added tables capture in mysql pipeline connector. [flink-cdc]

2024-06-12 Thread via GitHub
morazow commented on code in PR #3411: URL: https://github.com/apache/flink-cdc/pull/3411#discussion_r1636002649 ##

Re: [PR] [FLINK-35121][common] Adds validation for pipeline definition options [flink-cdc]

2024-06-12 Thread via GitHub
morazow commented on code in PR #3382: URL: https://github.com/apache/flink-cdc/pull/3382#discussion_r1636001422 ##

Re: [PR] [FLINK-35121][common] Adds validation for pipeline definition options [flink-cdc]

2024-06-12 Thread via GitHub
morazow commented on code in PR #3382: URL: https://github.com/apache/flink-cdc/pull/3382#discussion_r1635999340 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-kafka/src/test/java/org/apache/flink/cdc/connectors/kafka/sink/KafkaDataSinkFactoryTest.java:

Re: [PR] [FLINK-35143][cdc-connector][mysql] Expose newly added tables capture in mysql pipeline connector. [flink-cdc]

2024-06-12 Thread via GitHub
qg-lin commented on code in PR #3411: URL: https://github.com/apache/flink-cdc/pull/3411#discussion_r1635967850 ##

Re: [PR] [FLINK-34990][cdc-connector][oracle] Oracle cdc support newly add table [flink-cdc]

2024-06-12 Thread via GitHub
GOODBOY008 commented on code in PR #3203: URL: https://github.com/apache/flink-cdc/pull/3203#discussion_r1635937545 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-oracle-cdc/src/test/java/org/apache/flink/cdc/connectors/oracle/testutils/OracleTestUtils.java:

Re: [PR] [FLINK-35121][common] Adds validation for pipeline definition options [flink-cdc]

2024-06-12 Thread via GitHub
yuxiqian commented on code in PR #3382: URL: https://github.com/apache/flink-cdc/pull/3382#discussion_r1635956703 ## flink-cdc-common/src/test/java/org/apache/flink/cdc/common/factories/FactoryHelperTests.java: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-35143][cdc-connector][mysql] Expose newly added tables capture in mysql pipeline connector. [flink-cdc]

2024-06-12 Thread via GitHub
morazow commented on code in PR #3411: URL: https://github.com/apache/flink-cdc/pull/3411#discussion_r1635930879 ##

Re: [PR] [FLINK-35121][common] Adds validation for pipeline definition options [flink-cdc]

2024-06-12 Thread via GitHub
morazow commented on code in PR #3382: URL: https://github.com/apache/flink-cdc/pull/3382#discussion_r1635924042 ## flink-cdc-common/src/test/java/org/apache/flink/cdc/common/factories/FactoryHelperTests.java: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-35467][cdc-dist][bin] Respect externally set FLINK_CONF_DIR for CDC task configuration. [flink-cdc]

2024-06-12 Thread via GitHub
joyCurry30 commented on code in PR #3398: URL: https://github.com/apache/flink-cdc/pull/3398#discussion_r1635923711 ## flink-cdc-dist/src/main/flink-cdc-bin/bin/flink-cdc.sh: ## @@ -34,11 +34,11 @@ if [[ -z $FLINK_HOME ]]; then exit 1 fi -# Setup Flink related

Re: [PR] [FLINK-35121][pipeline-connector][cdc-base] CDC pipeline connector provide ability to verify requiredOptions and optionalOptions [flink-cdc]

2024-06-12 Thread via GitHub
morazow commented on code in PR #3412: URL: https://github.com/apache/flink-cdc/pull/3412#discussion_r1635917238 ##

Re: [PR] [FLINK-35467][cdc-dist][bin] Respect externally set FLINK_CONF_DIR for CDC task configuration. [flink-cdc]

2024-06-12 Thread via GitHub
yuxiqian commented on code in PR #3398: URL: https://github.com/apache/flink-cdc/pull/3398#discussion_r1635883374 ## flink-cdc-dist/src/main/flink-cdc-bin/bin/flink-cdc.sh: ## @@ -34,11 +34,11 @@ if [[ -z $FLINK_HOME ]]; then exit 1 fi -# Setup Flink related

Re: [PR] [FLINK-35467][cdc-dist][bin] Respect externally set FLINK_CONF_DIR for CDC task configuration. [flink-cdc]

2024-06-12 Thread via GitHub
yuxiqian commented on code in PR #3398: URL: https://github.com/apache/flink-cdc/pull/3398#discussion_r1635883374 ## flink-cdc-dist/src/main/flink-cdc-bin/bin/flink-cdc.sh: ## @@ -34,11 +34,11 @@ if [[ -z $FLINK_HOME ]]; then exit 1 fi -# Setup Flink related

Re: [PR] [FLINK-35121][pipeline-connector][cdc-base] CDC pipeline connector provide ability to verify requiredOptions and optionalOptions [flink-cdc]

2024-06-12 Thread via GitHub
yuxiqian commented on PR #3412: URL: https://github.com/apache/flink-cdc/pull/3412#issuecomment-2162196171 Seems there's some overlap between this PR and #3382, @loserwang1024 mind if I cherry pick your commit? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [FLINK-35467][cdc-dist][bin] Respect externally set FLINK_CONF_DIR for CDC task configuration. [flink-cdc]

2024-06-12 Thread via GitHub
joyCurry30 commented on code in PR #3398: URL: https://github.com/apache/flink-cdc/pull/3398#discussion_r1635870700 ## flink-cdc-dist/src/main/flink-cdc-bin/bin/flink-cdc.sh: ## @@ -34,11 +34,11 @@ if [[ -z $FLINK_HOME ]]; then exit 1 fi -# Setup Flink related

Re: [PR] [FLINK-35533][runtime] Support Flink hybrid shuffle integration with Apache Celeborn [flink]

2024-06-12 Thread via GitHub
TanYuxin-tyx commented on code in PR #24900: URL: https://github.com/apache/flink/pull/24900#discussion_r1635866275 ## flink-core/src/main/java/org/apache/flink/configuration/NettyShuffleEnvironmentOptions.java: ## @@ -490,6 +490,24 @@ public enum CompressionCodec {

[PR] [FLINK-35121][pipeline-connector][cdc-base] CDC pipeline connector provide ability to verify requiredOptions and optionalOptions [flink-cdc]

2024-06-12 Thread via GitHub
loserwang1024 opened a new pull request, #3412: URL: https://github.com/apache/flink-cdc/pull/3412 CDC pipeline connector provide ability to verify requiredOptions and optionalOptions, nor will be hard to handle compatibility later。 -- This is an automated message from the Apache Git

Re: [PR] [FLINK-35533][runtime] Support Flink hybrid shuffle integration with Apache Celeborn [flink]

2024-06-12 Thread via GitHub
TanYuxin-tyx commented on code in PR #24900: URL: https://github.com/apache/flink/pull/24900#discussion_r1635860182 ## flink-runtime/src/test/java/org/apache/flink/runtime/util/NettyShuffleDescriptorBuilder.java: ## @@ -80,8 +83,14 @@ public NettyShuffleDescriptor buildRemote()

Re: [PR] [fix][cdc-connector][mysql] Fix NoClassDefFoundError when create new table in mysql cdc source [flink-cdc]

2024-06-12 Thread via GitHub
yuxiqian commented on PR #3036: URL: https://github.com/apache/flink-cdc/pull/3036#issuecomment-2162171729 Hi @pengmide, could you please rebase this PR with latest `master` branch before it could be merged? Thanks! -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [FLINK-35570] Consider PlaceholderStreamStateHandle in checkpoint file merging [flink]

2024-06-11 Thread via GitHub
fredia commented on code in PR #24924: URL: https://github.com/apache/flink/pull/24924#discussion_r1635853720 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/SnapshotFileMergingCompatibilityITCase.java: ## @@ -167,22 +166,25 @@ private void

Re: [PR] [FLINK-35371][security] Add configuration for SSL keystore and truststore type [flink]

2024-06-11 Thread via GitHub
ammar-master commented on PR #24919: URL: https://github.com/apache/flink/pull/24919#issuecomment-2162158973 @gaborgsomogyi I have addressed the comment, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-35371][security] Add configuration for SSL keystore and truststore type [flink]

2024-06-11 Thread via GitHub
ammar-master commented on PR #24919: URL: https://github.com/apache/flink/pull/24919#issuecomment-2162158609 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Revert [FLINK-34123][FLINK-35068]: Add built-in dedicated serialization support for Maps, Lists, Sets, and Collections [flink]

2024-06-11 Thread via GitHub
flinkbot commented on PR #24925: URL: https://github.com/apache/flink/pull/24925#issuecomment-2162103966 ## CI report: * e5d84501e6a2781205494bf429c29e1afe0d4031 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35570] Consider PlaceholderStreamStateHandle in checkpoint file merging [flink]

2024-06-11 Thread via GitHub
flinkbot commented on PR #24924: URL: https://github.com/apache/flink/pull/24924#issuecomment-2162103785 ## CI report: * 9ce0a6f2bb299224ed170ce0944de94703253b81 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] MailboxProcessor#processMailsWhenDefaultActionUnavailable avoids allocating Optional [flink]

2024-06-11 Thread via GitHub
flinkbot commented on PR #24923: URL: https://github.com/apache/flink/pull/24923#issuecomment-2162103603 ## CI report: * 88f9a4cf7a8e79d861755262f84f91a4b1b0d026 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] Revert FLINK-34123&35068: Add built-in dedicated serialization support for Maps, Lists, Sets, and Collections [flink]

2024-06-11 Thread via GitHub
X-czh opened a new pull request, #24925: URL: https://github.com/apache/flink/pull/24925 ## What is the purpose of the change Reverting previous changes that break state compatibility. [FLINK-34123](https://issues.apache.org/jira/browse/FLINK-34123) &

[PR] [FLINK-35570] Consider PlaceholderStreamStateHandle in checkpoint file merging [flink]

2024-06-11 Thread via GitHub
Zakelly opened a new pull request, #24924: URL: https://github.com/apache/flink/pull/24924 ## What is the purpose of the change In checkpoint file merging, we should take `PlaceholderStreamStateHandle` into account during lifecycle, since it can be a file merged one. ## Brief

[PR] MailboxProcessor#processMailsWhenDefaultActionUnavailable avoids allocating Optional [flink]

2024-06-11 Thread via GitHub
schlosna opened a new pull request, #24923: URL: https://github.com/apache/flink/pull/24923 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

Re: [PR] [FLINK-32091][checkpoint] Add file size metrics for file-merging [flink]

2024-06-11 Thread via GitHub
flinkbot commented on PR #24922: URL: https://github.com/apache/flink/pull/24922#issuecomment-2162053937 ## CI report: * 3405d0cc2c400c9c2d3a596b600b2ebda07af2f9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] Enable async profiler [flink-benchmarks]

2024-06-11 Thread via GitHub
Zakelly merged PR #90: URL: https://github.com/apache/flink-benchmarks/pull/90 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] [FLINK-32091][checkpoint] Add file size metrics for file-merging [flink]

2024-06-11 Thread via GitHub
fredia opened a new pull request, #24922: URL: https://github.com/apache/flink/pull/24922 ## What is the purpose of the change Add file size and file count metrics for file-merging. ## Brief change log - Add `logicalFileCount`, `logicalFileSize`,

Re: [PR] [FLINK-34545][cdc-pipeline-connector]Add OceanBase pipeline connector to Flink CDC [flink-cdc]

2024-06-11 Thread via GitHub
yuxiqian commented on PR #3360: URL: https://github.com/apache/flink-cdc/pull/3360#issuecomment-2161996630 Hi @yuanoOo, thanks for your great contribution! Since @whhe is familiar with OceanBase, do you have time to take a look? -- This is an automated message from the Apache Git

Re: [PR] [FLINK-35234][hotfix][cdc-common] Fix NullPointerException of org.apache.flink.cdc.common.configuration.ConfigurationUtils#convertToString [flink-cdc]

2024-06-11 Thread via GitHub
Jiabao-Sun commented on code in PR #3255: URL: https://github.com/apache/flink-cdc/pull/3255#discussion_r1635733171 ## flink-cdc-common/src/main/java/org/apache/flink/cdc/common/configuration/ConfigurationUtils.java: ## @@ -130,7 +130,9 @@ static Duration

Re: [PR] [FLINK-20217][task] Allow certains operators to yield to unaligned checkpoint in case timers are firing [flink]

2024-06-11 Thread via GitHub
1996fanrui commented on PR #24895: URL: https://github.com/apache/flink/pull/24895#issuecomment-2161973417 It seems one test related to timer fails, it maybe caused by this PR.

Re: [PR] [FLINK-35540][cdc-common] Fix table missed when database and table are with the same name in release-3.1.1 [flink-cdc]

2024-06-11 Thread via GitHub
leonardBang merged PR #3409: URL: https://github.com/apache/flink-cdc/pull/3409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core with,Package: core [flink]

2024-06-11 Thread via GitHub
1996fanrui commented on PR #24881: URL: https://github.com/apache/flink/pull/24881#issuecomment-2161888308 > Thanks @GOODBOY008 for the quick update, LGTM now. Hi @1996fanrui, could you help double check this PR? Thank @Jiabao-Sun for the ping, I will check it these 2 days. --

Re: [PR] [FLINK-35140][docs] Update Opensearch connector docs for 1.2.0 and 2.0.0 releases [flink]

2024-06-11 Thread via GitHub
flinkbot commented on PR #24921: URL: https://github.com/apache/flink/pull/24921#issuecomment-2161796100 ## CI report: * 84a66fe40a34e3e74b68beee473005b903a69fe3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

<    1   2   3   4   5   6   7   8   9   10   >