[GitHub] flink issue #3089: [FLINK-5497] remove duplicated tests

2017-01-16 Thread xhumanoid
Github user xhumanoid commented on the issue: https://github.com/apache/flink/pull/3089 @StephanEwen Hi, I did check more than double time This two part of code fully equals: ```java Tuple2<Integer, Integer> record; final Tuple2<Integer

[GitHub] flink issue #3106: [FLINK-5118] Fix inconsistent numBytesIn/Out metrics

2017-01-15 Thread xhumanoid
Github user xhumanoid commented on the issue: https://github.com/apache/flink/pull/3106 @zentol I asked because you always check on null when you try writing to Counter or is it prevent uninitialized state? --- If your project is set up for it, you can reply to this email

[GitHub] flink issue #3106: [FLINK-5118] Fix inconsistent numBytesIn/Out metrics

2017-01-15 Thread xhumanoid
Github user xhumanoid commented on the issue: https://github.com/apache/flink/pull/3106 @zentol what do you think about remove if (numBytesOut != null) { and replace numBytesOut = metrics.getNumBytesOutCounter

[GitHub] flink issue #2929: [FLINK-5247] Fix incorrect check in allowedLateness() met...

2017-01-11 Thread xhumanoid
Github user xhumanoid commented on the issue: https://github.com/apache/flink/pull/2929 I think @mindprince mean: at now logger not defined in class file this classes without private static final Logger LOG --- If your project is set up for it, you can reply

[GitHub] flink issue #3089: remove duplicated tests

2017-01-10 Thread xhumanoid
Github user xhumanoid commented on the issue: https://github.com/apache/flink/pull/3089 @aljoscha @rmetzger --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] flink pull request #3089: remove duplicated tests

2017-01-10 Thread xhumanoid
GitHub user xhumanoid opened a pull request: https://github.com/apache/flink/pull/3089 remove duplicated tests Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all

[GitHub] flink issue #3022: [FLINK-5360] Fix argument names in WindowedStream

2017-01-09 Thread xhumanoid
Github user xhumanoid commented on the issue: https://github.com/apache/flink/pull/3022 @aljoscha could you check and merge commit? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #3022: [FLINK-5360] Fix argument names in WindowedStream

2017-01-02 Thread xhumanoid
Github user xhumanoid commented on the issue: https://github.com/apache/flink/pull/3022 The same javadoc issue apply for minBy ;) I pointed maxBy only as example --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink issue #3022: [FLINK-5360] Fix argument names in WindowedStream

2016-12-25 Thread xhumanoid
Github user xhumanoid commented on the issue: https://github.com/apache/flink/pull/3022 After commit we have inconsistency between javadoc comment and arguments. for both _public SingleOutputStreamOperator maxBy(int positionToMaxBy)_ _public SingleOutputStreamOperator maxBy

[GitHub] flink issue #2442: [FLINK-4148] incorrect calculation minDist distance in Qu...

2016-09-10 Thread xhumanoid
Github user xhumanoid commented on the issue: https://github.com/apache/flink/pull/2442 slave was killed without any notifications: ERROR: Maven JVM terminated unexpectedly with exit code 137 Putting comment on the pull request Finished: FAILURE --- If your project

[GitHub] flink pull request #2442: [FLINK-4148] incorrect calculation minDist distanc...

2016-08-31 Thread xhumanoid
GitHub user xhumanoid opened a pull request: https://github.com/apache/flink/pull/2442 [FLINK-4148] incorrect calculation minDist distance in QuadTree Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list

[GitHub] flink issue #1626: [FLINK-3340] [runtime] Fix object juggling in drivers

2016-06-13 Thread xhumanoid
Github user xhumanoid commented on the issue: https://github.com/apache/flink/pull/1626 Hi, I know than issue closed, but he maybe have small bug https://github.com/apache/flink/pull/1626/files#diff-4a133896fec62bcabc1120b0df8cb8daR205 in hashCode recursion