[GitHub] flink pull request #5573: [FLINK-8756][Client] Support ClusterClient.getAccu...

2018-03-06 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5573#discussion_r172651895 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -389,6 +394,33 @@ public String cancelWithSavepoint

[GitHub] flink pull request #5573: [FLINK-8756][Client] Support ClusterClient.getAccu...

2018-03-06 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5573#discussion_r172650031 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobAccumulatorsInfo.java --- @@ -33,19 +39,38 @@ public class

[GitHub] flink pull request #5573: [FLINK-8756][Client] Support ClusterClient.getAccu...

2018-03-06 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5573#discussion_r172648696 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobAccumulatorsQueryParameter.java --- @@ -0,0 +1,41

[GitHub] flink pull request #5573: [FLINK-8756][Client] Support ClusterClient.getAccu...

2018-03-06 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5573#discussion_r172648802 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobAccumulatorsInfo.java --- @@ -104,6 +129,18 @@ public UserTaskAccumulator

[GitHub] flink pull request #5573: [FLINK-8756][Client] Support ClusterClient.getAccu...

2018-03-06 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5573#discussion_r172648627 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobAccumulatorsQueryParameter.java --- @@ -0,0 +1,41

[GitHub] flink issue #5645: FLINK-8876 Improve concurrent access handling in stateful...

2018-03-06 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5645 The end-to-end test would be cheap as we wouldn't execute a flink job or even start a flink cluster. The scripts in `flink-end-to-end-tests` can do pretty much anything they want; my idea

[GitHub] flink pull request #5645: FLINK-8876 Improve concurrent access handling in s...

2018-03-06 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5645#discussion_r172510349 --- Diff: flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/typeutils/AvroSerializer.java --- @@ -277,6 +349,26 @@ private void

[GitHub] flink pull request #5645: FLINK-8876 Improve concurrent access handling in s...

2018-03-06 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5645#discussion_r172509993 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/kryo/KryoSerializer.java --- @@ -502,6 +572,22 @@ private void readObject

[GitHub] flink pull request #5645: FLINK-8876 Improve concurrent access handling in s...

2018-03-06 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5645#discussion_r172508524 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/kryo/KryoSerializer.java --- @@ -502,6 +572,22 @@ private void readObject

[GitHub] flink issue #5645: FLINK-8876 Improve concurrent access handling in stateful...

2018-03-06 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5645 We got a bunch of failing tests: ``` Failed tests: MultidimensionalArraySerializerTest.testObjectArrays:84 Exception in test: Serializer already accessed by thread main

[GitHub] flink pull request #5644: [FLINK-8847][build] Prevent unnecessary recompilat...

2018-03-06 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/5644 [FLINK-8847][build] Prevent unnecessary recompilation ## What is the purpose of the change This PR contains 2 changes to prevent the `maven-compiler-plugin` from recompiling a module

[GitHub] flink issue #5614: [FLINK-8827] When FLINK_CONF_DIR contains spaces, execute...

2018-03-05 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5614 +1 ---

[GitHub] flink issue #5643: can integrate and support on apache kudu ?

2018-03-05 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5643 Pull Requests are not meant to ask question, please head to the [mailing lists](http://flink.apache.org/community.html#mailing-lists) or open a [JIRA](https://issues.apache.org/jira/projects/FLINK). ---

[GitHub] flink pull request #5636: [FLINK-8703][tests] Port CancelingTestBase to Mini...

2018-03-05 Thread zentol
Github user zentol closed the pull request at: https://github.com/apache/flink/pull/5636 ---

[GitHub] flink pull request #5636: [FLINK-8703][tests] Port CancelingTestBase to Mini...

2018-03-05 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/5636 [FLINK-8703][tests] Port CancelingTestBase to MiniClusterResource ## What is the purpose of the change The `CancelingTestBase` now uses the `MiniClusterResource` and can be run against

[GitHub] flink issue #5630: [FLINK-8849][Documentation] Fix link to chaining docs

2018-03-05 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5630 merging. ---

[GitHub] flink issue #5633: [FLINK-8857] [Hbase] Avoid HBase connector read example t...

2018-03-05 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5633 merging. ---

[GitHub] flink issue #5627: [doc] Remove missed CheckpointedRestoring

2018-03-05 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5627 merging. ---

[GitHub] flink issue #5630: [FLINK-8849][Documentation] Fix link to chaining docs

2018-03-05 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5630 We don't _require_ JIRAs for small doc fixes, whether you open one is up to you. ---

[GitHub] flink pull request #5633: [FLINK-8857] [Hbase] Avoid HBase connector read ex...

2018-03-05 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5633#discussion_r172124498 --- Diff: flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseReadExample.java --- @@ -86,8 +86,8 @@ public boolean filter

[GitHub] flink pull request #5633: [FLINK-8857] [Hbase] Avoid HBase connector read ex...

2018-03-05 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5633#discussion_r172122162 --- Diff: flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseReadExample.java --- @@ -86,8 +86,8 @@ public boolean filter

[GitHub] flink pull request #5629: [FLINK-8830][YARN] YarnResourceManager throws Null...

2018-03-04 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5629#discussion_r172105998 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java --- @@ -496,18 +496,20 @@ static ContainerLaunchContext createTaskExecutorContext

[GitHub] flink issue #5607: [hotfix][docs] Drop the incorrect parallel remark in wind...

2018-03-01 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5607 merging. ---

[GitHub] flink issue #5609: [FLINK-8822] RotateLogFile may not work well when sed ver...

2018-03-01 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5609 Not sure about this one, after all `4.2` is already _9 years old_. According to https://stackoverflow.com/questions/3139126/whats-the-difference-between-sed-e-and-sed-e and https

[GitHub] flink pull request #5612: [FLINK-8810] Move end-to-end test scripts to end-t...

2018-03-01 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5612#discussion_r171571281 --- Diff: tools/travis_mvn_watchdog.sh --- @@ -576,61 +576,9 @@ case $TEST in printf "Running end-to-end te

[GitHub] flink pull request #5612: [FLINK-8810] Move end-to-end test scripts to end-t...

2018-03-01 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5612#discussion_r171572132 --- Diff: flink-end-to-end-tests/run-pre-commit-tests.sh --- @@ -0,0 +1,98 @@ +#!/usr/bin/env bash

[GitHub] flink pull request #5607: [hotfix][docs] Drop the incorrect parallel remark ...

2018-03-01 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5607#discussion_r171506563 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/DataStream.java --- @@ -718,8 +718,7 @@ public ExecutionConfig

[GitHub] flink pull request #:

2018-02-28 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/commit/6c44d93d0a9da725ef8b1ad2a94889f79321db73#commitcomment-27855304 In flink-dist/src/main/flink-bin/bin/taskmanager.sh: In flink-dist/src/main/flink-bin/bin/taskmanager.sh on line 64

[GitHub] flink pull request #5589: [FLINK-8797] Port AbstractOperatorRestoreTestBase ...

2018-02-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5589#discussion_r171228120 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/FutureUtils.java --- @@ -223,6 +223,78

[GitHub] flink pull request #5589: [FLINK-8797] Port AbstractOperatorRestoreTestBase ...

2018-02-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5589#discussion_r171226593 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/FutureUtils.java --- @@ -223,6 +223,78

[GitHub] flink pull request #5589: [FLINK-8797] Port AbstractOperatorRestoreTestBase ...

2018-02-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5589#discussion_r171226341 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/FutureUtils.java --- @@ -223,6 +223,78

[GitHub] flink pull request #5589: [FLINK-8797] Port AbstractOperatorRestoreTestBase ...

2018-02-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5589#discussion_r171225281 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/FutureUtils.java --- @@ -223,6 +223,78

[GitHub] flink pull request #5589: [FLINK-8797] Port AbstractOperatorRestoreTestBase ...

2018-02-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5589#discussion_r171224289 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/FutureUtils.java --- @@ -223,6 +223,78

[GitHub] flink pull request #5595: [FLINK-8778] Migrate queryable state ITCases to us...

2018-02-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5595#discussion_r171221624 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java --- @@ -981,7 +981,7 @@ public Configuration getFlinkConfiguration

[GitHub] flink pull request #5596: [FLINK-8804][Build] Integrate flink-shaded 3.0

2018-02-28 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/5596 [FLINK-8804][Build] Integrate flink-shaded 3.0 ## What is the purpose of the change This PR integrates flink-shaded 3.0 . ## Brief change log * pin `flink-shaded-netty

[GitHub] flink pull request #5595: [FLINK-8778] Migrate queryable state ITCases to us...

2018-02-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5595#discussion_r171208805 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java --- @@ -981,7 +981,7 @@ public Configuration getFlinkConfiguration

[GitHub] flink pull request #5595: [FLINK-8778] Migrate queryable state ITCases to us...

2018-02-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5595#discussion_r171208315 --- Diff: flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MiniClusterResource.java --- @@ -75,6 +82,10 @@ public

[GitHub] flink pull request #5580: [FLINK-8620] Enable shipping custom files to BlobS...

2018-02-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5580#discussion_r171184258 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java --- @@ -1829,6 +1830,28 @@ public

[GitHub] flink issue #5592: [hotfix] fix javadoc link of ClusterClient#triggerSavepoi...

2018-02-28 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5592 merging. ---

[GitHub] flink pull request #5580: [FLINK-8620] Enable shipping custom files to BlobS...

2018-02-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5580#discussion_r171175263 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/filecache/FileCacheReadsFromBlobTest.java --- @@ -0,0 +1,140 @@ +/* + * Licensed

[GitHub] flink pull request #5580: [FLINK-8620] Enable shipping custom files to BlobS...

2018-02-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5580#discussion_r171175037 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/filecache/FileCacheReadsFromBlobTest.java --- @@ -0,0 +1,140 @@ +/* + * Licensed

[GitHub] flink pull request #5580: [FLINK-8620] Enable shipping custom files to BlobS...

2018-02-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5580#discussion_r171174660 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/filecache/FileCacheReadsFromBlobTest.java --- @@ -0,0 +1,140 @@ +/* + * Licensed

[GitHub] flink pull request #5580: [FLINK-8620] Enable shipping custom files to BlobS...

2018-02-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5580#discussion_r171174187 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java --- @@ -1829,6 +1830,28 @@ public

[GitHub] flink pull request #5594: [FLINK-8800][REST] Reduce logging of all requests ...

2018-02-28 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/5594 [FLINK-8800][REST] Reduce logging of all requests to TRACE The `AbstractHandler` is logging a DEBUG message for every received request. This can make the debug logs really noisy, so we're reducing

[GitHub] flink pull request #5580: [FLINK-8620] Enable shipping custom files to BlobS...

2018-02-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5580#discussion_r171171252 --- Diff: flink-optimizer/src/main/java/org/apache/flink/optimizer/plantranslate/JobGraphGenerator.java --- @@ -106,9 +106,9 @@ * are created

[GitHub] flink pull request #5590: [hotfix][REST] Fix CONTENT_TYPE header

2018-02-27 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/5590 [hotfix][REST] Fix CONTENT_TYPE header This PR reverts an accidental modification to the REST CONTENT_TYPE header used by the new rest handlers. This constants was introduced in https

[GitHub] flink pull request #5589: [FLINK-8797] Port AbstractOperatorRestoreTestBase ...

2018-02-27 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5589#discussion_r170938595 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/FutureUtils.java --- @@ -223,6 +223,77

[GitHub] flink pull request #5589: [FLINK-8797] Port AbstractOperatorRestoreTestBase ...

2018-02-27 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5589#discussion_r170937921 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/JobDetailsInfo.java --- @@ -165,6 +165,55 @@ public int hashCode

[GitHub] flink pull request #5589: [FLINK-8797] Port AbstractOperatorRestoreTestBase ...

2018-02-27 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5589#discussion_r170935501 --- Diff: flink-tests/src/test/java/org/apache/flink/test/state/operator/restore/AbstractOperatorRestoreTestBase.java --- @@ -104,175 +91,97 @@ public

[GitHub] flink issue #5580: [FLINK-8620] Enable shipping custom files to BlobStore an...

2018-02-27 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5580 I'm aware that the `RestClusterClient` currently submits jars directly to the blob service. If this PR would've been opened half a year ago I would've welcomed it with open arms. My point

[GitHub] flink pull request #5589: [FLINK-8797] Port AbstractOperatorRestoreTestBase ...

2018-02-27 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5589#discussion_r170917656 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/JobDetailsInfo.java --- @@ -165,6 +165,54 @@ public int hashCode

[GitHub] flink pull request #5589: [FLINK-8797] Port AbstractOperatorRestoreTestBase ...

2018-02-27 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5589#discussion_r170917763 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/JobDetailsInfo.java --- @@ -165,6 +165,54 @@ public int hashCode

[GitHub] flink pull request #5589: [FLINK-8797] Port AbstractOperatorRestoreTestBase ...

2018-02-27 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5589#discussion_r170917538 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/JobDetailsInfo.java --- @@ -165,6 +165,54 @@ public int hashCode

[GitHub] flink pull request #5589: [FLINK-8797] Port AbstractOperatorRestoreTestBase ...

2018-02-27 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5589#discussion_r170916096 --- Diff: flink-tests/src/test/java/org/apache/flink/test/state/operator/restore/AbstractOperatorRestoreTestBase.java --- @@ -104,175 +91,97 @@ public

[GitHub] flink pull request #5589: [FLINK-8797] Port AbstractOperatorRestoreTestBase ...

2018-02-27 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5589#discussion_r170915918 --- Diff: flink-tests/src/test/java/org/apache/flink/test/state/operator/restore/AbstractOperatorRestoreTestBase.java --- @@ -104,175 +91,97 @@ public

[GitHub] flink pull request #5589: [FLINK-8797] Port AbstractOperatorRestoreTestBase ...

2018-02-27 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5589#discussion_r170915682 --- Diff: flink-tests/src/test/java/org/apache/flink/test/state/operator/restore/AbstractOperatorRestoreTestBase.java --- @@ -104,175 +91,97 @@ public

[GitHub] flink pull request #5589: [FLINK-8797] Port AbstractOperatorRestoreTestBase ...

2018-02-27 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5589#discussion_r170915210 --- Diff: flink-tests/src/test/java/org/apache/flink/test/state/operator/restore/AbstractOperatorRestoreTestBase.java --- @@ -79,16 +62,20

[GitHub] flink issue #5580: [FLINK-8620] Enable shipping custom files to BlobStore an...

2018-02-27 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5580 As far as i know one of the end-goals of FLIP-6 is to have all client-cluster communication go through the REST API. This implies that the client cannot submit things directly to the blob service

[GitHub] flink pull request #5579: [FLINK-8778] Migrate queryable state ITCases to us...

2018-02-27 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5579#discussion_r170854988 --- Diff: flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java

[GitHub] flink pull request #5563: [FLINK-8543] Don't call super.close() in AvroKeyVa...

2018-02-26 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5563#discussion_r170628342 --- Diff: flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/AvroKeyValueSinkWriter.java --- @@ -158,7

[GitHub] flink pull request #5563: [FLINK-8543] Don't call super.close() in AvroKeyVa...

2018-02-26 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5563#discussion_r170606282 --- Diff: flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/AvroKeyValueSinkWriter.java --- @@ -158,7

[GitHub] flink pull request #5579: [FLINK-8778] Migrate queryable state ITCases to us...

2018-02-26 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5579#discussion_r170575275 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/JobDetailsInfo.java --- @@ -50,7 +50,7 @@ public static final

[GitHub] flink pull request #5579: [FLINK-8778] Migrate queryable state ITCases to us...

2018-02-26 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5579#discussion_r170573131 --- Diff: flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java

[GitHub] flink pull request #5579: [FLINK-8778] Migrate queryable state ITCases to us...

2018-02-26 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5579#discussion_r170573280 --- Diff: flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java

[GitHub] flink pull request #5579: [FLINK-8778] Migrate queryable state ITCases to us...

2018-02-26 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5579#discussion_r170572839 --- Diff: flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java

[GitHub] flink pull request #5579: [FLINK-8778] Migrate queryable state ITCases to us...

2018-02-26 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5579#discussion_r170572908 --- Diff: flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java

[GitHub] flink pull request #5579: [FLINK-8778] Migrate queryable state ITCases to us...

2018-02-26 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5579#discussion_r170573094 --- Diff: flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java

[GitHub] flink issue #5544: [FLINK-8645][configuration] Split classloader.parent-firs...

2018-02-26 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5544 merging. ---

[GitHub] flink issue #5484: [FLINK-8593][metrics] Update latency metric docs

2018-02-26 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5484 merging. ---

[GitHub] flink issue #5543: [FLINK-8596][CLI] Also catch NoClassDefFoundErrors

2018-02-26 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5543 merging. ---

[GitHub] flink pull request #5563: [FLINK-8543] Don't call super.close() in AvroKeyVa...

2018-02-26 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5563#discussion_r170530494 --- Diff: flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/AvroKeyValueSinkWriter.java --- @@ -158,7

[GitHub] flink pull request #5563: [FLINK-8543] Don't call super.close() in AvroKeyVa...

2018-02-26 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5563#discussion_r170528786 --- Diff: flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/AvroKeyValueSinkWriter.java --- @@ -158,7

[GitHub] flink pull request #5569: [FLINK-8761] [quickstarts] Big improvements to the...

2018-02-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5569#discussion_r170415569 --- Diff: flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml --- @@ -50,181 +51,113 @@ under the License

[GitHub] flink pull request #5569: [FLINK-8761] [quickstarts] Big improvements to the...

2018-02-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5569#discussion_r170415181 --- Diff: flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml --- @@ -50,181 +51,113 @@ under the License

[GitHub] flink issue #5569: [FLINK-8761] [quickstarts] Big improvements to the quicks...

2018-02-23 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5569 Building the quickstart project with the `Execute maven goal` in IntelliJ `Maven Projects` window causes `flink-dist` to be included in the jar. This also happened when disabling the IntelliJ profile

[GitHub] flink pull request #5569: [FLINK-8761] [quickstarts] Big improvements to the...

2018-02-23 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5569#discussion_r170250532 --- Diff: flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml --- @@ -50,181 +51,113 @@ under the License

[GitHub] flink pull request #5569: [FLINK-8761] [quickstarts] Big improvements to the...

2018-02-23 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5569#discussion_r170248573 --- Diff: flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml --- @@ -50,181 +51,113 @@ under the License

[GitHub] flink issue #5569: [FLINK-8761] [quickstarts] Big improvements to the quicks...

2018-02-23 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5569 The [quickstart docs|https://ci.apache.org/projects/flink/flink-docs-master/quickstart/java_api_quickstart.html] must be updated as they still list now deleted classes. ---

[GitHub] flink pull request #5569: [FLINK-8761] [quickstarts] Big improvements to the...

2018-02-23 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5569#discussion_r170245593 --- Diff: flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml --- @@ -50,181 +51,113 @@ under the License

[GitHub] flink pull request #5567: [FLINK-8451] [serializers] Make Scala tuple serial...

2018-02-23 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5567#discussion_r170215340 --- Diff: flink-core/src/main/java/org/apache/flink/util/InstantiationUtil.java --- @@ -121,10 +121,53 @@ public ClassLoaderObjectInputStream(InputStream

[GitHub] flink issue #5542: [FLINK-8703][tests] Migrate tests from LocalFlinkMiniClus...

2018-02-23 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5542 yes i think so, but I'll revert the `BigUserProgramJobSubmitITCase` port. It's not testing the actual codepath for job submission (which i guess would be the `RestClusterClient`) and thus provides

[GitHub] flink issue #5552: [FLINK-8735] Add new StatefulJobSavepointMigrationITCase

2018-02-22 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5552 looks good to me ---

[GitHub] flink pull request #5552: [FLINK-8735] Add new StatefulJobSavepointMigration...

2018-02-22 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5552#discussion_r169920122 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/StatefulJobSavepointMigrationITCase.java --- @@ -0,0 +1,658

[GitHub] flink issue #5543: [FLINK-8596][CLI] Also catch NoClassDefFoundErrors

2018-02-22 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5543 E2E test isn't fully working yet, debugging... ---

[GitHub] flink pull request #5552: [FLINK-8735] Add new StatefulJobSavepointMigration...

2018-02-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5552#discussion_r169741935 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/StatefulJobSavepointMigrationITCase.java --- @@ -0,0 +1,658

[GitHub] flink pull request #5552: [FLINK-8735] Add new StatefulJobSavepointMigration...

2018-02-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5552#discussion_r169734512 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/StatefulJobSavepointMigrationITCase.java --- @@ -0,0 +1,658

[GitHub] flink pull request #5552: [FLINK-8735] Add new StatefulJobSavepointMigration...

2018-02-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5552#discussion_r169742676 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/StatefulJobSavepointMigrationITCase.java --- @@ -0,0 +1,658

[GitHub] flink pull request #5554: [FLINK-8729][streaming] Refactor JSONGenerator to ...

2018-02-21 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/5554 [FLINK-8729][streaming] Refactor JSONGenerator to use jackson ## What is the purpose of the change This PR ports the `JSONGenerator` to rely on jackson instead of `org.apache.sling

[GitHub] flink pull request #5552: [FLINK-8735] Add new StatefulJobSavepointMigration...

2018-02-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5552#discussion_r169743891 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/StatefulJobSavepointMigrationITCase.java --- @@ -0,0 +1,658

[GitHub] flink pull request #5552: [FLINK-8735] Add new StatefulJobSavepointMigration...

2018-02-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5552#discussion_r169741385 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/StatefulJobSavepointMigrationITCase.java --- @@ -0,0 +1,658

[GitHub] flink pull request #5552: [FLINK-8735] Add new StatefulJobSavepointMigration...

2018-02-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5552#discussion_r169745602 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/LegacyStatefulJobSavepointMigrationITCase.java --- @@ -0,0 +1,663

[GitHub] flink pull request #5552: [FLINK-8735] Add new StatefulJobSavepointMigration...

2018-02-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5552#discussion_r169740338 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/StatefulJobSavepointMigrationITCase.java --- @@ -0,0 +1,658

[GitHub] flink pull request #5552: [FLINK-8735] Add new StatefulJobSavepointMigration...

2018-02-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5552#discussion_r169738273 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/LegacyStatefulJobSavepointMigrationITCase.java --- @@ -0,0 +1,663

[GitHub] flink pull request #5542: [FLINK-8703][tests] Migrate tests from LocalFlinkM...

2018-02-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5542#discussion_r169714628 --- Diff: flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/BigUserProgramJobSubmitITCase.java --- @@ -43,40 +40,27

[GitHub] flink pull request #5544: [FLINK-8645][configuration] Split classloader.pare...

2018-02-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5544#discussion_r169699380 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java --- @@ -86,11 +86,42 @@ * */ public static

[GitHub] flink issue #5544: [FLINK-8645][configuration] Split classloader.parent-firs...

2018-02-21 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5544 I've changed the keys to "default" and "additional" and also renamed the `ConfigOptions` to `ALWAYS_PARENT_FIRST_LOADER_PATTERNS[_ADDITIONAL]`. ---

[GitHub] flink issue #5547: [FLINK-8704] [tests] Port AccumulatorLiveITCase to MiniCl...

2018-02-21 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5547 I would ask you to stop working on this issue. You do not know what changes are required to properly port these tests. Adding a `MiniClusterResource` (or extend `AbstractTestBase

[GitHub] flink pull request #5544: [FLINK-8645][configuration] Split classloader.pare...

2018-02-21 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/5544 [FLINK-8645][configuration] Split classloader.parent-first-patterns into "base" and "append ## What is the purpose of the change This PR splits the `classloader.parent

[GitHub] flink pull request #5543: [FLINK-8596][CLI] Also catch NoClassDefFoundErrors

2018-02-21 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/5543 [FLINK-8596][CLI] Also catch NoClassDefFoundErrors ## What is the purpose of the change This PR modifies the CliFrontend to also catch `NoClassDefFoundErrors` when loading the YARN CLI

[GitHub] flink issue #5497: Propose fixing some typos

2018-02-21 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5497 It's fine, I'll merge it and add the spaces back while doing so. ---

<    7   8   9   10   11   12   13   14   15   16   >