GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/4156
[FLINK-6655] Add validateAndNormalizeUri method to MemoryArchivist
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into
Github user zhangminglei closed the pull request at:
https://github.com/apache/flink/pull/4155
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/4155
Flink 6655 misleading error message historyserver
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4151
cc @tedyu
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/4151
[FLINK-6389] [connector] Upgrade hbase dependency to 1.3.1
Upgrade to the last maintenance releases of hbase 1.3.1
You can merge this pull request into a Git repository by running:
$ git
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4074
Also say thanks to you ~ :XD
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4125
Thanks for your review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/4125#discussion_r122953813
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java
---
@@ -464,6 +464,14 @@ private void
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/4074#discussion_r122940544
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -472,7 +472,7 @@ class JobManager
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/4074#discussion_r122934898
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -472,7 +472,7 @@ class JobManager
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4125
Thank you so much @zentol . I did learn a lot from those. Also, the code
have been updated. Please review. Thanks again.
---
If your project is set up for it, you can reply to this email and
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/4125#discussion_r122869047
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java
---
@@ -225,7 +225,16 @@ private void
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4131
cc @zentol Please take a look. Thank you so much. :cake:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4074
@zentol It seems weird why this stuff happened. I have updated the code
though. It looks good now.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4074
@zentol OMG. I see now. OKay, I will take a look. Thanks a bunch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4074
It seems that I didnt do anything relevant to the file permissions. Does
not make sense.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4074
Sorry, I dont know what you exactly mean. I just modified the scripts. Why
did I modify the permissions of this file ? I really need your help. Thanks.
---
If your project is set up for it
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/4131#discussion_r122348284
--- Diff: docs/dev/event_time.md ---
@@ -146,7 +146,7 @@ to use timestamp assignment and watermark generation in
the Flink DataStream API
*Note
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/4131
[FLINK-6932] [doc] Update inaccessible Dataflow Model paper link
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4125
Hi @zentol . Please helps review if you are free, should I add some extra
information ? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/4125
[FLINK-6682] [checkpoints] Improve error message in case parallelism â¦
â¦exceeds maxParallelism
Thanks for contributing to Apache Flink. Before you open your pull request,
please
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4074
@zentol Thanks a bunch for your review. I have updated the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4074
@zentol Ops. I was wrong. I also did the same thing in
```stop-local.sh```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4074
@greghogan Thanks. I just forgot update the title, it is not remove but
deprecated instead. And I would suggest you can take a look at this jira
https://issues.apache.org/jira/browse/FLINK-6488
Github user zhangminglei closed the pull request at:
https://github.com/apache/flink/pull/4049
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/4074
[FLINK-6488] [scripts] Remove 'start-local.sh' script
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into con
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/4049
[FLINK-6643] [JobManager] Flink restarts job in HA even if NoRestartSâ¦
â¦trategy is set
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3755
Hey, @shuai-xu. Is there a corresponding JIRA for what you said ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3898
Hi, @huafengw Welcome also.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zhangminglei closed the pull request at:
https://github.com/apache/flink/pull/3820
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3820
@kl0u Okay. I will do this soon. Thanks again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3820
Thanks for review @kl0u and the travis had gave us the green light. Very
appreciate it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3820
Hi, @kl0u. It would be great if you can take a look at this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/3820
[FLINK-6381] [connector] Unnecessary synchronizing object in Bucketinâ¦
Currently there are two places should not employ the synchronized to
describe ```pendingFilesPerCheckpoint```, as it is
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3724
@StephanEwen Thanks. I might close this PR as there is a refactor to
```YarnFlinkApplicationMasterRunner ``` by combining with
```AbstractYarnFlinkApplicationMasterRunner``` in one class. See
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3812
@zentol Sorry. I just drunk. My mean is we can use ```git rebase -i
origin/master``` to combine lots of commit logs into one log and then use
```git push origin -f branch_issueId``` push to
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3750
Hi, @tzulitai. I have updated the code according to your suggestions. BTW,
I didnt do anything change in ```snapshotState``` as it seems nothing I should
do. Please improve my mind if necessary
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3812
```git push upstream -f xxx ``` DOES NOT WORK for squashed it ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/3812#discussion_r114501444
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericWriteAheadSink.java
---
@@ -88,15 +93,23 @@ public
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/3812#discussion_r114500999
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericWriteAheadSink.java
---
@@ -88,15 +93,23 @@ public
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3812
@fanyon Another suggestion here. Make the lots of commit log into one log
is nice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/3812#discussion_r114499181
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericWriteAheadSink.java
---
@@ -88,15 +93,23 @@ public
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/3812#discussion_r114483460
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericWriteAheadSink.java
---
@@ -23,7 +23,9 @@
import
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3750
Hi @tzulitai Could you please take a look on this PR ? Thanks and very
appreciate it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3730
@tillrohrmann Thanks for telling me so useful information. very appreciate
it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user zhangminglei closed the pull request at:
https://github.com/apache/flink/pull/3730
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zhangminglei closed the pull request at:
https://github.com/apache/flink/pull/3758
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3758
@kl0u Yep. I reopened this PR again for waiting you message me. Haha ~
Okay, Now, I will close it and then create another jira and cc you.
---
If your project is set up for it, you can reply
GitHub user zhangminglei reopened a pull request:
https://github.com/apache/flink/pull/3758
[FLINK-5855][Streaming Connectors] Unprotected access to pendingFilesâ¦
â¦PerCheckpoint in BucketingSink.
Thanks for contributing to Apache Flink. Before you open your pull request
Github user zhangminglei closed the pull request at:
https://github.com/apache/flink/pull/3758
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3758
@kl0u Thanks for review , very appreciate it. Yep, BTW, I would like to
work on what you will thorough the code in the following days and keep watching
this class ```synchronized()```. Hopes
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3755
cc @tillrohrmann
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/3758
[FLINK-5855][Streaming Connectors] Unprotected access to pendingFilesâ¦
â¦PerCheckpoint in BucketingSink.
Thanks for contributing to Apache Flink. Before you open your pull request
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3758
cc @tillrohrmann
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/3755
[FLINK-6351] [YARN] Refactoring YarnFlinkApplicationMasterRunner by câ¦
â¦ombining AbstractYarnFlinkApplicationMasterRunner in one class.
Thanks for contributing to Apache Flink
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/3750
[FLINK-6345] [Streaming] Migrate from Java serialization for Continuoâ¦
â¦usFileReaderOperator's state.
Thanks for contributing to Apache Flink. Before you open your pull re
Github user zhangminglei closed the pull request at:
https://github.com/apache/flink/pull/3726
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3726
@tillrohrmann That is right. We can close this PR surely. BTW, Should we
make another jira refactoring this class and
```AbstractYarnFlinkApplicationMasterRunner ``` ? Because I watch the
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3726
@zentol Please helps review. I am very appreciate it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3726
@StephanEwen Hi, How do you think of this refine ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3738
@tzulitai You are very welcome . It is my pleasure ~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3738
@tzulitai Hi, I have updated the code. Please check it out. Thanks and
appreciate it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3738
@StephanEwen @tzulitai Thanks for telling me so useful information. I will
fix it soon enough. Very appreciate it.
---
If your project is set up for it, you can reply to this email and have
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3738
@StephanEwen Shouldn't we also make ```shardConsumersExecutor``` variable
```volatile``` as well ?
---
If your project is set up for it, you can reply to this email and have your
reply a
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/3738
[FLINK-6311] [Kinesis Connector] NPE in FlinkKinesisConsumer if sourcâ¦
â¦e was closed before run.
Thanks for contributing to Apache Flink. Before you open your pull request,
please
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/3730
[FLINK-5943] [YARN] Fix unprotected access to haServices in YarnFlinkâ¦
â¦ApplicationMasterRunner#shutdown().
Thanks for contributing to Apache Flink. Before you open your pull
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3728
@tzulitai Hi, Could you please review those code ? Thanks and appreciate ~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/3726#discussion_r111732371
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnFlinkApplicationMasterRunner.java
---
@@ -158,14 +160,16 @@ protected int
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3726
Travis sucks some time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/3726#discussion_r111731104
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnFlinkApplicationMasterRunner.java
---
@@ -158,14 +160,16 @@ protected int
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3726
@tzulitai Hi, Could you please review my code ? I am appreciate it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/3728
[FLINK-6313] [flink-runtime] Fix Some words was spelled wrong and incâ¦
â¦orrect LOG.error without print.
Thanks for contributing to Apache Flink. Before you open your pull request
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3726
@tedyu @zentol It seems there is a problem with travis-ci test if no output
within 5 mins then it will print the stacktrace and then kill the watchdog ,
please help to review and checkout how
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/3726
[FLINK-6130] [yarn] Fix Consider calling resourceManager#getTerminatiâ¦
â¦onFuture() with lock held.
Thanks for contributing to Apache Flink. Before you open your pull request
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/3725
[FLINK-6104] Fix resource leak in ListViaRangeSpeedMiniBenchmark.
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/3724
[FLINK-6275] [yarn] Fix unprotected access to resourceManage in YarnFâ¦
â¦linkApplicationMasterRunner.
Thanks for contributing to Apache Flink. Before you open your pull request
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3707
@zentol Could you please reopen this pr again ? It seems belong to my
misoperation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user zhangminglei closed the pull request at:
https://github.com/apache/flink/pull/3707
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3710
@zentol I am appreciate it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3710
@zentol I have updated the code. Thanks again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/3710#discussion_r111666520
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/LocalExecutor.java ---
@@ -59,7 +59,7 @@
private final Object lock = new Object
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/3710#discussion_r111666373
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/LocalExecutor.java ---
@@ -59,7 +59,7 @@
private final Object lock = new Object
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/3710
[FLINK-6143] [clients] Fix unprotected access to this.flink in LocalEâ¦
â¦xecutor#endSession.
Thanks for contributing to Apache Flink. Before you open your pull request,
please take
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3707
@rmetzger @greghogan Could you please take some time review my code ? Many
thanks to you both.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/3707
[FLINK-6275] [yarn] Fix unprotected access to resourceManage in
YarnFlinkApplicationMasterRunner
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the
501 - 585 of 585 matches
Mail list logo
