Airblader commented on pull request #17133:
URL: https://github.com/apache/flink/pull/17133#issuecomment-971381711
I've rebased the PR and addressed most of the feedback; in particular, I've
changed it to not check API annotations on the enclosing class anymore but on
the classes
Airblader commented on pull request #17133:
URL: https://github.com/apache/flink/pull/17133#issuecomment-929092061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Airblader commented on pull request #17133:
URL: https://github.com/apache/flink/pull/17133#issuecomment-929095947
FWIW, ensuring that all classes have such an annotation is something that,
if at all, I'd do in Checkstyle because you really want that to be immediate
feedback to reduce
Airblader commented on pull request #17133:
URL: https://github.com/apache/flink/pull/17133#issuecomment-929092061
> Because of that I'm worried that we'd just end up slapping @PublicEvolving
on everything
While I understand what you're getting at, this is a human problem that
Airblader commented on pull request #17133:
URL: https://github.com/apache/flink/pull/17133#issuecomment-927608002
Thanks! That's good to know, and clearly not how flink-table currently seems
to do it. Would it make sense to enforce that _all_ (public?) classes (maybe
except for a
Airblader commented on pull request #17133:
URL: https://github.com/apache/flink/pull/17133#issuecomment-922802666
That makes a lot of sense. I can adjust the rules to reflect that. The
question which remains, however, is whether annotating all (nested) classes or
only top-level classes
Airblader commented on pull request #17133:
URL: https://github.com/apache/flink/pull/17133#issuecomment-919799883
@zentol In that case we probably need to more clearly define how annotations
should be used in the project first as we'd very strictly want to forbid any
new violations
Airblader commented on pull request #17133:
URL: https://github.com/apache/flink/pull/17133#issuecomment-916683241
@zentol To reply to a bunch of your points at once: I think we should hit a
"sweet spot" with the rules not being too complex. For example, if we allow
Experimental methods
