[GitHub] [flink] KarmaGYZ commented on a change in pull request #14897: [FLINK-21221][runtime] Deduplication for multiple ResourceCounters

2021-02-18 Thread GitBox
KarmaGYZ commented on a change in pull request #14897: URL: https://github.com/apache/flink/pull/14897#discussion_r578874000 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/BiDirectionalResourceToRequirementMapping.java ## @@

[GitHub] [flink] KarmaGYZ commented on a change in pull request #14897: [FLINK-21221][runtime] Deduplication for multiple ResourceCounters

2021-02-18 Thread GitBox
KarmaGYZ commented on a change in pull request #14897: URL: https://github.com/apache/flink/pull/14897#discussion_r578870795 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DeclarativeSlotManager.java ## @@ -600,61 +603,69 @@

[GitHub] [flink] KarmaGYZ commented on a change in pull request #14897: [FLINK-21221][runtime] Deduplication for multiple ResourceCounters

2021-02-10 Thread GitBox
KarmaGYZ commented on a change in pull request #14897: URL: https://github.com/apache/flink/pull/14897#discussion_r573748650 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/util/ResourceCounter.java ## @@ -35,11 +37,12 @@ * associated counts. The counts

[GitHub] [flink] KarmaGYZ commented on a change in pull request #14897: [FLINK-21221][runtime] Deduplication for multiple ResourceCounters

2021-02-10 Thread GitBox
KarmaGYZ commented on a change in pull request #14897: URL: https://github.com/apache/flink/pull/14897#discussion_r573574434 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/util/ResourceCounter.java ## @@ -35,11 +37,12 @@ * associated counts. The counts

[GitHub] [flink] KarmaGYZ commented on a change in pull request #14897: [FLINK-21221][runtime] Deduplication for multiple ResourceCounters

2021-02-10 Thread GitBox
KarmaGYZ commented on a change in pull request #14897: URL: https://github.com/apache/flink/pull/14897#discussion_r573589144 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/util/ResourceCounter.java ## @@ -35,11 +37,12 @@ * associated counts. The counts

[GitHub] [flink] KarmaGYZ commented on a change in pull request #14897: [FLINK-21221][runtime] Deduplication for multiple ResourceCounters

2021-02-10 Thread GitBox
KarmaGYZ commented on a change in pull request #14897: URL: https://github.com/apache/flink/pull/14897#discussion_r573574434 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/util/ResourceCounter.java ## @@ -35,11 +37,12 @@ * associated counts. The counts

[GitHub] [flink] KarmaGYZ commented on a change in pull request #14897: [FLINK-21221][runtime] Deduplication for multiple ResourceCounters

2021-02-10 Thread GitBox
KarmaGYZ commented on a change in pull request #14897: URL: https://github.com/apache/flink/pull/14897#discussion_r573574434 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/util/ResourceCounter.java ## @@ -35,11 +37,12 @@ * associated counts. The counts

[GitHub] [flink] KarmaGYZ commented on a change in pull request #14897: [FLINK-21221][runtime] Deduplication for multiple ResourceCounters

2021-02-09 Thread GitBox
KarmaGYZ commented on a change in pull request #14897: URL: https://github.com/apache/flink/pull/14897#discussion_r573402886 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/util/ResourceCounter.java ## @@ -35,11 +37,12 @@ * associated counts. The counts

[GitHub] [flink] KarmaGYZ commented on a change in pull request #14897: [FLINK-21221][runtime] Deduplication for multiple ResourceCounters

2021-02-08 Thread GitBox
KarmaGYZ commented on a change in pull request #14897: URL: https://github.com/apache/flink/pull/14897#discussion_r572517152 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/util/ResourceCounter.java ## @@ -35,11 +37,12 @@ * associated counts. The counts

[GitHub] [flink] KarmaGYZ commented on a change in pull request #14897: [FLINK-21221][runtime] Deduplication for multiple ResourceCounters

2021-02-08 Thread GitBox
KarmaGYZ commented on a change in pull request #14897: URL: https://github.com/apache/flink/pull/14897#discussion_r572517152 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/util/ResourceCounter.java ## @@ -35,11 +37,12 @@ * associated counts. The counts

[GitHub] [flink] KarmaGYZ commented on a change in pull request #14897: [FLINK-21221][runtime] Deduplication for multiple ResourceCounters

2021-02-08 Thread GitBox
KarmaGYZ commented on a change in pull request #14897: URL: https://github.com/apache/flink/pull/14897#discussion_r572511815 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/util/ResourceCounter.java ## @@ -35,11 +37,12 @@ * associated counts. The counts

[GitHub] [flink] KarmaGYZ commented on a change in pull request #14897: [FLINK-21221][runtime] Deduplication for multiple ResourceCounters

2021-02-08 Thread GitBox
KarmaGYZ commented on a change in pull request #14897: URL: https://github.com/apache/flink/pull/14897#discussion_r572511815 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/util/ResourceCounter.java ## @@ -35,11 +37,12 @@ * associated counts. The counts