[GitHub] [flink] RocMarshal commented on a diff in pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn

2022-05-16 Thread GitBox
RocMarshal commented on code in PR #18983: URL: https://github.com/apache/flink/pull/18983#discussion_r873713634 ## flink-yarn/src/test/java/org/apache/flink/yarn/entrypoint/YarnEntrypointUtilsTest.java: ## @@ -132,37 +130,36 @@ public void testDynamicParameterOverloading()

[GitHub] [flink] RocMarshal commented on a diff in pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn

2022-05-06 Thread GitBox
RocMarshal commented on code in PR #18983: URL: https://github.com/apache/flink/pull/18983#discussion_r866856860 ## flink-yarn/src/test/java/org/apache/flink/yarn/TaskExecutorProcessSpecContainerResourcePriorityAdapterTest.java: ## @@ -206,40 +199,49 @@ public void

[GitHub] [flink] RocMarshal commented on a diff in pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn

2022-05-05 Thread GitBox
RocMarshal commented on code in PR #18983: URL: https://github.com/apache/flink/pull/18983#discussion_r865949794 ## flink-yarn/src/test/java/org/apache/flink/yarn/RegisterApplicationMasterResponseReflectorTest.java: ## @@ -125,24 +119,22 @@ public void

[GitHub] [flink] RocMarshal commented on a diff in pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn

2022-05-05 Thread GitBox
RocMarshal commented on code in PR #18983: URL: https://github.com/apache/flink/pull/18983#discussion_r865949498 ## flink-yarn/src/test/java/org/apache/flink/yarn/YarnFileStageTestS3ITCase.java: ## @@ -173,36 +175,44 @@ private void testRecursiveUploadForYarn(String scheme,

[GitHub] [flink] RocMarshal commented on a diff in pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn

2022-05-05 Thread GitBox
RocMarshal commented on code in PR #18983: URL: https://github.com/apache/flink/pull/18983#discussion_r865949156 ## flink-yarn/src/test/java/org/apache/flink/yarn/YarnFileStageTestS3ITCase.java: ## @@ -173,36 +175,44 @@ private void testRecursiveUploadForYarn(String scheme,

[GitHub] [flink] RocMarshal commented on a diff in pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn

2022-05-05 Thread GitBox
RocMarshal commented on code in PR #18983: URL: https://github.com/apache/flink/pull/18983#discussion_r865948929 ## flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerDriverTest.java: ## @@ -293,9 +304,22 @@ public void testTerminationWaitsOnContainerStopError()

[GitHub] [flink] RocMarshal commented on a diff in pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn

2022-05-05 Thread GitBox
RocMarshal commented on code in PR #18983: URL: https://github.com/apache/flink/pull/18983#discussion_r865948556 ## flink-yarn/src/test/java/org/apache/flink/yarn/TaskExecutorProcessSpecContainerResourcePriorityAdapterTest.java: ## @@ -206,40 +199,49 @@ public void

[GitHub] [flink] RocMarshal commented on a diff in pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn

2022-05-05 Thread GitBox
RocMarshal commented on code in PR #18983: URL: https://github.com/apache/flink/pull/18983#discussion_r865888036 ## flink-yarn/src/test/java/org/apache/flink/yarn/entrypoint/YarnEntrypointUtilsTest.java: ## @@ -132,37 +130,36 @@ public void testDynamicParameterOverloading()

[GitHub] [flink] RocMarshal commented on a diff in pull request #18983: [FLINK-25543][flink-yarn] [JUnit5 Migration] Module: flink-yarn

2022-05-05 Thread GitBox
RocMarshal commented on code in PR #18983: URL: https://github.com/apache/flink/pull/18983#discussion_r865877140 ## flink-yarn/src/test/java/org/apache/flink/yarn/YarnFileStageTestS3ITCase.java: ## @@ -24,71 +24,70 @@ import org.apache.flink.core.fs.FileSystem; import