[GitHub] [flink] RocMarshal commented on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number o

2021-12-08 Thread GitBox
RocMarshal commented on pull request #17692: URL: https://github.com/apache/flink/pull/17692#issuecomment-988966271 @AHeise Thank you very much for your comments, which makes us closer to higher quality step by step. It's really great. I have benefited a lot. I have been striving for

[GitHub] [flink] RocMarshal commented on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number o

2021-11-26 Thread GitBox
RocMarshal commented on pull request #17692: URL: https://github.com/apache/flink/pull/17692#issuecomment-979931489 @AHeise Thank you very much for your help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] RocMarshal commented on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number o

2021-11-16 Thread GitBox
RocMarshal commented on pull request #17692: URL: https://github.com/apache/flink/pull/17692#issuecomment-970413494 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] RocMarshal commented on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number o

2021-11-15 Thread GitBox
RocMarshal commented on pull request #17692: URL: https://github.com/apache/flink/pull/17692#issuecomment-969035044 > The situation is a bit odd. I think we shouldn't have a cache on top of rocks DB at all. We could think about having a cache in rocks DB itself. > > Nevertheless,

[GitHub] [flink] RocMarshal commented on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number o

2021-11-11 Thread GitBox
RocMarshal commented on pull request #17692: URL: https://github.com/apache/flink/pull/17692#issuecomment-966724208 > What are you trying to solve? Could you please fill out the PR form correctly? I understand what your are doing on technical side but I don't understand why it's

[GitHub] [flink] RocMarshal commented on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number o

2021-11-08 Thread GitBox
RocMarshal commented on pull request #17692: URL: https://github.com/apache/flink/pull/17692#issuecomment-963105801 @Airblader Could you help me to review this pr ? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub