[GitHub] [flink] XComp commented on a diff in pull request #21349: [FLINK-28203] Support Maven 3.3+

XComp commented on code in PR #21349: URL: https://github.com/apache/flink/pull/21349#discussion_r1191307099 ## tools/ci/flink-ci-tools/src/main/java/org/apache/flink/tools/ci/optional/ShadeOptionalChecker.java: ## @@ -0,0 +1,266 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] XComp commented on a diff in pull request #21349: [FLINK-28203] Support Maven 3.3+

XComp commented on code in PR #21349: URL: https://github.com/apache/flink/pull/21349#discussion_r1190985790 ## flink-formats/flink-sql-parquet/pom.xml: ## @@ -42,12 +42,14 @@ under the License. org.apache.flink flink-parquet

[GitHub] [flink] XComp commented on a diff in pull request #21349: [FLINK-28203] Support Maven 3.3+

XComp commented on code in PR #21349: URL: https://github.com/apache/flink/pull/21349#discussion_r1186303817 ## tools/ci/flink-ci-tools/src/main/java/org/apache/flink/tools/ci/optional/ShadeOptionalChecker.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] XComp commented on a diff in pull request #21349: [FLINK-28203] Support Maven 3.3+

XComp commented on code in PR #21349: URL: https://github.com/apache/flink/pull/21349#discussion_r1186303817 ## tools/ci/flink-ci-tools/src/main/java/org/apache/flink/tools/ci/optional/ShadeOptionalChecker.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] XComp commented on a diff in pull request #21349: [FLINK-28203] Support Maven 3.3+

XComp commented on code in PR #21349: URL: https://github.com/apache/flink/pull/21349#discussion_r1183460705 ## tools/ci/flink-ci-tools/src/main/java/org/apache/flink/tools/ci/optional/ShadeOptionalChecker.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] XComp commented on a diff in pull request #21349: [FLINK-28203] Support Maven 3.3+

XComp commented on code in PR #21349: URL: https://github.com/apache/flink/pull/21349#discussion_r1183614145 ## flink-python/pom.xml: ## Review Comment: I assumed that we would have to add the optional flag to the dependencies under `` as well? ...at least, we did this in

[GitHub] [flink] XComp commented on a diff in pull request #21349: [FLINK-28203] Support Maven 3.3+

XComp commented on code in PR #21349: URL: https://github.com/apache/flink/pull/21349#discussion_r1183847811 ## flink-dist/pom.xml: ## Review Comment: This one is answered already: `flink-dist` bundles all the dependencies and, therefore, needs to annotate all

[GitHub] [flink] XComp commented on a diff in pull request #21349: [FLINK-28203] Support Maven 3.3+

XComp commented on code in PR #21349: URL: https://github.com/apache/flink/pull/21349#discussion_r1182404771 ## tools/ci/verify_bundled_optional.sh: ## @@ -0,0 +1,48 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one or more +#