[GitHub] [flink] matriv commented on a change in pull request #18162: [FLINK-25187][table-planner] Apply padding when CASTing to BINARY()

2021-12-30 Thread GitBox
matriv commented on a change in pull request #18162: URL: https://github.com/apache/flink/pull/18162#discussion_r774482163 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/BinaryToBinaryCastRule.java ## @@ -60,18 +62,

[GitHub] [flink] matriv commented on a change in pull request #18162: [FLINK-25187][table-planner] Apply padding when CASTing to BINARY()

2021-12-23 Thread GitBox
matriv commented on a change in pull request #18162: URL: https://github.com/apache/flink/pull/18162#discussion_r774482163 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/BinaryToBinaryCastRule.java ## @@ -60,18 +62,

[GitHub] [flink] matriv commented on a change in pull request #18162: [FLINK-25187][table-planner] Apply padding when CASTing to BINARY()

2021-12-23 Thread GitBox
matriv commented on a change in pull request #18162: URL: https://github.com/apache/flink/pull/18162#discussion_r774481392 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/BinaryToBinaryCastRule.java ## @@ -60,18 +62,

[GitHub] [flink] matriv commented on a change in pull request #18162: [FLINK-25187][table-planner] Apply padding when CASTing to BINARY()

2021-12-23 Thread GitBox
matriv commented on a change in pull request #18162: URL: https://github.com/apache/flink/pull/18162#discussion_r774479369 ## File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/casting/CastRulesTest.java ## @@ -656,6 +656,13 @@

[GitHub] [flink] matriv commented on a change in pull request #18162: [FLINK-25187][table-planner] Apply padding when CASTing to BINARY()

2021-12-23 Thread GitBox
matriv commented on a change in pull request #18162: URL: https://github.com/apache/flink/pull/18162#discussion_r774448157 ## File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/casting/CastRulesTest.java ## @@ -656,13 +656,6 @@