snuyanzin commented on PR #22624:
URL: https://github.com/apache/flink/pull/22624#issuecomment-1618312678
@zhougit86 thanks for the contribution
are you willing to create backports to 1.17.x, 1.16.x?
--
This is an automated message from the Apache Git Service.
To respond to the
snuyanzin commented on PR #22624:
URL: https://github.com/apache/flink/pull/22624#issuecomment-1612073732
@zhougit86 sorry for the late response
I have a question: could you please clarify it
it seems your change is inside condition
```scala
if
snuyanzin commented on PR #22624:
URL: https://github.com/apache/flink/pull/22624#issuecomment-1599038504
also could you please rebase to the latest master?
The failure was fixed in later commits, so rebase should help with passing
tests
--
This is an automated message from the Apache
snuyanzin commented on PR #22624:
URL: https://github.com/apache/flink/pull/22624#issuecomment-1598826176
hmm, it looks like you renamed class however not renamed file... could you
also please rename file in order to have them in sync?
--
This is an automated message from the Apache Git
snuyanzin commented on PR #22624:
URL: https://github.com/apache/flink/pull/22624#issuecomment-1596941999
hi @zhougit86
it looks ok from my side thanks for addressing comments
the only nit pick: could you please rename `CastFunctionMiscITLegacyCase` in
way that it matches regex
