[GitHub] [flink] twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-08-02 Thread GitBox
twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#discussion_r310108126 ## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/type/

[GitHub] [flink] twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-08-02 Thread GitBox
twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#discussion_r310018499 ## File path: flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/Flink

[GitHub] [flink] twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-08-01 Thread GitBox
twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#discussion_r310001855 ## File path: flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/Fixtu

[GitHub] [flink] twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-08-01 Thread GitBox
twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#discussion_r31332 ## File path: flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl

[GitHub] [flink] twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-08-01 Thread GitBox
twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#discussion_r30347 ## File path: flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/Flink

[GitHub] [flink] twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-08-01 Thread GitBox
twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#discussion_r309779118 ## File path: flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/Flink

[GitHub] [flink] twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-08-01 Thread GitBox
twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#discussion_r309778088 ## File path: flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/Flink

[GitHub] [flink] twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-08-01 Thread GitBox
twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#discussion_r309753253 ## File path: flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl

[GitHub] [flink] twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-07-31 Thread GitBox
twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#discussion_r309179341 ## File path: flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/Fixtu

[GitHub] [flink] twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-07-31 Thread GitBox
twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#discussion_r309182163 ## File path: flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/Fixtu

[GitHub] [flink] twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-07-31 Thread GitBox
twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#discussion_r309180440 ## File path: flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/Flink

[GitHub] [flink] twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-07-31 Thread GitBox
twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#discussion_r309191464 ## File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/runtim

[GitHub] [flink] twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-07-31 Thread GitBox
twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#discussion_r309190370 ## File path: flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/Flink

[GitHub] [flink] twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-07-31 Thread GitBox
twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#discussion_r309173413 ## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/Flink

[GitHub] [flink] twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-07-31 Thread GitBox
twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#discussion_r309183894 ## File path: flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/Flink

[GitHub] [flink] twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-07-31 Thread GitBox
twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#discussion_r309180938 ## File path: flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/Flink

[GitHub] [flink] twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-07-31 Thread GitBox
twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#discussion_r309175903 ## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/type/

[GitHub] [flink] twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-07-31 Thread GitBox
twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#discussion_r309184547 ## File path: flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/Flink

[GitHub] [flink] twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-07-31 Thread GitBox
twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#discussion_r309191034 ## File path: flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/Flink

[GitHub] [flink] twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-07-31 Thread GitBox
twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#discussion_r309173062 ## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/Flink

[GitHub] [flink] twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-07-31 Thread GitBox
twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#discussion_r309172263 ## File path: flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl

[GitHub] [flink] twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-07-31 Thread GitBox
twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#discussion_r309176530 ## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/type/

[GitHub] [flink] twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-07-31 Thread GitBox
twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#discussion_r309169277 ## File path: flink-table/flink-sql-parser/src/main/codegen/data/Parser.tdd ## @@

[GitHub] [flink] twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-07-31 Thread GitBox
twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#discussion_r309181743 ## File path: flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/Flink

[GitHub] [flink] twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-07-31 Thread GitBox
twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#discussion_r309174185 ## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/Flink

[GitHub] [flink] twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-07-31 Thread GitBox
twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#discussion_r309170046 ## File path: flink-table/flink-sql-parser/src/main/codegen/data/Parser.tdd ## @@

[GitHub] [flink] twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-07-31 Thread GitBox
twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#discussion_r309173603 ## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/Flink

[GitHub] [flink] twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37

2019-07-31 Thread GitBox
twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#discussion_r309171226 ## File path: flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl