[GitHub] [flink] xuyang1706 commented on issue #9373: [FLINK-13596][ml] Add two utils for Table transformations

2019-12-03 Thread GitBox
xuyang1706 commented on issue #9373: [FLINK-13596][ml] Add two utils for Table transformations URL: https://github.com/apache/flink/pull/9373#issuecomment-561459523 > Thanks for the explanation @xuyang1706 and sorry for not making my comments clear. please kindly take a look at my follow

[GitHub] [flink] xuyang1706 commented on issue #9373: [FLINK-13596][ml] Add two utils for Table transformations

2019-11-08 Thread GitBox
xuyang1706 commented on issue #9373: [FLINK-13596][ml] Add two utils for Table transformations URL: https://github.com/apache/flink/pull/9373#issuecomment-551506390 > Hi @xuyang1706 thanks for the update. I just did another pass and find that some of the branches are missing test cases;

[GitHub] [flink] xuyang1706 commented on issue #9373: [FLINK-13596][ml] Add two utils for Table transformations

2019-10-30 Thread GitBox
xuyang1706 commented on issue #9373: [FLINK-13596][ml] Add two utils for Table transformations URL: https://github.com/apache/flink/pull/9373#issuecomment-547874123 > Thanks for the contribution @xuyang1706 and sorry for the late review. > > Overall the utility looks good and to me

[GitHub] [flink] xuyang1706 commented on issue #9373: [FLINK-13596][ml] Add two utils for Table transformations

2019-09-30 Thread GitBox
xuyang1706 commented on issue #9373: [FLINK-13596][ml] Add two utils for Table transformations URL: https://github.com/apache/flink/pull/9373#issuecomment-536425226 > Thanks for the contribution @xuyang1706. looks like this PR depends on #9184 yes? @walterddr , yes, you are right.