[GitHub] [flink] zentol commented on a diff in pull request #21296: [FLINK-24235][metrics] Only support reporters via factories

2022-11-11 Thread GitBox
zentol commented on code in PR #21296: URL: https://github.com/apache/flink/pull/21296#discussion_r1020105044 ## flink-metrics/flink-metrics-core/src/main/java/org/apache/flink/metrics/reporter/InstantiateViaFactory.java: ## @@ -26,14 +26,7 @@ import java.lang.annotation.Target

[GitHub] [flink] zentol commented on a diff in pull request #21296: [FLINK-24235][metrics] Only support reporters via factories

2022-11-11 Thread GitBox
zentol commented on code in PR #21296: URL: https://github.com/apache/flink/pull/21296#discussion_r1020105044 ## flink-metrics/flink-metrics-core/src/main/java/org/apache/flink/metrics/reporter/InstantiateViaFactory.java: ## @@ -26,14 +26,7 @@ import java.lang.annotation.Target