zentol commented on pull request #13796:
URL: https://github.com/apache/flink/pull/13796#issuecomment-721747784
This is also why flink-dist has explicit compile depencies on log4j ;)
This is an automated message from the
zentol commented on pull request #13796:
URL: https://github.com/apache/flink/pull/13796#issuecomment-721747048
We have explicit test dependencies on log4j in the root pom. They are not
defined in the dependency management, so that not every module has to declare
this stuff again.
zentol commented on pull request #13796:
URL: https://github.com/apache/flink/pull/13796#issuecomment-721707763
This is what I see in the dependencies section, and I don't see a compile
scope.
```
com.google.guava
zentol commented on pull request #13796:
URL: https://github.com/apache/flink/pull/13796#issuecomment-721649393
It seems like you missed
[this](https://github.com/apache/flink/pull/13796#discussion_r516602034)
comment, but we can rebase anyway because I don't have concerns in terms of
zentol commented on pull request #13796:
URL: https://github.com/apache/flink/pull/13796#issuecomment-718289508
> One benefit would be, that our release process is less complicated
Doesn't really apply imo because this can be easily automated. While the
(build) process is more
zentol commented on pull request #13796:
URL: https://github.com/apache/flink/pull/13796#issuecomment-718130365
There is no benefit in having the generated files in git, it could just be
step of the release process.
On CI we would compile Flink and pipe the build output into a file,
zentol commented on pull request #13796:
URL: https://github.com/apache/flink/pull/13796#issuecomment-717906443
Having such a mapping was my idea as well; the explicit failure if a
dependency was not found also serves as a reminder to check the license for
compatibility.
I don't think
zentol commented on pull request #13796:
URL: https://github.com/apache/flink/pull/13796#issuecomment-717905033
Let's add them all here.
This is an automated message from the Apache Git Service.
To respond to the message,
zentol commented on pull request #13796:
URL: https://github.com/apache/flink/pull/13796#issuecomment-717821843
I'm still not a fan of automating the verification; people _will_ see the
tool as the source of truth (which it isn't, as you pointed out), and any
attempt at automating the
zentol commented on pull request #13796:
URL: https://github.com/apache/flink/pull/13796#issuecomment-717170059
I went through the issues the checker found, but most of them appear to be
invalid:
Contradicting statement(similar instances exist for kinesis,
flink-oss-fs-hadoop, and
10 matches
Mail list logo
