zentol commented on pull request #14903:
URL: https://github.com/apache/flink/pull/14903#issuecomment-776259290
If CI passes then I'm OK with merging things as is.
This is an automated message from the Apache Git Service.
To
zentol commented on pull request #14903:
URL: https://github.com/apache/flink/pull/14903#issuecomment-775904917
The python tests are failing because they rely _somehow_ on the
documentation ...
```
/__w/3/s/flink-python/dev/.conda/bin/sphinx-build -b html -d _build/doctrees
-a
zentol commented on pull request #14903:
URL: https://github.com/apache/flink/pull/14903#issuecomment-775856359
Do we still use bootstrap / jquery for the docs? If not then the
bootstrap/anchorjs/jquery could be removed.
zentol commented on pull request #14903:
URL: https://github.com/apache/flink/pull/14903#issuecomment-775488365
When some item in the sidebar is expanded such that the scrollbar appears
everything is getting resized. Ideally it should just appear without things
shifting around.
zentol commented on pull request #14903:
URL: https://github.com/apache/flink/pull/14903#issuecomment-775486659
The issue with headings having massive whitespace above them is due to
`margin-top` and `padding-top` being set. Either would do the trick I think.
(throwing both out isn't so
zentol commented on pull request #14903:
URL: https://github.com/apache/flink/pull/14903#issuecomment-775484371
I think the code tabs have lost a bit of clarity; it's not immediately
obvious that you can click them in the first place.
zentol commented on pull request #14903:
URL: https://github.com/apache/flink/pull/14903#issuecomment-775397165
> It's just during the build because of the sub-module. We don't actually
use these libraries.
Then we don't need to bundle the book license.
zentol commented on pull request #14903:
URL: https://github.com/apache/flink/pull/14903#issuecomment-775372229
> the underlying hugo theme the Flink docs are based on
is this actually bundled in the source though, or just injected during the
build process + git submodule thingie?
zentol commented on pull request #14903:
URL: https://github.com/apache/flink/pull/14903#issuecomment-775358133
`tools/releasing/create_source_release.sh` needs to be updated; it currently
excludes the `docs/content` directory.
zentol commented on pull request #14903:
URL: https://github.com/apache/flink/pull/14903#issuecomment-775353600
I assume the `docs/content` directory cannot be changed to something else?
This is an automated message from the
zentol commented on pull request #14903:
URL: https://github.com/apache/flink/pull/14903#issuecomment-775352059
In any case, the important thing is that it does work; I think all the
things I listed should be fixable in a follow-up. There wasn't any fundamental
issue I ran into.
Is
zentol commented on pull request #14903:
URL: https://github.com/apache/flink/pull/14903#issuecomment-775350638
There's a lot of wasted space here:
zentol commented on pull request #14903:
URL: https://github.com/apache/flink/pull/14903#issuecomment-775346508
It seems to be working, but there are some things that feel off:
- the scaling seems to have changed. Pictures are being enlarged while text
has become smaller
- sidebar
13 matches
Mail list logo
