[GitHub] [flink] zhijiangW commented on a change in pull request #12664: [FLINK-18238][checkpoint] Emit CancelCheckpointMarker downstream on checkpointState in sync phase of checkpoint on task side

2020-06-15 Thread GitBox
zhijiangW commented on a change in pull request #12664: URL: https://github.com/apache/flink/pull/12664#discussion_r440597301 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorTest.java ## @@ -218,6 +230,67

[GitHub] [flink] zhijiangW commented on a change in pull request #12664: [FLINK-18238][checkpoint] Emit CancelCheckpointMarker downstream on checkpointState in sync phase of checkpoint on task side

2020-06-15 Thread GitBox
zhijiangW commented on a change in pull request #12664: URL: https://github.com/apache/flink/pull/12664#discussion_r440582367 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorTest.java ## @@ -218,6 +230,67

[GitHub] [flink] zhijiangW commented on a change in pull request #12664: [FLINK-18238][checkpoint] Emit CancelCheckpointMarker downstream on checkpointState in sync phase of checkpoint on task side

2020-06-15 Thread GitBox
zhijiangW commented on a change in pull request #12664: URL: https://github.com/apache/flink/pull/12664#discussion_r440581662 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorTest.java ## @@ -218,6 +230,67

[GitHub] [flink] zhijiangW commented on a change in pull request #12664: [FLINK-18238][checkpoint] Emit CancelCheckpointMarker downstream on checkpointState in sync phase of checkpoint on task side

2020-06-15 Thread GitBox
zhijiangW commented on a change in pull request #12664: URL: https://github.com/apache/flink/pull/12664#discussion_r440578921 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorTest.java ## @@ -218,6 +230,67

[GitHub] [flink] zhijiangW commented on a change in pull request #12664: [FLINK-18238][checkpoint] Emit CancelCheckpointMarker downstream on checkpointState in sync phase of checkpoint on task side

2020-06-15 Thread GitBox
zhijiangW commented on a change in pull request #12664: URL: https://github.com/apache/flink/pull/12664#discussion_r440578551 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorTest.java ## @@ -218,6 +230,67

[GitHub] [flink] zhijiangW commented on a change in pull request #12664: [FLINK-18238][checkpoint] Emit CancelCheckpointMarker downstream on checkpointState in sync phase of checkpoint on task side

2020-06-15 Thread GitBox
zhijiangW commented on a change in pull request #12664: URL: https://github.com/apache/flink/pull/12664#discussion_r440570913 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorTest.java ## @@ -218,6 +230,67

[GitHub] [flink] zhijiangW commented on a change in pull request #12664: [FLINK-18238][checkpoint] Emit CancelCheckpointMarker downstream on checkpointState in sync phase of checkpoint on task side

2020-06-15 Thread GitBox
zhijiangW commented on a change in pull request #12664: URL: https://github.com/apache/flink/pull/12664#discussion_r440570454 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorTest.java ## @@ -218,6 +230,67

[GitHub] [flink] zhijiangW commented on a change in pull request #12664: [FLINK-18238][checkpoint] Emit CancelCheckpointMarker downstream on checkpointState in sync phase of checkpoint on task side

2020-06-15 Thread GitBox
zhijiangW commented on a change in pull request #12664: URL: https://github.com/apache/flink/pull/12664#discussion_r440569809 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorTest.java ## @@ -218,6 +230,67

[GitHub] [flink] zhijiangW commented on a change in pull request #12664: [FLINK-18238][checkpoint] Emit CancelCheckpointMarker downstream on checkpointState in sync phase of checkpoint on task side

2020-06-15 Thread GitBox
zhijiangW commented on a change in pull request #12664: URL: https://github.com/apache/flink/pull/12664#discussion_r440569953 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorTest.java ## @@ -218,6 +230,67

[GitHub] [flink] zhijiangW commented on a change in pull request #12664: [FLINK-18238][checkpoint] Emit CancelCheckpointMarker downstream on checkpointState in sync phase of checkpoint on task side

2020-06-15 Thread GitBox
zhijiangW commented on a change in pull request #12664: URL: https://github.com/apache/flink/pull/12664#discussion_r440569676 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorTest.java ## @@ -218,6 +230,67

[GitHub] [flink] zhijiangW commented on a change in pull request #12664: [FLINK-18238][checkpoint] Emit CancelCheckpointMarker downstream on checkpointState in sync phase of checkpoint on task side

2020-06-15 Thread GitBox
zhijiangW commented on a change in pull request #12664: URL: https://github.com/apache/flink/pull/12664#discussion_r440568203 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java ## @@ -275,7 +277,7 @@