[GitHub] [flink] zuston commented on pull request #15653: [FLINK-22329][hive] Inject current ugi credentials into jobconf when getting file split in hive connector

zuston commented on pull request #15653: URL: https://github.com/apache/flink/pull/15653#issuecomment-859462105 @lirui-apache Updated. The ci failed looks unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] zuston commented on pull request #15653: [FLINK-22329][hive] Inject current ugi credentials into jobconf when getting file split in hive connector

zuston commented on pull request #15653: URL: https://github.com/apache/flink/pull/15653#issuecomment-851787011 If you have time, could you help review again? Thanks @lirui-apache -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] zuston commented on pull request #15653: [FLINK-22329][hive] Inject current ugi credentials into jobconf when getting file split in hive connector

zuston commented on pull request #15653: URL: https://github.com/apache/flink/pull/15653#issuecomment-843699892 Hi @lirui-apache. Thanks for your review again. I think I need to understand the Hive connector code deeply and then add complete UT. Thanks again. -- This is an automated

[GitHub] [flink] zuston commented on pull request #15653: [FLINK-22329][hive] Inject current ugi credentials into jobconf when getting file split in hive connector

zuston commented on pull request #15653: URL: https://github.com/apache/flink/pull/15653#issuecomment-842045657 Gently ping @lirui-apache -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] zuston commented on pull request #15653: [FLINK-22329][hive] Inject current ugi credentials into jobconf when getting file split in hive connector

zuston commented on pull request #15653: URL: https://github.com/apache/flink/pull/15653#issuecomment-842045657 Gently ping @lirui-apache -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] zuston commented on pull request #15653: [FLINK-22329][hive] Inject current ugi credentials into jobconf when getting file split in hive connector

zuston commented on pull request #15653: URL: https://github.com/apache/flink/pull/15653#issuecomment-841132963 > Would it be better to inject the credentials when the configuration is firstly created? For example, when we create the JobConf in HiveDynamicTableFactory, or when we create

[GitHub] [flink] zuston commented on pull request #15653: [FLINK-22329][hive] Inject current ugi credentials into jobconf when getting file split in hive connector

zuston commented on pull request #15653: URL: https://github.com/apache/flink/pull/15653#issuecomment-826453832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [flink] zuston commented on pull request #15653: [FLINK-22329][hive] Inject current ugi credentials into jobconf when getting file split in hive connector

zuston commented on pull request #15653: URL: https://github.com/apache/flink/pull/15653#issuecomment-826532014 > ``` > Scenarios like kerberos are difficult to cover through unit tests > ``` > > @zuston I'm not sure whether we need kerberos for this. E.g. is it possible to

[GitHub] [flink] zuston commented on pull request #15653: [FLINK-22329][hive] Inject current ugi credentials into jobconf when getting file split in hive connector

zuston commented on pull request #15653: URL: https://github.com/apache/flink/pull/15653#issuecomment-826453832 @lirui-apache Thanks for your reply. > Would it be better to inject the credentials when the configuration is firstly created? For example, when we create the JobConf in

[GitHub] [flink] zuston commented on pull request #15653: [FLINK-22329][hive] Inject current ugi credentials into jobconf when getting file split in hive connector

zuston commented on pull request #15653: URL: https://github.com/apache/flink/pull/15653#issuecomment-822990758 Gentle ping~ @wuchong @wangyang0918 @lirui-apache -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the