[GitHub] [flink-connector-jdbc] wanglijie95 commented on a diff in pull request #31: [FLINK-31649] Fix archunit violations

2023-04-17 Thread via GitHub
wanglijie95 commented on code in PR #31: URL: https://github.com/apache/flink-connector-jdbc/pull/31#discussion_r1168497135 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/xa/JdbcXaSinkFunctionState.java: ## @@ -28,6 +30,7 @@ /** Thread-safe (assuming

[GitHub] [flink-connector-jdbc] wanglijie95 commented on a diff in pull request #31: [FLINK-31649] Fix archunit violations

2023-04-16 Thread via GitHub
wanglijie95 commented on code in PR #31: URL: https://github.com/apache/flink-connector-jdbc/pull/31#discussion_r1168131549 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/xa/JdbcXaSinkFunctionState.java: ## @@ -53,7 +56,7 @@ private

[GitHub] [flink-connector-jdbc] wanglijie95 commented on a diff in pull request #31: [FLINK-31649] Fix archunit violations

2023-04-13 Thread via GitHub
wanglijie95 commented on code in PR #31: URL: https://github.com/apache/flink-connector-jdbc/pull/31#discussion_r1165295846 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/xa/JdbcXaSinkFunctionState.java: ## @@ -28,6 +30,7 @@ /** Thread-safe (assuming

[GitHub] [flink-connector-jdbc] wanglijie95 commented on a diff in pull request #31: [FLINK-31649] Fix archunit violations

2023-04-13 Thread via GitHub
wanglijie95 commented on code in PR #31: URL: https://github.com/apache/flink-connector-jdbc/pull/31#discussion_r1165215296 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/xa/JdbcXaSinkFunctionState.java: ## @@ -28,6 +30,7 @@ /** Thread-safe (assuming