[GitHub] [flink-connector-kafka] chucheng92 commented on a diff in pull request #37: [FLINK-30274] Bump commons-collections 3.x to commons-collections4

2023-06-30 Thread via GitHub
chucheng92 commented on code in PR #37: URL: https://github.com/apache/flink-connector-kafka/pull/37#discussion_r1248008592 ## flink-connector-kafka/pom.xml: ## @@ -72,6 +72,13 @@ under the License. ${kafka.version} + Review Comment: >

[GitHub] [flink-connector-kafka] chucheng92 commented on a diff in pull request #37: [FLINK-30274] Bump commons-collections 3.x to commons-collections4

2023-06-30 Thread via GitHub
chucheng92 commented on code in PR #37: URL: https://github.com/apache/flink-connector-kafka/pull/37#discussion_r1248008592 ## flink-connector-kafka/pom.xml: ## @@ -72,6 +72,13 @@ under the License. ${kafka.version} + Review Comment: >

[GitHub] [flink-connector-kafka] chucheng92 commented on a diff in pull request #37: [FLINK-30274] Bump commons-collections 3.x to commons-collections4

2023-06-30 Thread via GitHub
chucheng92 commented on code in PR #37: URL: https://github.com/apache/flink-connector-kafka/pull/37#discussion_r1247988699 ## flink-connector-kafka/pom.xml: ## @@ -72,6 +72,13 @@ under the License. ${kafka.version} + Review Comment:

[GitHub] [flink-connector-kafka] chucheng92 commented on a diff in pull request #37: [FLINK-30274] Bump commons-collections 3.x to commons-collections4

2023-06-30 Thread via GitHub
chucheng92 commented on code in PR #37: URL: https://github.com/apache/flink-connector-kafka/pull/37#discussion_r1247988699 ## flink-connector-kafka/pom.xml: ## @@ -72,6 +72,13 @@ under the License. ${kafka.version} + Review Comment:

[GitHub] [flink-connector-kafka] chucheng92 commented on a diff in pull request #37: [FLINK-30274] Bump commons-collections 3.x to commons-collections4

2023-06-30 Thread via GitHub
chucheng92 commented on code in PR #37: URL: https://github.com/apache/flink-connector-kafka/pull/37#discussion_r124799 ## flink-connector-kafka/pom.xml: ## @@ -72,6 +72,13 @@ under the License. ${kafka.version} + Review Comment:

[GitHub] [flink-connector-kafka] chucheng92 commented on a diff in pull request #37: [FLINK-30274] Bump commons-collections 3.x to commons-collections4

2023-06-30 Thread via GitHub
chucheng92 commented on code in PR #37: URL: https://github.com/apache/flink-connector-kafka/pull/37#discussion_r124799 ## flink-connector-kafka/pom.xml: ## @@ -72,6 +72,13 @@ under the License. ${kafka.version} + Review Comment:

[GitHub] [flink-connector-kafka] chucheng92 commented on a diff in pull request #37: [FLINK-30274] Bump commons-collections 3.x to commons-collections4

2023-06-30 Thread via GitHub
chucheng92 commented on code in PR #37: URL: https://github.com/apache/flink-connector-kafka/pull/37#discussion_r124799 ## flink-connector-kafka/pom.xml: ## @@ -72,6 +72,13 @@ under the License. ${kafka.version} + Review Comment:

[GitHub] [flink-connector-kafka] chucheng92 commented on a diff in pull request #37: [FLINK-30274] Bump commons-collections 3.x to commons-collections4

2023-06-30 Thread via GitHub
chucheng92 commented on code in PR #37: URL: https://github.com/apache/flink-connector-kafka/pull/37#discussion_r124799 ## flink-connector-kafka/pom.xml: ## @@ -72,6 +72,13 @@ under the License. ${kafka.version} + Review Comment:

[GitHub] [flink-connector-kafka] chucheng92 commented on a diff in pull request #37: [FLINK-30274] Bump commons-collections 3.x to commons-collections4

2023-06-30 Thread via GitHub
chucheng92 commented on code in PR #37: URL: https://github.com/apache/flink-connector-kafka/pull/37#discussion_r1247988699 ## flink-connector-kafka/pom.xml: ## @@ -72,6 +72,13 @@ under the License. ${kafka.version} + Review Comment: