[GitHub] [flink-kubernetes-operator] Miuler commented on a diff in pull request #252: [FLINK-27889] fix: Catch the error when last reconciled spec is null

2022-06-04 Thread GitBox
Miuler commented on code in PR #252: URL: https://github.com/apache/flink-kubernetes-operator/pull/252#discussion_r889533284 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java: ## @@ -229,14 +229,12 @@ private

[GitHub] [flink-kubernetes-operator] Miuler commented on a diff in pull request #252: [FLINK-27889] fix: Catch the error when last reconciled spec is null

2022-06-04 Thread GitBox
Miuler commented on code in PR #252: URL: https://github.com/apache/flink-kubernetes-operator/pull/252#discussion_r889533284 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java: ## @@ -229,14 +229,12 @@ private

[GitHub] [flink-kubernetes-operator] Miuler commented on a diff in pull request #252: [FLINK-27889] fix: Catch the error when last reconciled spec is null

2022-06-04 Thread GitBox
Miuler commented on code in PR #252: URL: https://github.com/apache/flink-kubernetes-operator/pull/252#discussion_r889528815 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigManager.java: ## @@ -134,6 +135,11 @@ public

[GitHub] [flink-kubernetes-operator] Miuler commented on a diff in pull request #252: [FLINK-27889] fix: Catch the error when last reconciled spec is null

2022-06-04 Thread GitBox
Miuler commented on code in PR #252: URL: https://github.com/apache/flink-kubernetes-operator/pull/252#discussion_r889527423 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentControllerTest.java: ## @@ -274,6 +279,15 @@

[GitHub] [flink-kubernetes-operator] Miuler commented on a diff in pull request #252: [FLINK-27889] fix: Catch the error when last reconciled spec is null

2022-06-04 Thread GitBox
Miuler commented on code in PR #252: URL: https://github.com/apache/flink-kubernetes-operator/pull/252#discussion_r889527238 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java: ## @@ -229,14 +229,12 @@ private

[GitHub] [flink-kubernetes-operator] Miuler commented on a diff in pull request #252: [FLINK-27889] fix: Catch the error when last reconciled spec is null

2022-06-04 Thread GitBox
Miuler commented on code in PR #252: URL: https://github.com/apache/flink-kubernetes-operator/pull/252#discussion_r889523773 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java: ## @@ -229,14 +229,12 @@ private

[GitHub] [flink-kubernetes-operator] Miuler commented on a diff in pull request #252: [FLINK-27889] fix: Catch the error when last reconciled spec is null

2022-06-04 Thread GitBox
Miuler commented on code in PR #252: URL: https://github.com/apache/flink-kubernetes-operator/pull/252#discussion_r889523760 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentControllerTest.java: ## @@ -274,6 +279,15 @@

[GitHub] [flink-kubernetes-operator] Miuler commented on a diff in pull request #252: [FLINK-27889] fix: Catch the error when last reconciled spec is null

2022-06-03 Thread GitBox
Miuler commented on code in PR #252: URL: https://github.com/apache/flink-kubernetes-operator/pull/252#discussion_r889415035 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentControllerTest.java: ## @@ -274,6 +278,89 @@

[GitHub] [flink-kubernetes-operator] Miuler commented on a diff in pull request #252: [FLINK-27889] fix: Catch the error when last reconciled spec is null

2022-06-03 Thread GitBox
Miuler commented on code in PR #252: URL: https://github.com/apache/flink-kubernetes-operator/pull/252#discussion_r84192 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java: ## @@ -354,8 +355,54 @@ protected

[GitHub] [flink-kubernetes-operator] Miuler commented on a diff in pull request #252: [FLINK-27889] fix: Catch the error when last reconciled spec is null

2022-06-03 Thread GitBox
Miuler commented on code in PR #252: URL: https://github.com/apache/flink-kubernetes-operator/pull/252#discussion_r78032 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/exception/LastReconciledSpecException.java: ## @@ -0,0 +1,25 @@ +/* + *

[GitHub] [flink-kubernetes-operator] Miuler commented on a diff in pull request #252: [FLINK-27889] fix: Catch the error when last reconciled spec is null

2022-06-03 Thread GitBox
Miuler commented on code in PR #252: URL: https://github.com/apache/flink-kubernetes-operator/pull/252#discussion_r77851 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java: ## @@ -354,8 +355,54 @@ protected