Miuler commented on code in PR #252:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/252#discussion_r889523760
##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentControllerTest.java:
##########
@@ -274,6 +279,15 @@ public void
verifyInProgressDeploymentWithCrashLoopBackoff() throws Exception {
validatingResponseProvider.assertValidated();
}
+ @ParameterizedTest
+ @EnumSource(FlinkVersion.class)
+ public void cleanUpDeploymentWithError(FlinkVersion flinkVersion)
+ throws JsonProcessingException {
+ FlinkDeployment flinkDeployment = TestUtils.buildApplicationCluster();
+ val deleteControl = testController.cleanup(flinkDeployment, context);
Review Comment:
Can I use val in the tests? I prefer to use final instead of a mutable
variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
