[GitHub] [flink-kubernetes-operator] Miuler commented on pull request #252: [FLINK-27889] fix: Catch the error when last reconciled spec is null

2022-06-04 Thread GitBox
Miuler commented on PR #252: URL: https://github.com/apache/flink-kubernetes-operator/pull/252#issuecomment-1146610360 @gyfora I already revert the commit where I add logs, I only have the doubt of the timeout. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink-kubernetes-operator] Miuler commented on pull request #252: [FLINK-27889] fix: Catch the error when last reconciled spec is null

2022-06-03 Thread GitBox
Miuler commented on PR #252: URL: https://github.com/apache/flink-kubernetes-operator/pull/252#issuecomment-1146499549 @gyfora I already corrected the code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink-kubernetes-operator] Miuler commented on pull request #252: [FLINK-27889] fix: Catch the error when last reconciled spec is null

2022-06-03 Thread GitBox
Miuler commented on PR #252: URL: https://github.com/apache/flink-kubernetes-operator/pull/252#issuecomment-1146460454 > @Miuler I looked into this a little and this is the only thing we need to change for this to work (and make your test to pass): > > ``` > diff --git

[GitHub] [flink-kubernetes-operator] Miuler commented on pull request #252: [FLINK-27889] fix: Catch the error when last reconciled spec is null

2022-06-03 Thread GitBox
Miuler commented on PR #252: URL: https://github.com/apache/flink-kubernetes-operator/pull/252#issuecomment-1145911680 > Do you have a yaml that I can use to reproduce this? I am still not convinced that we need to refactor etc In the test is the real yaml, but hide some names, the

[GitHub] [flink-kubernetes-operator] Miuler commented on pull request #252: [FLINK-27889] fix: Catch the error when last reconciled spec is null

2022-06-03 Thread GitBox
Miuler commented on PR #252: URL: https://github.com/apache/flink-kubernetes-operator/pull/252#issuecomment-1145889080 ![image](https://user-images.githubusercontent.com/9974/171847082-c8f88ed0-e27a-45f1-9067-c1d45f6fd1a3.png) This log was sent to me by sysadmin, and when I do the

[GitHub] [flink-kubernetes-operator] Miuler commented on pull request #252: [FLINK-27889] fix: Catch the error when last reconciled spec is null

2022-06-03 Thread GitBox
Miuler commented on PR #252: URL: https://github.com/apache/flink-kubernetes-operator/pull/252#issuecomment-1145875377 > @Miuler could you please provide a detailed description of what this change does specifically and what is the error scenario that we are handling here? > > This