[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-08 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r764665262 ## File path: flink-ml-lib/src/test/java/org/apache/flink/ml/classification/knn/KnnTest.java ## @@ -0,0 +1,277 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-08 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r764663947 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/Knn.java ## @@ -0,0 +1,255 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-08 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r764661446 ## File path: flink-ml-lib/src/test/java/org/apache/flink/ml/classification/knn/KnnTest.java ## @@ -0,0 +1,273 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-08 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r764661044 ## File path: flink-ml-core/pom.xml ## @@ -59,11 +59,11 @@ under the License. ${flink.version} test - - org.apache.flink -

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-08 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r764660930 ## File path: flink-ml-lib/pom.xml ## @@ -65,6 +65,12 @@ under the License. test + + com.github.fommil.netlib Review comment:

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-08 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r764660309 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/FastDistanceVectorData.java ## @@ -0,0 +1,28 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-08 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r764659636 ## File path: flink-ml-core/src/main/java/org/apache/flink/ml/linalg/DenseMatrix.java ## @@ -0,0 +1,47 @@ +package org.apache.flink.ml.linalg; + +import

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-08 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r764659454 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/common/datastream/TableUtils.java ## @@ -38,4 +43,28 @@ public static RowTypeInfo

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-08 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r764659333 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnModel.java ## @@ -0,0 +1,412 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-08 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r764659169 ## File path: flink-ml-lib/src/test/java/org/apache/flink/ml/classification/knn/KnnTest.java ## @@ -0,0 +1,278 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-08 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r764658436 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/Knn.java ## @@ -0,0 +1,227 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-08 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r764650802 ## File path: flink-ml-core/src/main/java/org/apache/flink/ml/linalg/typeinfo/DenseMatrixSerializer.java ## @@ -0,0 +1,138 @@ +/* + * Licensed to the

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-08 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r764649082 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/common/param/HasK.java ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-07 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r764497065 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/Knn.java ## @@ -0,0 +1,217 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-07 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r763930742 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/common/param/HasK.java ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-07 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r763729532 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnModel.java ## @@ -0,0 +1,412 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-07 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r763801857 ## File path: flink-ml-core/src/main/java/org/apache/flink/ml/linalg/DenseMatrix.java ## @@ -0,0 +1,47 @@ +package org.apache.flink.ml.linalg; + +import

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-07 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r763808468 ## File path: flink-ml-core/src/main/java/org/apache/flink/ml/linalg/DenseMatrix.java ## @@ -0,0 +1,47 @@ +package org.apache.flink.ml.linalg; + +import

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-07 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r763808290 ## File path: flink-ml-core/src/main/java/org/apache/flink/ml/linalg/DenseMatrix.java ## @@ -0,0 +1,47 @@ +package org.apache.flink.ml.linalg; + +import

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-07 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r763802873 ## File path: flink-ml-core/src/main/java/org/apache/flink/ml/linalg/DenseMatrix.java ## @@ -0,0 +1,47 @@ +package org.apache.flink.ml.linalg; + +import

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-07 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r763795024 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnModel.java ## @@ -0,0 +1,412 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-07 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r763792288 ## File path: flink-ml-lib/src/test/java/org/apache/flink/ml/classification/knn/KnnTest.java ## @@ -0,0 +1,278 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-07 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r763791507 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/Knn.java ## @@ -0,0 +1,227 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-07 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r763790521 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/Knn.java ## @@ -0,0 +1,227 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-07 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r763730634 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnModel.java ## @@ -0,0 +1,412 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-07 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r763729532 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnModel.java ## @@ -0,0 +1,412 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-07 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r763728994 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/Knn.java ## @@ -0,0 +1,227 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-07 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r763727970 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/Knn.java ## @@ -0,0 +1,227 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-07 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r763727160 ## File path: flink-ml-lib/src/test/java/org/apache/flink/ml/classification/knn/KnnTest.java ## @@ -0,0 +1,278 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-07 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r763726499 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnModel.java ## @@ -0,0 +1,412 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-07 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r763726141 ## File path: flink-ml-core/src/main/java/org/apache/flink/ml/linalg/DenseMatrix.java ## @@ -0,0 +1,47 @@ +package org.apache.flink.ml.linalg; + +import

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-07 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r763725903 ## File path: flink-ml-core/src/main/java/org/apache/flink/ml/linalg/DenseMatrix.java ## @@ -0,0 +1,47 @@ +package org.apache.flink.ml.linalg; + +import

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-07 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r763724812 ## File path: flink-ml-core/src/main/java/org/apache/flink/ml/linalg/DenseMatrix.java ## @@ -0,0 +1,47 @@ +package org.apache.flink.ml.linalg; + +import

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-07 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r763724549 ## File path: flink-ml-core/src/main/java/org/apache/flink/ml/linalg/typeinfo/DenseMatrixTypeInfo.java ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-07 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r763724378 ## File path: flink-ml-core/src/main/java/org/apache/flink/ml/linalg/DenseMatrix.java ## @@ -0,0 +1,47 @@ +package org.apache.flink.ml.linalg; + +import

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-06 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r763606874 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/FastDistance.java ## @@ -0,0 +1,192 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-06 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r763606748 ## File path: flink-ml-lib/src/test/java/org/apache/flink/ml/classification/knn/KnnTest.java ## @@ -0,0 +1,285 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-06 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r762978168 ## File path: flink-ml-lib/src/test/java/org/apache/flink/ml/classification/knn/KnnTest.java ## @@ -0,0 +1,285 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-06 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r762977739 ## File path: flink-ml-lib/src/test/java/org/apache/flink/ml/classification/knn/KnnTest.java ## @@ -0,0 +1,285 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-06 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r762977526 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/FastDistanceVectorData.java ## @@ -0,0 +1,28 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-06 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r762977288 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/FastDistanceVectorData.java ## @@ -0,0 +1,28 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-06 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r762976987 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/FastDistanceVectorData.java ## @@ -0,0 +1,28 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-06 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r762976749 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/FastDistanceMatrixData.java ## @@ -0,0 +1,122 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-06 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r762976486 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/FastDistanceMatrixData.java ## @@ -0,0 +1,122 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-06 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r762976263 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/FastDistanceMatrixData.java ## @@ -0,0 +1,122 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-06 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r762975880 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/FastDistance.java ## @@ -0,0 +1,192 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-05 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r762657594 ## File path: flink-ml-api/src/main/java/org/apache/flink/ml/linalg/Vector.java ## @@ -29,6 +29,10 @@ /** Gets the value of the ith element. */

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-02 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r760919513 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnModel.java ## @@ -0,0 +1,489 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-02 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r760919046 ## File path: flink-ml-lib/src/test/java/org/apache/flink/ml/classification/knn/KnnTest.java ## @@ -0,0 +1,273 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-02 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r760918901 ## File path: flink-ml-lib/src/test/java/org/apache/flink/ml/classification/knn/KnnTest.java ## @@ -0,0 +1,273 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-02 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r760918561 ## File path: flink-ml-lib/src/test/java/org/apache/flink/ml/classification/knn/KnnTest.java ## @@ -0,0 +1,273 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-12-02 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r760918295 ## File path: flink-ml-lib/src/test/java/org/apache/flink/ml/classification/knn/KnnTest.java ## @@ -0,0 +1,273 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-30 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r759912742 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/common/param/HasFeatureColsDefaultAsNull.java ## @@ -0,0 +1,28 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-30 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r759909634 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnModelData.java ## @@ -0,0 +1,134 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-30 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r759909541 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnParams.java ## @@ -0,0 +1,18 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-26 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r757375204 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/common/param/HasK.java ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-26 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r757366985 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnModel.java ## @@ -0,0 +1,493 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-26 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r757360455 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnModelData.java ## @@ -0,0 +1,134 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-26 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r757359842 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnParams.java ## @@ -0,0 +1,18 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-25 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r756819327 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/common/param/HasFeatureColsDefaultAsNull.java ## @@ -0,0 +1,28 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-25 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r756818051 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnModel.java ## @@ -0,0 +1,594 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-25 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r756817571 ## File path: flink-ml-lib/src/test/java/org/apache/flink/ml/classification/knn/KnnTest.java ## @@ -0,0 +1,172 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-25 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r756817467 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/EuclideanDistance.java ## @@ -0,0 +1,272 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-24 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r756627878 ## File path: flink-ml-api/src/main/java/org/apache/flink/ml/linalg/DenseVector.java ## @@ -60,6 +75,74 @@ public boolean equals(Object obj) {

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-24 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r756526795 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/common/param/HasFeatureColsDefaultAsNull.java ## @@ -0,0 +1,28 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-24 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r756526696 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/common/MapPartitionFunctionWrapper.java ## @@ -0,0 +1,68 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-23 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r755690633 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/EuclideanDistance.java ## @@ -0,0 +1,272 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-23 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r755688272 ## File path: flink-ml-api/src/main/java/org/apache/flink/ml/param/Param.java ## @@ -75,7 +75,7 @@ public String jsonEncode(T value) throws IOException {

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-23 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r755688178 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/Knn.java ## @@ -0,0 +1,255 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-23 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r755684260 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnParams.java ## @@ -0,0 +1,32 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-23 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r755684156 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnParams.java ## @@ -0,0 +1,32 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-23 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r755682429 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnModel.java ## @@ -0,0 +1,594 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-23 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r755682171 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnModel.java ## @@ -0,0 +1,594 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-23 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r755678624 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnModel.java ## @@ -0,0 +1,594 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-23 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r755678460 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnModel.java ## @@ -0,0 +1,594 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-23 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r755678350 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnModel.java ## @@ -0,0 +1,594 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-23 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r755677909 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnModel.java ## @@ -0,0 +1,594 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-23 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r755677169 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/common/param/HasFeatureColsDefaultAsNull.java ## @@ -0,0 +1,28 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-23 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r755676992 ## File path: flink-ml-lib/src/test/java/org/apache/flink/ml/classification/knn/KnnTest.java ## @@ -0,0 +1,172 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-23 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r755676909 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnParams.java ## @@ -0,0 +1,32 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-23 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r755675421 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/FastDistanceMatrixData.java ## @@ -0,0 +1,93 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-23 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r755674770 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/common/MapPartitionFunctionWrapper.java ## @@ -0,0 +1,68 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-23 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r755674858 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnParams.java ## @@ -0,0 +1,32 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-23 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r755674542 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/Knn.java ## @@ -0,0 +1,255 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-23 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r755674684 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/common/param/HasFeatureColsDefaultAsNull.java ## @@ -0,0 +1,28 @@ +package

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-23 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r755674205 ## File path: flink-ml-api/src/main/java/org/apache/flink/ml/util/ReadWriteUtils.java ## @@ -43,8 +46,12 @@ /** Utility methods for reading and

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-23 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r755673857 ## File path: flink-ml-api/src/main/java/org/apache/flink/ml/param/Param.java ## @@ -75,7 +75,7 @@ public String jsonEncode(T value) throws IOException {

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-23 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r755673679 ## File path: flink-ml-api/src/main/java/org/apache/flink/ml/param/Param.java ## @@ -64,7 +64,7 @@ public Param( * @return A json-formatted string.

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-23 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r755673190 ## File path: flink-ml-api/src/main/java/org/apache/flink/ml/linalg/DenseVector.java ## @@ -42,14 +45,26 @@ public double get(int i) { return

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-18 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r752853592 ## File path: flink-ml-lib/pom.xml ## @@ -106,6 +112,11 @@ under the License. jar test + + com.google.code.gson +

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add knn algorithm to flink-ml

2021-11-18 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r752930662 ## File path: flink-ml-lib/pom.xml ## @@ -106,6 +112,11 @@ under the License. jar test + + com.google.code.gson +

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: Flink 24557- add knn algorithm to flink-ml

2021-11-18 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r752903128 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/distance/EuclideanDistance.java ## @@ -0,0 +1,259 @@ +package