[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #311: [FLINK-29554] Add partial-update.ignore-delete option to avoid exception after join

2022-10-12 Thread GitBox
SteNicholas commented on code in PR #311: URL: https://github.com/apache/flink-table-store/pull/311#discussion_r993463151 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/compact/PartialUpdateMergeFunction.java: ## @@ -54,9 +53,15 @@ public

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #311: [FLINK-29554] Add partial-update.ignore-delete option to avoid exception after join

2022-10-12 Thread GitBox
SteNicholas commented on code in PR #311: URL: https://github.com/apache/flink-table-store/pull/311#discussion_r993463151 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/compact/PartialUpdateMergeFunction.java: ## @@ -54,9 +53,15 @@ public

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #311: [FLINK-29554] Add partial-update.ignore-delete option to avoid exception after join

2022-10-12 Thread GitBox
SteNicholas commented on code in PR #311: URL: https://github.com/apache/flink-table-store/pull/311#discussion_r993462724 ## docs/layouts/shortcodes/generated/core_configuration.html: ## @@ -170,6 +170,12 @@ MemorySize Memory page size. +

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #311: [FLINK-29554] Add partial-update.ignore-delete option to avoid exception after join

2022-10-12 Thread GitBox
SteNicholas commented on code in PR #311: URL: https://github.com/apache/flink-table-store/pull/311#discussion_r991985956 ## docs/layouts/shortcodes/generated/core_configuration.html: ## @@ -170,6 +170,12 @@ MemorySize Memory page size. +

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #311: [FLINK-29554] Add partial-update.ignore-delete option to avoid exception after join

2022-10-11 Thread GitBox
SteNicholas commented on code in PR #311: URL: https://github.com/apache/flink-table-store/pull/311#discussion_r991985956 ## docs/layouts/shortcodes/generated/core_configuration.html: ## @@ -170,6 +170,12 @@ MemorySize Memory page size. +