[GitHub] [flink-table-store] zjureel commented on a diff in pull request #383: [FLINK-30033] Add primary key type validation

2022-11-16 Thread GitBox
zjureel commented on code in PR #383: URL: https://github.com/apache/flink-table-store/pull/383#discussion_r1024730773 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/schema/SchemaManager.java: ## @@ -157,6 +159,33 @@ public TableSchema

[GitHub] [flink-table-store] zjureel commented on a diff in pull request #383: [FLINK-30033] Add primary key type validation

2022-11-16 Thread GitBox
zjureel commented on code in PR #383: URL: https://github.com/apache/flink-table-store/pull/383#discussion_r1024702921 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/schema/SchemaManager.java: ## @@ -157,6 +159,33 @@ public TableSchema

[GitHub] [flink-table-store] zjureel commented on a diff in pull request #383: [FLINK-30033] Add primary key type validation

2022-11-15 Thread GitBox
zjureel commented on code in PR #383: URL: https://github.com/apache/flink-table-store/pull/383#discussion_r1023527209 ## docs/content/docs/development/create-table.md: ## @@ -296,6 +296,24 @@ Use approach one if you have a large number of filtered queries with only