[GitHub] azagrebin commented on issue #6567: [FLINK-10074] Allowable number of checkpoint failures

2018-10-30 Thread GitBox
azagrebin commented on issue #6567: [FLINK-10074] Allowable number of checkpoint failures URL: https://github.com/apache/flink/pull/6567#issuecomment-434255898 I created FLINK-10724 to refactor failure handling in checkpoint coordinator where I believe we should firstly prepare it for bett

[GitHub] azagrebin commented on issue #6567: [FLINK-10074] Allowable number of checkpoint failures

2018-10-30 Thread GitBox
azagrebin commented on issue #6567: [FLINK-10074] Allowable number of checkpoint failures URL: https://github.com/apache/flink/pull/6567#issuecomment-434217958 Hi @yanghua, can this PR be closed for now and we come back to it when we have design in the Jira issue? We might

[GitHub] azagrebin commented on issue #6567: [FLINK-10074] Allowable number of checkpoint failures

2018-10-09 Thread GitBox
azagrebin commented on issue #6567: [FLINK-10074] Allowable number of checkpoint failures URL: https://github.com/apache/flink/pull/6567#issuecomment-428137039 Hi @yanghua, In general, `executionGraph.failGlobal` looks good to me to fail, but I think the `CheckpointFailureManager` s

[GitHub] azagrebin commented on issue #6567: [FLINK-10074] Allowable number of checkpoint failures

2018-09-24 Thread GitBox
azagrebin commented on issue #6567: [FLINK-10074] Allowable number of checkpoint failures URL: https://github.com/apache/flink/pull/6567#issuecomment-423942772 > Do we need to take this refactoring into account? Because this PR is actually a supplement to the checkpoint exception handler.

[GitHub] azagrebin commented on issue #6567: [FLINK-10074] Allowable number of checkpoint failures

2018-09-21 Thread GitBox
azagrebin commented on issue #6567: [FLINK-10074] Allowable number of checkpoint failures URL: https://github.com/apache/flink/pull/6567#issuecomment-423573937 Thanks for the update, @yanghua. Looking at the checkpoint coordinator more deeply, I think we firstly have to work a bit more on