Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2085
Merged. Thank you for your comments!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2085
I tried your code again on my testing machine and everything that didn't
work at my last tests is now fixed.
I also quickly scanned the newly added commits.
I think the pull request is
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2085
Rebased to the latest master and refined the tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2085
Thanks a lot for addressing my comments to quickly.
I'll try the code out soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2085
I've addressed your comments in another commit. I'd be delighted if you
could try out the changes again!
- remove legacy code from CliFrontend
- change activation code of CustomCommandLine
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2085
Thanks for the review! I've addressed almost all your comments and will
ping you once the PR get updated. Some more comments:
> (1) When listing the yarn-session.sh cli options, I could not see
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2085
Thanks a lot for adding this feature. I looked through the code and tried
it out on a cluster.
Once my concerns are addressed (either through changes or comments) we can
merge the change.
---
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2085
Detached per job submission is not working (`./bin/flink run -m
yarn-cluster -yd -yn 1 ./examples/batch/WordCount.jar `)
```
2016-06-13 07:28:22,423 INFO
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2085
While trying out your code, I noticed that the `.yarn-properties` file is
not properly deleted, even though my previous yarn session was shutting down
correctly:
```
2016-06-13
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2085
I'll probably continue reviewing your work next Monday.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2085
I quickly tried your changes.
Some notes
(1) When listing the yarn-session.sh cli options, I could not see the
newly added argument
```
./bin/yarn-session.sh
2016-06-10
11 matches
Mail list logo
