Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2512
Had an in-depth code walkthrough with @StefanRRichter - comments are
addresses as additional commits.
Comments:
- Use `StateDescriptor` as well for operator state
- For the
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2512
I would like to go for a follow-up PR. This is currently blocking some
other work, so getting it in soon would help.
---
If your project is set up for it, you can reply to this email and have
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2512
I think we should also update the documentation as part of this PR (there's
a page dedicated to working with state)
---
If your project is set up for it, you can reply to this email and have your
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2512
+1, I like the changes.
Concerning (7) - I think creating the state backend once sounds good. It is
more in line with the keyed state backend.
Concerning Aljoscha's comments:
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2512
I think most of the proposed renames are good. One thing that would be good
to change is to remove `SnapshotProvider` and just have that method directly on
`OperatorStateBackend`.
I really
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/2512
Hi,
I have some suggestions for renaming some of the interfaces and their
methods in this pull request to come up with some clearer, more consistent
naming schemes. I suggest the
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/2512
Please review @tillrohrmann @StephanEwen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
