Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2605
I like Greg's idea - will make it more readable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2605
Looks very good! +1 to do this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2605
+1. My only suggestion would be to move the deprecated keys out of the
constructor into a separate method like `public Option
withDeprecatedKeys(String... deprecatedKeys) {`. And the same
