Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3359
@shixiaogang I had a brief look into the updated PR. It seems like this
current version does not include integrating timers with the other keyed state?
I am asking because my plan would be to
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3359
@shixiaogang thanks a lot! I will try to take a look at this as soon as
possible.
---
Github user shixiaogang commented on the issue:
https://github.com/apache/flink/pull/3359
Because the old code is too outdated, I have updated the PR, reimplementing
RocksDBInternalTimerService from scratch. Some problems mentioned in the
previous comments may still exist, but I
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3359
@shixiaogang Thank you very much, appreciate your efforts on this feature!
There is no need to rush this if you are busy right now, the cycle for the 1.6
release is just beginning.
---
Github user shixiaogang commented on the issue:
https://github.com/apache/flink/pull/3359
@StefanRRichter Sorry for the delayed response. I am working on it and
shall update the PR by this weekend.
---
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3359
@shixiaogang are you still interested in contributing or collaborating on
this feature? I think we should try to get this into Flink 1.6. What do you
think?
---
Github user orsher commented on the issue:
https://github.com/apache/flink/pull/3359
Hi,
Is there any progress here?
This feature will made our life much easier!
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/3359
@shixiaogang Sounds nice! Can you please open a PR if possible? Thanks!
---
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3359
@shixiaogang The changes sound helpful, considering that this PR was
implemented before incremental checkpoints. For a final opinion I would have to
review the code. One concern that I have
Github user shixiaogang commented on the issue:
https://github.com/apache/flink/pull/3359
Very sorry for the delay. I was engaged at the work in the past months,
making flink capable of the terrible data flows in Singles Day.
RocksDBInternalTimerService is among the
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3359
I think this implementation was (close to complete) and should be working,
but the PR is outdated. I think it should be possible to attempt a manual
rebase.
---
Github user shixiaogang commented on the issue:
https://github.com/apache/flink/pull/3359
@vpernin Thanks very much for your attention. The PR is supposed to work on
1.3-SNAPSHOT, but it's not testable now due to some known bugs.
Besides, i want to add support for
Github user vpernin commented on the issue:
https://github.com/apache/flink/pull/3359
Is this PR in a testable/working state based on 1.3-SNAPHOT ?
I could help test with a quite large number of window timers (between 2M
and 6M).
---
If your project is set up for it, you can
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3359
One additional comment, also as reminder for @aljoscha and me: after this
PR is rebased, we have access to `InternalKeyContext`, which should be somehow
integrated with the already existing
14 matches
Mail list logo
