Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3459
Hi @huawei-flink, the feature was contributed in a follow up PR.
Could you close this PR? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3459
Hi @huawei-flink,
most Maven modules in Flink are implemented in either Java or Scala. We
have a few modules (like flink-runtime) which are mixed but didn't make good
experience with this
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3459
@fhueske
3. "â¢The first OVER window aggregation should serve as a blueprint for
future OVER window implementations." - is this a general thought or you
indicate that we need to rework
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3459
Hi @fhueske
I will start with the minor comments: in principle those were done by
mistake within the rebase...
Regarding the FunctionCatalog - that was because initially we used
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3459
Hi @huawei-flink, sorry for the long delay. I focused on adding support for
retraction to the new UDAGG interface (PR #3470), support for time mode
functions (PR #3370, #3425), and the most simple
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3459
@fhueske @wuchong @twalthr can you please take a look to see if you can
merge this. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3459
Related to the building failure - I see that this fails only for one
particular case. I looked into the error and it is not related to my
modifications as you cans see below. In fact I did not
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3459
@shijinkui I think Radu and I complicated a bit the code pulling from each
other branch some stuff. Next time we'll squash the commit.
---
If your project is set up for it, you can reply to
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3459
@stefanobortoli One PR should has only one commit as soon as possible. If
having so many commit, it's hard to review..
---
If your project is set up for it, you can reply to this email and have
