Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/6007
Sorry, for the delay @snuyanzin. I was on vacation. I will have a look at
your update.
---
Github user snuyanzin commented on the issue:
https://github.com/apache/flink/pull/6007
> Just because DOW is in the reserved keywords section doesn't mean that we
support it.
Definitely agree however my point was that the same situation is for DOY,
CENTURY and others...
Now
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/6007
Hi @snuyanzin,
yes, I meant `docs/dev/table/sql.md`. Right now it is not documented which
units are supported by `EXTRACT`. Just because `DOW` is in the reserved
keywords section doesn't mean
Github user snuyanzin commented on the issue:
https://github.com/apache/flink/pull/6007
@twalthr thank you for your comment but could you please clarify this
> Can you add some documentation to sqlApi.md such that users know about
the semantics?
1. Am I right that
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/6007
Thank you for the effort @snuyanzin. I was not aware about the amount of
work you put into this issue before opening the PR. I'm fine with sticking to
Calcite's behavior. Can you add some
Github user snuyanzin commented on the issue:
https://github.com/apache/flink/pull/6007
@twalthr thank you for your comment.
I took a similar ticket in Calcite/Avatica from which the current depends
on and I pointed this discrepancy in the [comment
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/6007
Thanks for the PR @snuyanzin. I created the issue because it seems that
this is more than a one line change. I tested your queries in Postgres SQL and
it returns 0 instead of 1. We should have the
Github user snuyanzin commented on the issue:
https://github.com/apache/flink/pull/6007
sorry, closed by mistake, restored
---
Github user snuyanzin commented on the issue:
https://github.com/apache/flink/pull/6007
yes, done
---
