Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6089
@zentol Thanks for the review. I made the clean up and did some changes to
get the ES dependency from flink-quickstart-test/pom.xml
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6089
@zentol PR has been updated and usage also changed to
`test_quickstarts.sh `
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6089
@zentol PR is updated with requested changes! Please review
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6089
@zentol PR is updated!
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6089
@zentol Thanks! found them :)
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6089
The ES modules are used in `run-nightly-tests.sh`.
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6089
@zentol I reverted back flink-elasticsearch* modules. Do you think we still
need them as they've never been used?
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6089
@zentol updated the PR as suggested! Please review
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6089
@zentol sure! I will update the PR with your requested changes.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6089
Let's not mix concerns here. Re-using examples can lead to situations where
the quickstart tests fail because an example was modified, which by all means
shouldn't happen.
The examples should
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6089
@zentol Thanks for review!
Yes, I totally agree as the most of test script is duplicated, we need to
refactor them the way you mentioned, I will update the PR with new changes.
QQ: One
11 matches
Mail list logo
