Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/629#discussion_r29834901
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/math/metrics/distances/CosineDistanceMeasure.scala
---
@@ -0,0 +1,45 @@
+/*
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/629#discussion_r29837576
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/math/metrics/distances/CosineDistanceMeasure.scala
---
@@ -0,0 +1,45 @@
+/*
+
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/629#issuecomment-99785066
@chiwanpark, looks really good. I had only one comment concerning the
cosine distance.
Furthermore, I was wondering whether we should rename
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/629#issuecomment-99803191
Ping me once you've renamed the classes, then I'll merge the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/629#issuecomment-99803730
@tillrohrmann I just renamed the classes. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/629#issuecomment-99803806
Oh, the commit logs contains distance measure. I will fix them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/629#discussion_r29839310
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/math/metrics/distances/CosineDistanceMeasure.scala
---
@@ -0,0 +1,45 @@
+/*
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/629#issuecomment-99805451
Great. I'll merge it then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/629
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/629#issuecomment-99531887
I added a overview documentation. Please review and comment if there are
some errors.
---
If your project is set up for it, you can reply to this email and have your
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/629#issuecomment-98626668
Well done @chiwanpark.
The only thing which is missing is an overview page with all supported
distance measures for the Flink website. Could you add such a
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/629#discussion_r29320587
--- Diff:
flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/math/SparseVectorSuite.scala
---
@@ -87,4 +87,33 @@ class SparseVectorSuite extends
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/629#issuecomment-97368054
Hi @chiwanpark. Really good work :-) I had only some minor comments.
One think to think about is where we place the distance measures. Currently
it is in the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/629#discussion_r29319548
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/math/DenseVector.scala
---
@@ -80,6 +80,27 @@ case class DenseVector(val data:
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/629#discussion_r29318498
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/common/distance/MinkowskiDistanceMeasure.scala
---
@@ -0,0 +1,41 @@
+/*
+ *
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/629#discussion_r29318238
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/common/distance/DistanceMeasure.scala
---
@@ -0,0 +1,37 @@
+/*
+ * Licensed
GitHub user chiwanpark opened a pull request:
https://github.com/apache/flink/pull/629
[FLINK-1933] Add distance measure interface and basic implementation to
machine learning library
This PR contains following changes:
* Add `dot` method and `magnitude` method.
* Add
17 matches
Mail list logo
