Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/629#issuecomment-97368054
Hi @chiwanpark. Really good work :-) I had only some minor comments.
One think to think about is where we place the distance measures. Currently
it is in the `flink.ml.common.distance` package. Maybe we could put them in a
`metrics.distances` package instead. We could either put it directly under
`flink.ml` or under `flink.ml.math`. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
