Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1397#discussion_r50519736
--- Diff: docs/libs/ml/optimization.md ---
@@ -189,9 +187,26 @@ The following list contains a mapping between the
implementing classes and the r
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1397#issuecomment-173869263
@tillrohrmann Thanks! It is good news.
@rawkintrevo Thanks for contribution :+1:
---
If your project is set up for it, you can reply to this email and have your
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1397#issuecomment-173866185
Not squashing the commits here is the right way to go. We'll squash them
once we merge it.
---
If your project is set up for it, you can reply to this email and
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1397#discussion_r50519644
--- Diff: docs/libs/ml/optimization.md ---
@@ -276,6 +369,8 @@ val sgd = GradientDescentL1()
.setRegularizationConstant(0.2)
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1397#issuecomment-173867691
LGTM, will merge it then. I'll address @chiwanpark comment concerning the
`decay` value while merging it. Thanks for your work @rawkintrevo :-)
---
If your
Github user rawkintrevo commented on the pull request:
https://github.com/apache/flink/pull/1397#issuecomment-173893702
Thank you guys!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1397
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1397#discussion_r50391112
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/regression/MultipleLinearRegression.scala
---
@@ -107,6 +107,11 @@ class
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1397#discussion_r50401844
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/regression/MultipleLinearRegression.scala
---
@@ -107,6 +107,11 @@ class
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1397#discussion_r50391309
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/regression/MultipleLinearRegression.scala
---
@@ -107,6 +107,11 @@ class
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1397#discussion_r50389332
--- Diff: docs/libs/ml/optimization.md ---
@@ -256,6 +271,79 @@ The full list of supported prediction functions can be
found [here](#prediction-
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1397#discussion_r50394492
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/regression/MultipleLinearRegression.scala
---
@@ -107,6 +107,11 @@ class
Github user rawkintrevo commented on the pull request:
https://github.com/apache/flink/pull/1397#issuecomment-173578713
For sure, definitely want to close the books on this one, and I appreciate
all your help and patience as I have been learning. I will work on this tonight.
---
If
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1397#issuecomment-173573669
I had some minor comments. I also opened a PR against your branch
@rawkintrevo which shows how one could solve the problem with the enumerations
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1397#discussion_r50382914
--- Diff: docs/libs/ml/optimization.md ---
@@ -256,6 +271,79 @@ The full list of supported prediction functions can be
found [here](#prediction-
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1397#discussion_r50382898
--- Diff: docs/libs/ml/optimization.md ---
@@ -256,6 +271,79 @@ The full list of supported prediction functions can be
found [here](#prediction-
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1397#discussion_r50382928
--- Diff: docs/libs/ml/optimization.md ---
@@ -256,6 +271,79 @@ The full list of supported prediction functions can be
found [here](#prediction-
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1397#discussion_r50382852
--- Diff: docs/libs/ml/optimization.md ---
@@ -256,6 +271,79 @@ The full list of supported prediction functions can be
found [here](#prediction-
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1397#discussion_r50383721
--- Diff: docs/libs/ml/optimization.md ---
@@ -256,6 +271,79 @@ The full list of supported prediction functions can be
found [here](#prediction-
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1397#issuecomment-173583172
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1397#discussion_r50501474
--- Diff: docs/libs/ml/optimization.md ---
@@ -276,6 +369,8 @@ val sgd = GradientDescentL1()
.setRegularizationConstant(0.2)
Github user rawkintrevo commented on the pull request:
https://github.com/apache/flink/pull/1397#issuecomment-173801417
Sorry for the multiple commits- It wasn't registering the changes here so I
kept pushing... I can squash them if you want.
I update the docs per your
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1397#issuecomment-173806495
@rawkintrevo Thanks for update! I still prefer using a learning method
instance as parameter to remove method-specific parameter such as `decay`. But
It is not
Github user rawkintrevo commented on the pull request:
https://github.com/apache/flink/pull/1397#issuecomment-173422504
I can't get the enumeration thing to work. If you can modify it that would
be awesome. Thanks.
---
If your project is set up for it, you can reply to this email
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1397#issuecomment-170451422
I still would like to use enumeration because if we use string parameters,
the user cannot check that the input parameter is valid. But if you have some
problems to
Github user rawkintrevo commented on the pull request:
https://github.com/apache/flink/pull/1397#issuecomment-170257023
still refactoring to enumeration, but wanted to toss this up in case anyone
is watching- I added a decay parameter which significantly generalizes the Xu
and
Github user rawkintrevo commented on the pull request:
https://github.com/apache/flink/pull/1397#issuecomment-170162685
on your second point- I agree that Enum would be better for human readable
variable setting, but if one was doing a grid parameter search it would be
easier to
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1397#issuecomment-170200015
Hi @rawkintrevo, you can convert scala Enum to Int like following:
```scala
object Parameter extends Enumeration {
type Parameter = Value
val
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1397#discussion_r49211433
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/optimization/GradientDescent.scala
---
@@ -54,14 +54,15 @@ abstract class
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1397#issuecomment-169861378
Hi @rawkintrevo, I'm sorry about waiting you.
I have looked your pull request. Almost of changes are good but I have some
few comments.
First, there
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1397#issuecomment-167079605
Hi @rawkintrevo, I think you should rebase your branch instead of merging
master branch. Could you update your branch? Note that you should force push
(`git push -f
Github user rawkintrevo commented on the pull request:
https://github.com/apache/flink/pull/1397#issuecomment-159646696
That last fail looked like it happened in Kafka from something I never
touched? E.g. random. Is there anyway to just retry the travis-ci build?
---
If your project
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1397#issuecomment-159648629
The Kafka tests are not written in a bullet proof way. It may happen that
the Kafka test-cluster has a hickup, in which case the tests cannot succeed...
You
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1397#discussion_r45942541
--- Diff: flink-staging/flink-ml/pom.xml ---
@@ -80,7 +80,7 @@
-
Github user rawkintrevo commented on the pull request:
https://github.com/apache/flink/pull/1397#issuecomment-159780302
So... looks like this passed. What do I do next?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1397#issuecomment-159259389
There are still some scalastyle violations
```
error
GitHub user rawkintrevo opened a pull request:
https://github.com/apache/flink/pull/1397
[FLINK-1994] [ml] Add different gain calculation schemes to SGD
Continuation of pull request 1384.
Fixed long line issue, rebased on top of current master, and changed title
per
Github user rawkintrevo commented on the pull request:
https://github.com/apache/flink/pull/1384#issuecomment-159139713
did what you said ( I think ) and opened a new pull request
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user rawkintrevo closed the pull request at:
https://github.com/apache/flink/pull/1384
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
39 matches
Mail list logo
