Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/885
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-142527730
Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-142344379
The version of `maven-shade-plugin` is reverted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-142230271
Thanks a lot for working on this @chiwanpark.
I'll check out your pull request and try to integrate it with our nightly
deployment to the snapshot repository.
---
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/885#discussion_r40068488
--- Diff: flink-dist/pom.xml ---
@@ -305,6 +305,7 @@ under the License.
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/885#discussion_r40068542
--- Diff:
flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml
---
@@ -96,7 +96,7 @@ under the License.
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/885#discussion_r40078159
--- Diff: flink-dist/pom.xml ---
@@ -305,6 +305,7 @@ under the License.
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-141810617
I updated this PR. The changes are following:
* Add a bash script named `change-scala-version.sh` to change artifact id
* Add a missing flag `-Dscala-2.11`
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-141404870
I would suggest to change the scope of this pull request to enable
deploying a `_2.11` artifact for each module with the nightly snapshot builds.
You can test the
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-141425832
Sure, I don't have time over the weekend to work on this anyways ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-141416793
I hope to create a shell script and make setting for deploying `_2.11_
artifact. Could you wait a while to update this? Maybe I can update this PR
until this weekend.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-140731019
I agree. We need to use the script.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-138894613
I think that using property in artifact id causes many problems. Maybe
Spark faces the same problems, and uses shell script.
How about using the shell script
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-134624663
Cool, that was quick ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-134658771
Is the Maven shade plugin bug the reason why this fails:
```
ERROR] Failed to execute goal
org.apache.maven.plugins:maven-shade-plugin:2.4.1:shade
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/885#discussion_r37874193
--- Diff: flink-staging/flink-gelly/pom.xml ---
@@ -37,17 +37,17 @@ under the License.
dependencies
dependency
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-134623006
@rmetzger Thanks! I addressed your comment and rebased on master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-134667459
There is a Spark 2.11 artifact in mvn central.
I think they are doing a similar thing as we are already doing with the
hadoop1/hadoop2 versions: They generate
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-132934697
Thank you for opening an issue for the shade plugin.
I didn't forget this issue here. I'll look into it once I have a bit more
time.
Sorry for the delay.
---
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-125187262
Okay, I tried it again and you are right. It seems to create the artifacts
correctly.
I was confused because
a) the reactor summary didn't contain the variable:
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-125271970
There is wrong description in building documentation. Because Scala 2.11
profile activation is determined by property scala-2.11, Scala 2.10 profile
is activated when
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-125319617
When we upgrade version of maven-shade-plugin to 2.4.1, the property in
current project artifactId is interpolated properly. But the property in parent
artifactId is
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-124521433
Could you post your command to compile Flink with Scala 2.11? The current
setting works well in my environment. Maven module definitions is not artifact
id but
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/885#discussion_r35194868
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/assembly/word-count-storm.xml
---
@@ -36,7 +36,7 @@ under the
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-123643760
No need to hurry .. I needed 10 days to look at it .. so a few hours don't
matter ;)
I tried to install the artifacts to my local repository, but the _2.11
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-123640287
Sorry for the delay.
I will deploy the artifacts from this branch to the maven snapshot
repository to see if everything works as expected.
---
If your project is
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-123642852
Hi, currently this PR is not ready to merge, because this PR doesn't
contain changes for #677. I'll update soon. Unfortunately I'm outside now.
Maybe I can update
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-120720565
Let's wait for @rmetzger to give a +1 to this. He has done most of the POM
magic and can probably give a good review...
---
If your project is set up for it, you
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-120554092
If I get 1 more LGTM, I'll merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-120411775
Hi, I updated PR :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-120423639
Looks very neat!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-119578556
I agree with @aalexandrov to do the name switch using
`artifactIdflink-clients${scala.suffix}/artifactId`.
---
If your project is set up for it, you can reply to this
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-119622710
@rmetzger if you can hack your way with regex's in IntelliJ / Eclipse most
of the work should be handled by the IDE.
---
If your project is set up for it, you can
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/885#discussion_r34067611
--- Diff: docs/apis/programming_guide.md ---
@@ -187,7 +187,17 @@ that creates the type information for Flink operations.
/div
/div
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-118611879
@aalexandrov Thank you for review. :) I will applying your suggestion and
update this PR. But in this changes, all modules require the suffix if the
module is linked
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-118635826
Very good suggestions, @aalexandrov
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user chiwanpark opened a pull request:
https://github.com/apache/flink/pull/885
[FLINK-2200] Add Flink with Scala 2.11 in Maven Repository
Hi, This PR contains following changes:
* Add a suffix `_2.11` to all maven modules by profile setting.
(`-Pscala-2.11`)
*
Github user aalexandrov commented on a diff in the pull request:
https://github.com/apache/flink/pull/885#discussion_r33857654
--- Diff: docs/apis/programming_guide.md ---
@@ -136,7 +136,7 @@ mvn archetype:generate /
/div
/div
-The archetypes are working for
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-118326627
I think that a cleaner solution would be to
1. Add a `scala.suffix` to the Scala profiles. This should be set as the
empty string for 2.10 and as
Github user aalexandrov commented on a diff in the pull request:
https://github.com/apache/flink/pull/885#discussion_r33858383
--- Diff: docs/apis/programming_guide.md ---
@@ -187,7 +187,17 @@ that creates the type information for Flink operations.
/div
/div
Github user aalexandrov commented on a diff in the pull request:
https://github.com/apache/flink/pull/885#discussion_r33858475
--- Diff: docs/apis/programming_guide.md ---
@@ -187,7 +187,17 @@ that creates the type information for Flink operations.
/div
/div
41 matches
Mail list logo
